mirror of https://github.com/zulip/zulip.git
504 lines
15 KiB
JavaScript
504 lines
15 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
const Module = require("module");
|
|
const path = require("path");
|
|
|
|
const callsites = require("callsites");
|
|
|
|
const $ = require("../zjsunit/zjquery");
|
|
|
|
const new_globals = new Set();
|
|
let old_globals = {};
|
|
|
|
let actual_load;
|
|
const module_mocks = new Map();
|
|
const template_mocks = new Map();
|
|
const used_module_mocks = new Set();
|
|
const used_templates = new Set();
|
|
|
|
const jquery_path = require.resolve("jquery");
|
|
const real_jquery_path = require.resolve("../zjsunit/real_jquery.js");
|
|
|
|
let in_mid_render = false;
|
|
let jquery_function;
|
|
|
|
const template_path = "/static/templates/";
|
|
|
|
/* istanbul ignore next */
|
|
function need_to_mock_template_error(filename) {
|
|
const i = filename.indexOf(template_path);
|
|
|
|
if (i < 0) {
|
|
throw new Error("programming error");
|
|
}
|
|
|
|
const fn = filename.slice(i + template_path.length);
|
|
|
|
return `
|
|
Please use mock_template if your test needs to render ${fn}
|
|
|
|
We use mock_template in our unit tests to verify that the
|
|
JS code is calling the template with the proper data. And
|
|
then we use the results of mock_template to supply the JS
|
|
code with either the actual HTML from the template or some
|
|
kind of zjquery stub.
|
|
|
|
The basic pattern is this (grep for mock_template to see real
|
|
world examples):
|
|
|
|
run_test("test something calling template", ({mock_template}) => {
|
|
// We encourage you to set the second argument to false
|
|
// if you are not actually inspecting or using the results
|
|
// of actually rendering the template.
|
|
mock_template("${fn}", false, (data) => {
|
|
assert.deepEqual(data, {...};
|
|
// or assert more specific things about the data
|
|
return "stub-for-zjquery";
|
|
});
|
|
|
|
// If you need the actual HTML from the template, do
|
|
// something like below instead. (We set the second argument
|
|
// to true which tells mock_template that is should call
|
|
// the actual template rendering function and pass in the
|
|
// resulting html to us.
|
|
mock_template("${fn}", true, (data, html) => {
|
|
assert.deepEqual(data, {...};
|
|
assert.ok(html.startWith(...));
|
|
return html;
|
|
});
|
|
});
|
|
`;
|
|
}
|
|
|
|
function load(request, parent, isMain) {
|
|
const filename = Module._resolveFilename(request, parent, isMain);
|
|
if (module_mocks.has(filename)) {
|
|
used_module_mocks.add(filename);
|
|
const obj = module_mocks.get(filename);
|
|
return obj;
|
|
}
|
|
|
|
if (filename.endsWith(".hbs") && filename.includes(template_path)) {
|
|
const actual_render = actual_load(request, parent, isMain);
|
|
|
|
return template_stub({filename, actual_render});
|
|
}
|
|
|
|
if (filename === jquery_path && parent.filename !== real_jquery_path) {
|
|
return jquery_function || $;
|
|
}
|
|
|
|
return actual_load(request, parent, isMain);
|
|
}
|
|
|
|
function template_stub({filename, actual_render}) {
|
|
return function render(...args) {
|
|
// If our template is being rendered as a partial, always
|
|
// use the actual implementation.
|
|
if (in_mid_render) {
|
|
return actual_render(...args);
|
|
}
|
|
|
|
// Force devs to call mock_template on every top-level template
|
|
// render so they can introspect the data.
|
|
/* istanbul ignore if */
|
|
if (!template_mocks.has(filename)) {
|
|
throw new Error(need_to_mock_template_error(filename));
|
|
}
|
|
|
|
used_templates.add(filename);
|
|
|
|
const {exercise_template, f} = template_mocks.get(filename);
|
|
|
|
const data = args[0];
|
|
|
|
if (exercise_template) {
|
|
// If our dev wants to exercise the actual template, then do so.
|
|
// We set the in_mid_render bool so that included (i.e partial)
|
|
// templates get rendered.
|
|
in_mid_render = true;
|
|
const html = actual_render(...args);
|
|
in_mid_render = false;
|
|
|
|
return f(data, html);
|
|
}
|
|
|
|
return f(data);
|
|
};
|
|
}
|
|
|
|
exports.start = () => {
|
|
assert.equal(actual_load, undefined, "namespace.start was called twice in a row.");
|
|
actual_load = Module._load;
|
|
Module._load = load;
|
|
};
|
|
|
|
// We provide `mock_cjs` for mocking a CommonJS module, and `mock_esm` for
|
|
// mocking an ES6 module.
|
|
//
|
|
// A CommonJS module:
|
|
// - loads other modules using `require()`,
|
|
// - assigns its public contents to the `exports` object or `module.exports`,
|
|
// - consists of a single JavaScript value, typically an object or function,
|
|
// - when imported by an ES6 module:
|
|
// * is shallow-copied to a collection of immutable bindings, if it's an
|
|
// object,
|
|
// * is converted to a single default binding, if not.
|
|
//
|
|
// An ES6 module:
|
|
// - loads other modules using `import`,
|
|
// - declares its public contents using `export` statements,
|
|
// - consists of a collection of live bindings that may be mutated from inside
|
|
// but not outside the module,
|
|
// - may have a default binding (that's just syntactic sugar for a binding
|
|
// named `default`),
|
|
// - when required by a CommonJS module, always appears as an object.
|
|
//
|
|
// Most of our own modules are ES6 modules.
|
|
//
|
|
// For a third party module available in both formats that might present two
|
|
// incompatible APIs (especially if the CommonJS module is a function),
|
|
// Webpack will prefer the ES6 module if its availability is indicated by the
|
|
// "module" field of package.json, while Node.js will not; we need to mock the
|
|
// format preferred by Webpack.
|
|
|
|
exports.mock_cjs = (module_path, obj) => {
|
|
assert.notEqual(
|
|
module_path,
|
|
"jquery",
|
|
"We automatically mock jquery to zjquery. Grep for mock_jquery if you want more control.",
|
|
);
|
|
|
|
const filename = Module._resolveFilename(
|
|
module_path,
|
|
require.cache[callsites()[1].getFileName()],
|
|
false,
|
|
);
|
|
|
|
assert.ok(!module_mocks.has(filename), `You already set up a mock for ${filename}`);
|
|
|
|
assert.ok(
|
|
!(filename in require.cache),
|
|
`It is too late to mock ${filename}; call this earlier.`,
|
|
);
|
|
|
|
module_mocks.set(filename, obj);
|
|
return obj;
|
|
};
|
|
|
|
exports.mock_jquery = ($) => {
|
|
jquery_function = $; // eslint-disable-line no-jquery/variable-pattern
|
|
return $;
|
|
};
|
|
|
|
exports._start_template_mocking = () => {
|
|
template_mocks.clear();
|
|
used_templates.clear();
|
|
};
|
|
|
|
exports._finish_template_mocking = () => {
|
|
for (const filename of template_mocks.keys()) {
|
|
assert.ok(
|
|
used_templates.has(filename),
|
|
`You called mock_template with ${filename} but we never saw it get used.`,
|
|
);
|
|
}
|
|
template_mocks.clear();
|
|
used_templates.clear();
|
|
};
|
|
|
|
exports._mock_template = (fn, exercise_template, f) => {
|
|
const path = "../.." + template_path + fn;
|
|
|
|
const resolved_path = Module._resolveFilename(
|
|
path,
|
|
require.cache[callsites()[1].getFileName()],
|
|
false,
|
|
);
|
|
|
|
template_mocks.set(resolved_path, {exercise_template, f});
|
|
};
|
|
|
|
exports.mock_esm = (module_path, obj = {}) => {
|
|
assert.equal(typeof obj, "object", "An ES module must be mocked with an object");
|
|
return exports.mock_cjs(module_path, {...obj, __esModule: true});
|
|
};
|
|
|
|
exports.unmock_module = (module_path) => {
|
|
const filename = Module._resolveFilename(
|
|
module_path,
|
|
require.cache[callsites()[1].getFileName()],
|
|
false,
|
|
);
|
|
|
|
assert.ok(module_mocks.has(filename), `Cannot unmock ${filename}, which was not mocked`);
|
|
|
|
assert.ok(
|
|
used_module_mocks.has(filename),
|
|
`You asked to mock ${filename} but we never saw it during compilation.`,
|
|
);
|
|
|
|
module_mocks.delete(filename);
|
|
used_module_mocks.delete(filename);
|
|
};
|
|
|
|
exports.set_global = function (name, val) {
|
|
assert.notEqual(val, null, `We try to avoid using null in our codebase.`);
|
|
|
|
if (!(name in old_globals)) {
|
|
if (!(name in global)) {
|
|
new_globals.add(name);
|
|
}
|
|
old_globals[name] = global[name];
|
|
}
|
|
global[name] = val;
|
|
return val;
|
|
};
|
|
|
|
exports.zrequire = function (short_fn) {
|
|
assert.notEqual(
|
|
short_fn,
|
|
"templates",
|
|
`
|
|
There is no need to zrequire templates.js.
|
|
|
|
The test runner automatically registers the
|
|
Handlebar extensions.
|
|
`,
|
|
);
|
|
|
|
return require(`../../static/js/${short_fn}`);
|
|
};
|
|
|
|
const staticPath = path.resolve(__dirname, "../../static") + path.sep;
|
|
|
|
exports.complain_about_unused_mocks = function () {
|
|
for (const filename of module_mocks.keys()) {
|
|
/* istanbul ignore if */
|
|
if (!used_module_mocks.has(filename)) {
|
|
console.error(`You asked to mock ${filename} but we never saw it during compilation.`);
|
|
}
|
|
}
|
|
};
|
|
|
|
exports.finish = function () {
|
|
/*
|
|
Handle cleanup tasks after we've run one module.
|
|
|
|
Note that we currently do lazy compilation of modules,
|
|
so we need to wait till the module tests finish
|
|
running to do things like detecting pointless mocks
|
|
and resetting our _load hook.
|
|
*/
|
|
jquery_function = undefined;
|
|
|
|
assert.notEqual(actual_load, undefined, "namespace.finish was called without namespace.start.");
|
|
Module._load = actual_load;
|
|
actual_load = undefined;
|
|
|
|
module_mocks.clear();
|
|
used_module_mocks.clear();
|
|
|
|
for (const path of Object.keys(require.cache)) {
|
|
if (path.startsWith(staticPath)) {
|
|
delete require.cache[path];
|
|
}
|
|
}
|
|
Object.assign(global, old_globals);
|
|
old_globals = {};
|
|
for (const name of new_globals) {
|
|
delete global[name];
|
|
}
|
|
new_globals.clear();
|
|
};
|
|
|
|
exports.with_field = function (obj, field, val, f) {
|
|
assert.ok(
|
|
!("__esModule" in obj && "__Rewire__" in obj),
|
|
"Cannot mutate an ES module from outside. Consider exporting a test helper function from it instead.",
|
|
);
|
|
|
|
const had_val = Object.hasOwn(obj, field);
|
|
const old_val = obj[field];
|
|
try {
|
|
obj[field] = val;
|
|
return f();
|
|
} finally {
|
|
if (had_val) {
|
|
obj[field] = old_val;
|
|
} else {
|
|
delete obj[field];
|
|
}
|
|
}
|
|
};
|
|
|
|
exports.with_field_rewire = function (obj, field, val, f) {
|
|
// This is deprecated because it relies on the slow
|
|
// babel-plugin-rewire-ts plugin. Consider alternatives such
|
|
// as exporting a helper function for tests from the module
|
|
// containing the function you need to mock.
|
|
|
|
// https://github.com/rosswarren/babel-plugin-rewire-ts/issues/15
|
|
const old_val = field in obj ? obj[field] : obj.__GetDependency__(field);
|
|
|
|
assert.notEqual(
|
|
typeof old_val,
|
|
"function",
|
|
"Please try to avoid mocking here, or use override_rewire.",
|
|
);
|
|
|
|
try {
|
|
obj.__Rewire__(field, val);
|
|
return f();
|
|
} finally {
|
|
obj.__Rewire__(field, old_val);
|
|
}
|
|
};
|
|
|
|
exports.with_function_call_disallowed_rewire = function (obj, field, f) {
|
|
// This is deprecated because it relies on the slow
|
|
// babel-plugin-rewire-ts plugin.
|
|
|
|
// https://github.com/rosswarren/babel-plugin-rewire-ts/issues/15
|
|
const old_val = field in obj ? obj[field] : obj.__GetDependency__(field);
|
|
|
|
assert.equal(typeof old_val, "function", `Expected a function for ${field}`);
|
|
|
|
try {
|
|
obj.__Rewire__(
|
|
field,
|
|
/* istanbul ignore next */
|
|
() => {
|
|
throw new Error(`unexpected call to ${field}`);
|
|
},
|
|
);
|
|
return f();
|
|
} finally {
|
|
obj.__Rewire__(field, old_val);
|
|
}
|
|
};
|
|
|
|
exports.with_overrides = function (test_function) {
|
|
// This function calls test_function() and passes in
|
|
// a way to override the namespace temporarily.
|
|
|
|
const restore_callbacks = [];
|
|
const unused_funcs = new Map();
|
|
const override = function (obj, func_name, f) {
|
|
// Given an object `obj` (which is usually a module object),
|
|
// we re-map `obj[func_name]` to the `f` passed in by the caller.
|
|
// Then the outer function here (`with_overrides`) automatically
|
|
// restores the original value of `obj[func_name]` as its last
|
|
// step. Generally our code calls `run_test`, which wraps
|
|
// `with_overrides`.
|
|
|
|
assert.ok(
|
|
!("__esModule" in obj && "__Rewire__" in obj),
|
|
"Cannot mutate an ES module from outside. Consider exporting a test helper function from it instead.",
|
|
);
|
|
|
|
assert.equal(
|
|
typeof f,
|
|
"function",
|
|
"You can only override with a function. Use with_field for non-functions.",
|
|
);
|
|
|
|
assert.ok(
|
|
typeof obj === "object" || typeof obj === "function",
|
|
`We cannot override a function for ${typeof obj} objects`,
|
|
);
|
|
|
|
assert.ok(
|
|
obj[func_name] === undefined || typeof obj[func_name] === "function",
|
|
`
|
|
You are overriding a non-function with a function.
|
|
This is almost certainly an error.
|
|
`,
|
|
);
|
|
|
|
if (!unused_funcs.has(obj)) {
|
|
unused_funcs.set(obj, new Map());
|
|
}
|
|
|
|
unused_funcs.get(obj).set(func_name, true);
|
|
|
|
const old_f = obj[func_name];
|
|
const new_f = function (...args) {
|
|
unused_funcs.get(obj).delete(func_name);
|
|
return f.apply(this, args);
|
|
};
|
|
|
|
// Let zjquery know this function was patched with override,
|
|
// so it doesn't complain about us modifying it. (Other
|
|
// code can also use this, as needed.)
|
|
new_f._patched_with_override = true;
|
|
|
|
obj[func_name] = new_f;
|
|
restore_callbacks.push(() => {
|
|
obj[func_name] = old_f;
|
|
});
|
|
};
|
|
|
|
const override_rewire = function (obj, func_name, f) {
|
|
// This is deprecated because it relies on the slow
|
|
// babel-plugin-rewire-ts plugin. Consider alternatives such
|
|
// as exporting a helper function for tests from the module
|
|
// containing the function you need to mock.
|
|
|
|
assert.equal(
|
|
typeof f,
|
|
"function",
|
|
"You can only override with a function. Use with_field for non-functions.",
|
|
);
|
|
|
|
assert.ok(
|
|
typeof obj === "object" || typeof obj === "function",
|
|
`We cannot override a function for ${typeof obj} objects`,
|
|
);
|
|
|
|
assert.ok(
|
|
obj[func_name] === undefined || typeof obj[func_name] === "function",
|
|
`
|
|
You are overriding a non-function with a function.
|
|
This is almost certainly an error.
|
|
`,
|
|
);
|
|
|
|
if (!unused_funcs.has(obj)) {
|
|
unused_funcs.set(obj, new Map());
|
|
}
|
|
|
|
unused_funcs.get(obj).set(func_name, true);
|
|
|
|
// https://github.com/rosswarren/babel-plugin-rewire-ts/issues/15
|
|
const old_f = func_name in obj ? obj[func_name] : obj.__GetDependency__(func_name);
|
|
|
|
const new_f = function (...args) {
|
|
unused_funcs.get(obj).delete(func_name);
|
|
return f.apply(this, args);
|
|
};
|
|
|
|
obj.__Rewire__(func_name, new_f);
|
|
restore_callbacks.push(() => {
|
|
obj.__Rewire__(func_name, old_f);
|
|
});
|
|
};
|
|
|
|
try {
|
|
test_function({override, override_rewire});
|
|
} finally {
|
|
restore_callbacks.reverse();
|
|
for (const restore_callback of restore_callbacks) {
|
|
restore_callback();
|
|
}
|
|
}
|
|
|
|
for (const module_unused_funcs of unused_funcs.values()) {
|
|
for (const unused_name of module_unused_funcs.keys()) {
|
|
/* istanbul ignore next */
|
|
throw new Error(unused_name + " never got invoked!");
|
|
}
|
|
}
|
|
};
|