Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests
History
Steve Howell f0c99b42ec Rename people.add_in_realm to people.add(). 
We had this API:

    people.add_in_realm = full-fledged user
    people.add = not necessarily in realm

Now the API is this:

    people.add = full-fledged user
    people._add_user = internal API for cross-realm bots
        and deactivated users

I think in most of our tests the distinction between
people.add() and people.add_in_realm() was just an
accident of history and didn't reflect any real intention.

And if I had to guess the intention in 99% of the cases,
folks probably thought they were just creating ordinary,
active users in the current realm.

In places where the distinction was obviously important
(because a test failed), I deactivated the user via
`people.deactivate`.

For the 'basics' test in the people test suite, I clean
up the test setup for Isaac.  Before this commit I was
adding him first as a non-realm user then as a full-fledged
user, but this was contrived and confusing, and we
didn't really need it for test coverage purposes.
 		2020-03-22 10:55:11 -07:00
..
.eslintrc.json lint: Add JS indentation eslint rules for node_tests. 2018-05-06 19:35:18 -07:00
activity.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
alert_words.js refactor: Clean up alert_words API. 2020-02-27 11:10:13 -08:00
alert_words_ui.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
billing.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
billing_helpers.js zjsunit: Use assert in strict mode. 2020-02-12 08:16:26 -05:00
blueslip_stacktrace.js blueslip: Make stack trace more readable. 2019-10-31 13:47:54 -07:00
bot_data.js js: Convert _.pluck(a, "key") to item => item.key. 2020-02-27 17:20:34 -08:00
buddy_data.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
buddy_list.js zjsunit: Use assert in strict mode. 2020-02-12 08:16:26 -05:00
channel.js channel: Discard all HTTP responses while reloading. 2020-02-13 15:45:39 -08:00
color_data.js js: Automatically convert _.each to for…of. 2020-02-07 14:09:47 -08:00
colorspace.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
common.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
components.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
compose.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
compose_actions.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
compose_fade.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
compose_pm_pill.js Rename get_realm_persons() to get_realm_users(). 2020-03-22 10:55:11 -07:00
compose_ui.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
composebox_typeahead.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
copy_and_paste.js zjsunit: Make window a Proxy for global. 2019-11-13 14:27:13 -08:00
dispatch.js subscriber list: Fix display of email addresses in subscribers list. 2020-03-08 12:42:08 -07:00
drafts.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
echo.js ui_init: Handle page_params more cleanly. 2020-02-26 13:14:09 -08:00
emoji.js node tests: Remove dead code for emoji. 2020-02-26 07:19:00 -05:00
emoji_picker.js emoji_codes: Replace JS module with JSON module. 2020-02-12 10:09:12 -08:00
fenced_code.js compose: Add fences of unused length in quote-and-reply. 2020-02-04 18:17:47 -08:00
fetch_status.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
filter.js filter: Cache value of can_mark_messages_read. 2020-03-17 12:27:08 -07:00
fold_dict.js js: Replace [...x] with Array.from(x). 2020-02-05 11:52:52 -08:00
general.js minor: Remove obsolete comments about IIFEs. 2020-03-21 17:59:40 -04:00
hash_util.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
hashchange.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
hotkey.js emoji_codes: Replace JS module with JSON module. 2020-02-12 10:09:12 -08:00
i18n.js i18n: Rename translations.js to i18n.js. 2020-02-29 12:19:51 -08:00
input_pill.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
keydown_util.js keydown_util: Ignore alt-arrow and similar things. 2018-12-04 12:24:39 -08:00
lazy_set.js lazy_set: Convert LazySet to a real class. 2020-02-04 12:22:03 -08:00
lightbox.js rows.js: Add error handling to rows.id(). 2020-02-24 12:19:10 -08:00
list_cursor.js node tests: Bring list_cursor to 100% coverage. 2018-08-24 10:00:04 -07:00
list_render.js js: Convert _.contains(a, …) to a.includes(…). 2020-02-10 14:08:12 -08:00
markdown.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
message_edit.js echo: Further reduce local_id string vs. number confusion. 2020-02-12 10:39:01 -08:00
message_events.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
message_fetch.js node tests: Remove dead code for message_fetch. 2020-02-26 07:19:00 -05:00
message_flags.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
message_list.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
message_list_data.js js: Convert _.pluck(a, "key") to item => item.key. 2020-02-27 17:20:34 -08:00
message_list_view.js node tests: Remove feature_flags refs. 2020-02-26 07:19:00 -05:00
message_store.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
muting.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
narrow.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
narrow_activate.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
narrow_local.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
narrow_state.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
narrow_unread.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
notifications.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
password.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
people.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
people_errors.js markdown: Clean up userMentionHandler(). 2020-02-18 16:04:12 -08:00
pm_conversations.js ui_init: Pass params to pm_conversations.recent. 2020-02-27 11:10:13 -08:00
pm_list.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
poll_widget.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
popovers.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
presence.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
reactions.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
recent_senders.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
rtl.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
schema.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
scroll_util.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
search.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
search_legacy.js search_suggestions: Convert lookup_table from object to Map. 2020-02-12 10:39:01 -08:00
search_pill.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
search_suggestion.js refactor: Extract settings_data.py. 2020-02-28 17:11:24 -08:00
search_suggestion_legacy.js refactor: Extract settings_data.py. 2020-02-28 17:11:24 -08:00
server_events.js refactor: Rename set_realm_filters(). 2020-02-18 15:52:34 -08:00
settings_bots.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
settings_data.js settings: Add EMAIL_ADDRESS_VISIBILITY_NOBODY. 2020-03-06 16:34:08 -08:00
settings_muting.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
settings_org.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
settings_profile_fields.js zjsunit: Use assert in strict mode. 2020-02-12 08:16:26 -05:00
settings_user_groups.js Rename get_realm_persons() to get_realm_users(). 2020-03-22 10:55:11 -07:00
stream_data.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
stream_events.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
stream_list.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
stream_search.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
stream_sort.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
submessage.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
subs.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
support.js js: Automatically convert var to let and const in most files. 2019-11-03 12:42:39 -08:00
timerender.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
top_left_corner.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
topic_data.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
topic_generator.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
topic_list_data.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
transmit.js node tests: Remove dead code for transmit. 2020-02-26 07:19:00 -05:00
typeahead.js js: Convert _.filter(a, …) to a.filter(…). 2020-02-10 14:08:12 -08:00
typeahead_helper.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
typing_data.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
typing_status.js zjsunit: Use assert in strict mode. 2020-02-12 08:16:26 -05:00
ui.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
ui_init.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
unread.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
upgrade.js zjsunit: Use assert in strict mode. 2020-02-12 08:16:26 -05:00
upload.js node tests: Just set i18n every time. 2020-02-28 17:11:24 -08:00
user_events.js people: Rename method to get_by_user_id(). 2020-02-05 12:04:56 -08:00
user_groups.js ui_init: Handle page_params more cleanly. 2020-02-26 13:14:09 -08:00
user_pill.js Rename people.add_in_realm to people.add(). 2020-03-22 10:55:11 -07:00
user_status.js ui_init: Handle page_params more cleanly. 2020-02-26 13:14:09 -08:00
util.js util: Replace util.get_message_topic(). 2020-02-21 09:53:45 -05:00
vdom.js util.js: Remove util from window. 2020-02-15 12:20:20 -08:00
widgetize.js js: Convert _.clone(a) to { ...a } or a.slice(). 2020-02-25 14:26:06 -08:00
zblueslip.js node tests: Always enforce blueslip warn/error/fatal. 2020-02-07 14:15:44 -08:00
zjquery.js zjquery: Remove closest() implementation. 2020-02-11 14:19:03 -05:00