Go to file
Pedro Almeida ddfc2d230f resolve_topic: Prevent incorrect notification during message move.
This commit fixes the bug where the "topic unresolved" notification
is wrongly triggered when moving a message between a resolved and
unresolved topic, except for when the topics have the same name.

To resolve this issue, the commit ensures that resolved/unresolved
notifications are not sent if a message has been moved to a new
topic. This is achieved by comparing the names of the old and new
topics without considering the "resolved prefix".

The commit also accounts for the scenario where `new_topic_name`
has been truncated, indicating that it was resolved and the name
had to change to accommodate the "resolved prefix".

This solution does not try to specially handle the possible case that
a stream has two topics with the same name, even if one is resolved
and another unresolved.

Fixes #29007.
2024-07-07 11:38:14 -07:00
.github Revert "ci: Temporarily upgrade postgresql-client-common before upgrading." 2024-05-15 15:25:51 -07:00
.tx provision: Replace transifex-client with new transifex-cli. 2022-12-13 12:34:08 -08:00
.vscode vscode: Recommend remote development extension. 2021-11-03 16:03:46 -07:00
analytics push_notifs: Rename PushDeviceToken.GCM to FCM. 2024-06-17 18:22:59 -07:00
api_docs invites: Add option to receive notification on accepted invitations. 2024-07-05 17:14:45 -07:00
confirmation models: Migrate ids of all non-Message-related tables to bigint. 2024-06-05 11:48:27 -07:00
corporate billing: Migrate to @typed_endpoint. 2024-07-05 10:32:57 -07:00
docs docs: Add comma to all uses of "e.g." in contributor docs. 2024-07-05 15:36:24 -07:00
help docs: Update locations for topic notification status. 2024-07-05 16:36:49 -07:00
locale i18n: Update translation data from Transifex. 2024-06-26 14:06:27 -07:00
patches tippy: Add patch to avoid text Node as target in Firefox. 2024-07-05 10:15:45 -07:00
pgroonga migrations: Import BaseDatabaseSchemaEditor from its canonical module. 2023-03-05 14:46:28 -08:00
puppet documentation: Fix "you you" typos in docs/comments/logs. 2024-07-02 11:57:44 -07:00
requirements linter: Add check for comma after "e.g." in md files. 2024-07-05 15:36:24 -07:00
scripts documentation: Fix "you you" typos in docs/comments/logs. 2024-07-02 11:57:44 -07:00
static linter: Add check for comma after "e.g." in md files. 2024-07-05 15:36:24 -07:00
stubs/taint actions: Split out zerver.actions.message_send. 2022-04-14 17:14:34 -07:00
templates dev-tools: Add comma to use of "e.g." in populate_db description. 2024-07-05 15:36:24 -07:00
tools emoji_picker: Convert module to TypeScript. 2024-07-07 11:36:38 -07:00
var/puppeteer
web emoji_picker: Convert module to TypeScript. 2024-07-07 11:36:38 -07:00
zerver resolve_topic: Prevent incorrect notification during message move. 2024-07-07 11:38:14 -07:00
zilencer refactor: Rename `huddle` to `direct_message_group` in non API. 2024-07-04 07:56:31 -07:00
zproject realm-deactivation: Send email to owners as part of deactivation. 2024-06-26 16:48:18 -07:00
.codecov.yml
.codespellignore codespell: Fix spelling mistakes caught by codespell. 2024-05-31 14:32:33 -07:00
.editorconfig editorconfig: Use [[shell]] section for shfmt options. 2024-02-22 16:36:16 -05:00
.eslintignore web: Move web app to ‘web’ directory. 2023-02-23 16:04:17 -08:00
.eslintrc.js blueslip: Untangle from page_params. 2024-06-22 19:18:10 -07:00
.gitattributes .gitattributes: Mark *.bmp, *.bson, *.mp3, *.pdf as binary. 2022-02-07 18:51:06 -08:00
.gitignore tsconfig: Enable composite. 2024-06-09 12:08:03 -07:00
.gitlint lint: Update line-length for commit message to 72 in gitlint. 2023-05-01 10:35:52 -07:00
.mailmap mailmap: Add entry for Rohan Gudimetla. 2023-12-13 13:28:19 -08:00
.npmignore
.npmrc dependencies: Switch to pnpm. 2023-03-20 15:48:29 -07:00
.prettierignore marked: Fix type stub to declare marked as a CommonJS module. 2024-06-08 00:26:38 -07:00
.pyre_configuration
.readthedocs.yaml readthedocs: Add a configuration file. 2023-02-03 16:36:54 -08:00
.sonarcloud.properties
CODE_OF_CONDUCT.md linter: Add check for comma after "e.g." in md files. 2024-07-05 15:36:24 -07:00
CONTRIBUTING.md docs: Update CZO links from stream to channel in docs and comments. 2024-06-11 10:44:31 -07:00
Dockerfile-postgresql docs: Fix grammar errors found by mwic. 2023-10-09 13:24:09 -07:00
LICENSE
NOTICE
README.md docs: Update Ruff badge and links. 2023-10-26 15:51:46 -07:00
SECURITY.md docs: Update .html links pointing to "Upgrade Zulip" or "Modify Zulip". 2023-08-11 16:49:32 -07:00
Vagrantfile Upgrade development environment to Ubuntu 22.04. 2024-04-01 13:27:39 -07:00
dump.rdb stream-settings: Show indicator on notification settings. 2024-02-13 14:47:42 -08:00
manage.py mypy: Enable new error explicit-override. 2023-10-12 12:28:41 -07:00
package.json tippy: Add patch to avoid text Node as target in Firefox. 2024-07-05 10:15:45 -07:00
pnpm-lock.yaml tippy: Add patch to avoid text Node as target in Firefox. 2024-07-05 10:15:45 -07:00
prettier.config.js
pyproject.toml ruff: Enable FURB rules. 2024-06-30 22:37:15 -07:00
stylelint.config.js dependencies: Upgrade JavaScript dependencies. 2023-07-21 15:58:42 -07:00
tsconfig.json tsconfig: Enable composite. 2024-06-09 12:08:03 -07:00
version.py invites: Add option to receive notification on accepted invitations. 2024-07-05 17:14:45 -07:00

README.md

Zulip overview

Zulip is an open-source team collaboration tool with unique topic-based threading that combines the best of email and chat to make remote work productive and delightful. Fortune 500 companies, leading open source projects, and thousands of other organizations use Zulip every day. Zulip is the only modern team chat app that is designed for both live and asynchronous conversations.

Zulip is built by a distributed community of developers from all around the world, with 74+ people who have each contributed 100+ commits. With over 1000 contributors merging over 500 commits a month, Zulip is the largest and fastest growing open source team chat project.

Come find us on the development community chat!

GitHub Actions build status coverage status Mypy coverage Ruff code style: black code style: prettier GitHub release docs Zulip chat Twitter GitHub Sponsors

Getting started

You may also be interested in reading our blog, and following us on Twitter and LinkedIn.

Zulip is distributed under the Apache 2.0 license.