zulip/puppet/kandra/manifests
Alex Vandiver b0e3191434 puppet: Stop relying on "tidy" ordering, which ignores metaparams.
The `tidy` parameter is buggy, and ignores all ordering
metaparameters.  This is fixed in Puppet 7[^1], but it's helpful to
resolve it now.  Specifically, this fixes bugs with tidy running too
early, and deleting the old version of a package before its new
version is installed or symlinked, leaving a race condition if
anything tries to run the binary in this window.

This is mostly not a problem for Supervisor-managed processes, since
the binary is already running, and can continue to run if it is tidied
out from under the running process.  For stand-alone tools like wal-g,
which are run frequently by PostgreSQL, this may cause issues if
PostgreSQL tries to call them during a puppet run.

Remove all complicated uses of tidy, and replace them with an `exec`
which does the equivalent.  We also generate `file` resources for
binaries, making them easier (and clearer) to specify as dependencies.

[^1]: https://puppet.atlassian.net/browse/PUP-10688
2024-04-15 14:30:24 -07:00
..
profile puppet: Stop relying on "tidy" ordering, which ignores metaparams. 2024-04-15 14:30:24 -07:00
prometheus puppet: Stop relying on "tidy" ordering, which ignores metaparams. 2024-04-15 14:30:24 -07:00
teleport puppet: Switch from top-level fact variables to facts dict, again. 2024-04-05 09:18:04 -07:00
apache.pp kandra: Remove unnecessary libapache2-mod-wsgi. 2024-03-21 14:23:30 -07:00
app_frontend.pp kandra: Remove zulip::static_asset_compiler include. 2024-04-12 15:00:33 -07:00
app_frontend_monitoring.pp kandra: Add a memcached exporter using bmemcached. 2024-02-23 13:32:04 -08:00
aws_tools.pp puppet: Stop relying on "tidy" ordering, which ignores metaparams. 2024-04-15 14:30:24 -07:00
camo.pp
firewall.pp
firewall_allow.pp
ksplice_uptrack.pp puppet: Switch from top-level fact variables to facts dict, again. 2024-04-05 09:18:04 -07:00
prod_app_frontend_once.pp
ssh_authorized_keys.pp
ssh_keys.pp
statuspage.pp
user_dotfiles.pp kandra: Skip hostnames which are undef. 2024-02-07 10:42:12 -08:00
vector.pp puppet: Stop relying on "tidy" ordering, which ignores metaparams. 2024-04-15 14:30:24 -07:00