Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks
History
Eeshan Garg 4c0890e8b0 webhooks/github: Handle empty 'requested_reviewers' key. 
We recently received a bug report that implied that for certain
payloads, the `requested_reviewers` key was empty whereas a
singular `requested_reviewer` key containing one reviewer's
information was present in its stead. Naturally, this raised
some not so pretty IndexError exceptions.

After some investigation and generating a few similar payloads,
I discovered that in every case both the `requested_reviewers`
and the `requested_reviewer` keys were correctly populated, so I
had to manually edit the payload to reproduce the error on my end.

My guess is that this anomaly goes back to when GitHub's reviewer
request feature was new and didn't support requesting multiple
reviewers, and that the singular `requested_reviewer` key could
possibly just be there for backwards compatibility or might just
be mere oversight. Either way, the solution here is to look for the
plural `requested_reviewers` key, and if that is empty, fall back
to the singular `requested_reviewer` key.
 		2018-10-23 14:41:24 -07:00
..
airbrake zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
ansibletower integrations: Add Ansible Tower Webhook. 2018-09-21 11:05:36 -07:00
appfollow Enable pycodestyle W605 (invalid escape sequence). 2018-07-03 16:54:46 +02:00
appveyor integration: Add AppVeyor webhook. 2018-09-21 17:51:34 -07:00
basecamp webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
beanstalk webhooks/beanstalk: Improve test coverage. 2018-10-04 12:16:06 -07:00
beeminder zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
bitbucket zerver/webhooks: Change use of typing.Text to str. 2018-05-12 15:21:24 -07:00
bitbucket2 webhooks/bitbucket2: Improve commit_status_changed type messages. 2018-10-04 12:16:06 -07:00
circleci zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
clubhouse webhooks: Add Clubhouse integration. 2018-07-01 04:01:17 -07:00
codeship webhooks: Migrate 14 webhooks to use check_send_webhook_message. 2018-03-16 11:34:20 -07:00
crashlytics zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
delighted zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
deskdotcom zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
dialogflow zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
dropbox users: Get all API keys via wrapper method. 2018-08-08 16:35:17 -07:00
flock zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
freshdesk webhooks/freshdesk: Improve test coverage. 2018-10-04 12:16:06 -07:00
front org settings: Rename "Filter settings" to "Linkifiers". 2018-10-09 08:50:45 -07:00
gci zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
github webhooks/github: Handle empty 'requested_reviewers' key. 2018-10-23 14:41:24 -07:00
github_legacy users: Get all API keys via wrapper method. 2018-08-08 16:35:17 -07:00
gitlab webhooks/gitlab: Get test coverage up to 100%. 2018-10-04 12:16:06 -07:00
gocd zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
gogs webhooks/gogs: Include title in message body if not in topic. 2018-07-26 16:35:09 -07:00
gosquared zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
greenhouse webhooks/greenhouse: Ignore ping events. 2018-10-22 12:27:48 -07:00
groove zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
hellosign webhooks/hellosign: Rewrite the integration from scratch. 2018-10-04 12:16:06 -07:00
helloworld zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
heroku integrations: Fix heroku integration logging. 2018-07-01 12:43:31 -07:00
homeassistant zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
honeybadger/fixtures inetgrations: Add webhook payloads for Honeybadger. 2018-01-02 11:45:33 -05:00
ifttt webhooks/ifttt: Get test coverage up to 100%. 2018-10-04 12:16:06 -07:00
insping zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
intercom zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
jira users: Get all API keys via wrapper method. 2018-08-08 16:35:17 -07:00
librato webhooks/librato: Stop advertising Snapshot notifications. 2018-05-20 10:14:03 -07:00
mention webhooks/mention: Update docs to conform to style guide. 2018-05-20 10:54:13 -07:00
netlify webhooks: Add Netlify integration. 2018-10-05 17:04:40 -07:00
newrelic webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
opbeat zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
opsgenie zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
pagerduty webhooks/pagerduty: Update docs to conform to style guide. 2018-05-31 23:48:42 -04:00
papertrail zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
pingdom webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
pivotal webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
raygun zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
rollbar/fixtures integrations: Add webhook payloads for rollbar. 2018-01-11 06:32:37 -05:00
runscope/fixtures integrations: Add webhook payloads for Runscope. 2017-12-29 07:27:20 -05:00
semaphore zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
sentry webhooks/sentry: Update docs to conform to new style guide. 2018-04-23 12:03:34 -07:00
slack webhooks/slack: Update docs to conform to style guide. 2018-05-20 10:54:13 -07:00
solano zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
splunk zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
stash/fixtures webhooks: Rename webhook fixtures to only include event type. 2017-05-13 20:07:40 -02:30
statuspage webhooks/statuspage: Update docs to conform to style guide. 2018-05-20 10:54:13 -07:00
stripe webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
taiga webhooks/taiga: Add test for when a task is moved between stories. 2018-10-16 13:06:20 -07:00
teamcity webhooks/teamcity: Ignore third-party specific payload formats. 2018-08-13 14:54:43 -07:00
transifex webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
travis zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
trello webhooks/trello: Fix indentation and numbering. 2018-09-27 10:04:40 -07:00
updown webhooks: Migrate to UnexpectedWebhookEventType. 2018-05-22 08:30:19 -07:00
wordpress webhooks/wordpress: Update docs to conform to style guide. 2018-04-23 00:07:19 -07:00
yo zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
zabbix integrations: Add Zabbix webhook. 2018-06-07 08:31:24 -07:00
zapier integrations: Update Zapier doc. 2018-08-10 10:37:49 -07:00
zendesk zerver/webhooks: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
__init__.py
…
github_dispatcher.py webhooks: Move github_webhook/ to github/. 2018-04-19 11:00:55 -07:00