zulip/zerver
Mateusz Mandera c908b518ef CVE-2023-32678: Prevent unauthorized editing/deletion in priv streams.
Users who used to be subscribed to a private stream and have been
removed from it since retain the ability to edit messages/topics, and
delete messages that they used to have access to, if other relevant
organization permissions allow these actions. For example, a user may be
able to edit or delete their old messages they posted in such a private
stream. An administrator will be able to delete old messages (that they
had access to) from the private stream.

We fix this by fixing the logic in has_message_access (which lies at the
core of our message access checks - access_message() and
bulk_access_messages())
to not rely on only a UserMessage row for checking access but also
verify stream type and subscription status.
2023-08-25 14:10:27 -04:00
..
actions CVE-2023-32678: Prevent unauthorized editing/deletion in priv streams. 2023-08-25 14:10:27 -04:00
data_import ruff: Fix PERF102 Using only the keys/values of a dict. 2023-08-07 17:23:55 -07:00
integration_fixtures/nagios
lib CVE-2023-32678: Prevent unauthorized editing/deletion in priv streams. 2023-08-25 14:10:27 -04:00
management management: Validate string_id when creating or renaming a realm. 2023-08-23 16:33:13 -07:00
migrations scheduled-mails: Migrate existing scheduled emails to new templates. 2023-08-18 16:51:46 -07:00
openapi typing: Update main typing notifications protocol documentation. 2023-08-23 16:38:59 -07:00
tests CVE-2023-32678: Prevent unauthorized editing/deletion in priv streams. 2023-08-25 14:10:27 -04:00
tornado notifications: Rename 'pm' to 'dm' in 'RecipientInfoResult' dataclass. 2023-08-10 17:41:49 -07:00
transaction_tests user_groups: Make locks required for updating user group memberships. 2023-08-24 17:21:08 -07:00
views user_groups: Make locks required for updating user group memberships. 2023-08-24 17:21:08 -07:00
webhooks integrations: Add support for "Test plugin" in Sentry integration. 2023-08-22 12:09:02 -07:00
worker migration: Rename extra_data_json to extra_data in audit log models. 2023-08-16 17:18:14 -07:00
__init__.py
apps.py requirements: Upgrade Python requirements. 2023-04-03 22:39:21 -07:00
context_processors.py emails: Add corporate_enabled to context for emails. 2023-05-01 10:32:43 -07:00
decorator.py logging_util: Remove dependence on get_current_request. 2023-07-11 22:23:47 -07:00
filters.py error_notify: Remove custom email error reporting handler. 2023-07-20 11:00:09 -07:00
forms.py python: Convert translated positional {} fields to {named} fields. 2023-07-18 15:19:07 -07:00
logging_handlers.py error_notify: Remove custom email error reporting handler. 2023-07-20 11:00:09 -07:00
middleware.py middleware: Allow HTTP from localhost, not through a reverse proxy. 2023-08-17 12:07:37 -07:00
models.py message: Do not pass "sender__realm" to select_related. 2023-08-23 11:38:32 -07:00
signals.py requirements: Upgrade to Django 4.0. 2022-07-13 16:07:17 -07:00