zulip/zerver
Zixuan James Li c821127131 message_edit: Fix resolution notification not being sent twice.
We intended to send both the "topic was resolved" and the "topic was
moved here" notification when resolving and moving a topic at the same
time in #22312.

The previous implementation did not work as expected and it was only
sending the "topic was moved here" notification.

This removes the check for old_topic and new_topic that have
RESOLVED_TOPIC_PREFIX stripped in maybe_send_resolve_notifications, so
that the notification will be sent regardless if the topic name without
the prefix stays the same or not.

Note that weird topic handling ("✔ ✔✔ some topic") in the comments
was added in e231a03eff is unaffected. In case of confusion, the lstrip
check is not essential to detecting topic being unresolved/resolved.
As we mainly have that handled in the latter part of the helper.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-15 14:33:39 -08:00
..
actions message_edit: Fix resolution notification not being sent twice. 2022-11-15 14:33:39 -08:00
data_import Slack import: Cache emoji.json in static/generated/emoji. 2022-11-15 10:43:11 -08:00
integration_fixtures/nagios
lib tabbed-sections: Update "via-user-profile" to be "via-user-card". 2022-11-14 12:16:22 -08:00
management export_search: Add ability to limit by date sent. 2022-11-10 16:49:19 -08:00
migrations signup: Implement use of MultiUseInvite.status attribute. 2022-11-14 17:13:16 -08:00
openapi popovers: Rename "full profile" to "profile". 2022-11-14 12:16:22 -08:00
tests message_edit: Fix resolution notification not being sent twice. 2022-11-15 14:33:39 -08:00
tornado register: Handle "Pronouns" type fields for older mobile clients. 2022-11-04 14:31:18 -07:00
views signup: Implement use of MultiUseInvite.status attribute. 2022-11-14 17:13:16 -08:00
webhooks circleci: Rewrite integration to support the new webhook format. 2022-11-15 10:45:05 -08:00
worker python: Use format string for logging str(obj). 2022-10-10 08:32:29 -07:00
__init__.py
apps.py sentry: Initialize sentry in AppConfig ready hook. 2022-09-26 12:42:36 -07:00
context_processors.py templates: Rename `OPEN_GRAPH` variables to `PAGE` or `PAGE_METADATA`. 2022-09-06 14:57:06 -07:00
decorator.py python: Clean up getattr, setattr, delattr calls with literal names. 2022-10-10 08:40:28 -07:00
filters.py
forms.py forms: Fix another 500 error on realm creation with invalid email. 2022-09-19 14:12:32 -07:00
logging_handlers.py python: Use Python 3.8 typing.{Protocol,TypedDict}. 2022-04-27 12:57:49 -07:00
middleware.py middleware: Set the correct options on the django_language cookie. 2022-11-09 14:24:22 -08:00
models.py signup: Implement use of MultiUseInvite.status attribute. 2022-11-14 17:13:16 -08:00
signals.py requirements: Upgrade to Django 4.0. 2022-07-13 16:07:17 -07:00