Alex Vandiver c0e240277b tornado: Remove fingerprinting, write out .tmp files always. ... Fingerprinting the config is somewhat brittle -- it requires either custom bootstrapping for old (fingerprint-less) configs, and may have false-positives. Since generating the config is lightweight, do so into the .tmp files, and compare the output to the originals to determine if there are changes to apply. In order to both surface errors, as well as notify the user in case a restart is necessary, we must run it twice. The `onlyif` functionality cannot show configuration errors to the user, only determine if the command runs or not. We thus run the command once, judging errors as "interesting" enough to run the actual command, whose failure will be verbose in Puppet and halt any steps that depend on it. Removing the `onlyif` would result in `stage_updated_sharding` showing up in the output of every Puppet run, which obscures the important messages it displays when an update to sharding is necessary. Removing the `command` (e.g. making it an `echo`) would result in removing the ability to report configuration errors. We thus have no choice but to run it twice; this is thankfully low-overhead.		2020-09-25 10:52:40 -07:00
..
zulip	tornado: Remove fingerprinting, write out .tmp files always.	2020-09-25 10:52:40 -07:00
zulip_ops	python: Replace unnecessary intermediate lists with generators.	2020-09-02 11:15:41 -07:00