mirror of https://github.com/zulip/zulip.git
d47f29c2d6
This setting provides a more ergonomic experience when viewing a message where only a small number of emoji reactions are present; you no longer need to hover over the reaction to see who reacted, which is often quite important to understanding what it means. We added this setting (visible in the development environment only, and implemented on mobile) a few months ago; so to complete this feature, we just need to add the frontend rendering/live update logic and publish it. As documented in the code comments, the current rule is "messages with 3 or fewer reactions" for which messages will display the names of the users reacting. The previous set_reaction_count API made sense when the display of a given reaction was a pure function of its data. However, we will soon be making it a function of the total number of reactions on the message. Thus, view functions to update reaction display now need to call a shared update_vote_text_on_message function in all code paths, even code paths like "add the first vote for a reaction" and "remove the sole vote of a reaction" which previously did not need to call set_reaction_count. Fixes #20890. |
||
|---|---|---|
| .. | ||
| node_tests | ||
| puppeteer_lib | ||
| puppeteer_tests | ||
| zjsunit | ||