Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web
History
Tim Abbott b9af5ce86e unread: Fix process_visible race with fetching. 
The previous batch of improvements to this code path in
6562ea94e4 introduced a race bug where:

- You navigate to a narrowed view; Zulip renders cached data from
  `all_messages_data` that we know is current, but
  `fetch_status.has_found_newest` is initialized to `false`
  nonetheless.

- The bottom is visible, triggering the check for whether the view
  should be marked as read.

- `fetch_status.has_found_newest` is still `false`, and so we
  incorrectly refuse to mark as read.

- We finish fetching data from the server, do the background rerender
  for that (with no changes), but that doesn't trigger a re-check for
  whether the bottom is visible.

There's several ways to address this, but most correct to me is to not
check fetch_status in this particular code path.

The same reasoning applies to the navigate.js call sites.
 		2024-02-05 23:17:43 -08:00
..
e2e-tests eslint: Fix @typescript-eslint/no-unnecessary-type-assertion. 2024-01-29 16:14:26 -08:00
generated
…
html
…
images portico: Remove screenshots from /apps. 2024-01-31 16:10:32 -08:00
shared typeahead: Prefer word boundary matches to arbitrary substring matches. 2024-01-29 17:24:11 -08:00
src unread: Fix process_visible race with fetching. 2024-02-05 23:17:43 -08:00
styles css: Remove state dropdown-toggle class. 2024-02-03 17:20:28 -08:00
templates echo: Track if we are showing slow spinner for a message. 2024-02-05 11:06:46 -08:00
tests unread: Fix process_visible race with fetching. 2024-02-05 23:17:43 -08:00
third bootstrap: Remove unused dropdown toggle class definitions. 2024-02-03 17:20:28 -08:00
.browserslistrc
…
.gitignore
…
babel.config.js dependencies: Upgrade JavaScript dependencies. 2023-12-07 14:29:32 -08:00
debug-require-webpack-plugin.ts eslint: Fix @typescript-eslint/no-confusing-void-expression. 2023-12-21 16:14:40 -08:00
debug-require.js
…
postcss.config.js
…
webpack.assets.json bootstrap: Fork CSS into app, portico copies. 2024-01-28 15:07:36 -08:00
webpack.config.ts webpack_public_path: Replace with webpack 5 publicPath: "auto" setting. 2023-10-16 10:36:27 -07:00
webpack.dev-assets.json development: Update modal in emails page to use micromodal. 2023-10-05 09:28:27 -07:00