mirror of https://github.com/zulip/zulip.git
463929f349
Django treats path("<name>") like re_path(r"(?P<name>[^/]+)") and
path("<path:name>") like re_path(r"(?P<name>.+)").
This is more readable and consistent than the mix of slightly
different regexes we had before, and fixes various bugs:
• The r'apps/(.*)$' regex was missing a start anchor ^, so it
incorrectly matched all URLs that included apps/ as a substring
anywhere.
• The r'accounts/login/(google)/$' regex was missing a start anchor ^,
so it incorrectly matched all URLs that ended with
accounts/login/google/.
• The type annotation of zerver.views.realm_export.delete_realm_export
takes export_id as an int, but it was previously passed as a string.
• The type annotation of zerver.views.users.avatar takes medium as a
bool, but it was previously passed as a string.
• The [0-9A-Za-z]+ pattern for uidb64 was missing the - and _
characters that can validly be part of a base64url encoded
string (although I think the id is actually a decimal integer here,
in which case only 012345ADEIMNOQTUYcgjkwxyz are present in its
base64url encoding).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
|
||
|---|---|---|
| .. | ||
| confirm-preregistrationuser.js | ||
| desktop-login.js | ||
| desktop-redirect.js | ||
| dev-login.js | ||
| email_log.js | ||
| google-analytics.js | ||
| header.js | ||
| help.js | ||
| integrations.js | ||
| integrations_dev_panel.js | ||
| landing-page.js | ||
| signup.js | ||
| tabbed-instructions.js | ||
| team.js | ||