Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests
History
Steve Howell 8530ed0b5e org settings: Make button-clicking code more clear. 
On the "Organization settings" page, we had two Save buttons
for admins that had identical markup.  This was confusing for
people reading the code.  Now the two buttons have different
markup and individual, targeted click handlers (albeit still
calling the same function to do most of the work).

The context of this fix is that I was debugging a
Casper flake where our Casper tests were essentially clicking
on the same button twice.  Depending on the timing,
the second button click could cause a "No changes saved!"
behavior that confused the Casper test.  It is unclear whether
Casper was clicking both buttons here (in which case this fix
is necessary) or the same button twice (in which case this fix
just removes a nasty red herring for debugging).

The code still has the flaw that both buttons basically submit
the same data to the server, despite the appearance on the page
that there are two forms.  The best fix for that is probably
just to move the Language/Notifications stuff to another
panel.  I wanted to avoid touching this code altogether, but
the minor modifications here were necessary to improve the
Capser testing situation.
 		2018-01-16 13:25:19 -05:00
..
activity.js right-sidebar: Make Search people input collapsible with search icon. 2018-01-07 15:05:03 -05:00
alert_words.js node tests: Use zrequire in alert_words.js. 2017-11-08 12:24:17 -08:00
bot_data.js node tests: Use zrequire in bot_data.js. 2017-11-08 12:24:17 -08:00
channel.js node tests: Use zrequire in channel.js. 2017-11-08 12:24:17 -08:00
colorspace.js node tests: Use zrequire in colorspace.js. 2017-11-08 12:24:17 -08:00
common.js node tests: Use zrequire in common.js. 2017-11-08 12:24:17 -08:00
compose.js markdown: Add markdown shortcuts. 2018-01-02 13:48:50 -05:00
compose_actions.js narrow_state: Make set_compose_defaults return opts. 2017-12-03 14:01:19 -08:00
compose_fade.js node tests: Use zrequire in compose_fade.js. 2017-11-08 12:24:17 -08:00
compose_ui.js compose: Fix bug in undo operation 2017-12-10 04:10:18 -08:00
composebox_typeahead.js tests: Cover new composebox typeahead terminal symbols. 2017-12-08 01:00:38 -08:00
copy_and_paste.js Add filters for toMarkdown to paste data to compose-box. 2017-11-28 09:56:48 -08:00
dict.js node_tests: Remove unneeded var statements. 2017-11-08 12:24:17 -08:00
dispatch.js settings: Limit the creation of generic bots. 2018-01-02 18:12:22 -05:00
drafts.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
emoji.js node tests: Use zrequire in emoji.js. 2017-11-08 12:24:17 -08:00
emoji_picker.js node tests: Use zrequire in emoji_picker.js. 2017-11-08 12:24:17 -08:00
filter.js refactor: Stop using flags array for unread counts. 2017-12-26 09:01:21 -05:00
hashchange.js node tests: Use zrequire in hashchange.js. 2017-11-08 12:24:17 -08:00
hotkey.js Revert "dark-mode: Add "T" hotkey for dark mode theme." 2017-12-11 15:59:02 -06:00
i18n.js settings: Remove autoscroll_forever setting. 2018-01-02 10:35:49 -05:00
markdown.js local echo: Bypass message.flags array. 2017-12-26 09:01:21 -05:00
message_edit.js node tests: Use zrequire in message_edit.js. 2017-11-08 12:24:17 -08:00
message_list.js node tests: Use zrequire in message_list.js. 2017-11-08 12:24:17 -08:00
message_list_view.js node tests: Use zrequire in message_list_view.js. 2017-11-08 12:24:17 -08:00
message_store.js refactor: Delete deprecated message.flags attribute. 2017-12-26 09:01:21 -05:00
muting.js node tests: Use zrequire in muting.js. 2017-11-08 12:24:17 -08:00
narrow.js node_tests: Remove unneeded var statements. 2017-11-08 12:24:17 -08:00
narrow_state.js node tests: Add 100% coverage for narrow_state.js. 2017-12-18 09:57:43 -05:00
password.js node tests: Use zrequire in password.js. 2017-11-08 12:24:17 -08:00
people.js node tests: Use zrequire in people.js. 2017-11-08 12:24:17 -08:00
people_errors.js Change warn -> error in people.report_late_add(). 2017-11-07 09:51:10 -08:00
pm_conversations.js node tests: Use zrequire in pm_conversations.js. 2017-11-08 12:24:17 -08:00
pm_list.js Use zrequire in node_tests/pm_list.js. 2017-08-09 12:32:09 -07:00
presence.js node tests: Use zrequire in presence.js. 2017-11-08 12:24:17 -08:00
reactions.js settings: Add "text" option to emoji_set model. 2018-01-02 14:55:01 -05:00
recent_senders.js node tests: Use zrequire in recent_senders.js. 2017-11-08 12:24:17 -08:00
rtl.js node tests: Use zrequire in rtl.js. 2017-11-08 12:24:17 -08:00
search_suggestion.js node tests: Use zrequire in search_suggestion.js. 2017-11-08 12:24:17 -08:00
server_events.js local echo: Bypass message.flags array. 2017-12-26 09:01:21 -05:00
settings_bots.js embedded bots: Add config data UI. 2018-01-09 11:50:54 -05:00
settings_org.js org settings: Make button-clicking code more clear. 2018-01-16 13:25:19 -05:00
settings_user_groups.js settings_user_groups.js: Add node tests to increase test coverage. 2018-01-10 06:56:52 -05:00
stream_color.js node tests: Use zrequire in topic_data.js. 2017-11-08 12:24:17 -08:00
stream_data.js node tests: Enforce 100% coverage for stream_data.js. 2017-12-28 09:39:45 -05:00
stream_events.js Fix various typos. 2017-11-09 16:26:38 +01:00
stream_list.js frontend: Remove redundant stream separator in the left sidebar. 2017-11-15 10:06:25 -08:00
stream_sort.js node tests: Use zrequire in stream_sort.js. 2017-11-08 12:24:17 -08:00
subs.js node tests: Use zrequire in subs.js. 2017-11-08 12:24:17 -08:00
templates.js embedded bots: Add config data UI. 2018-01-09 11:50:54 -05:00
timerender.js node tests: Use zrequire in timerender.js. 2017-11-08 12:24:17 -08:00
top_left_corner.js Extract top_left_corner.js. 2017-08-14 13:03:57 -07:00
topic_data.js node tests: Use zrequire in topic_data.js. 2017-11-08 12:24:17 -08:00
topic_generator.js node tests: Use zrequire in topic_generator.js. 2017-11-08 12:24:17 -08:00
topic_list.js Simplify rendering of "more topics" link. 2017-09-26 13:58:54 -07:00
typeahead_helper.js bot settings: Clear typeahead when renaming a bot 2017-12-13 14:39:53 -06:00
typing_data.js node tests: Use zrequire in typing_data.js. 2017-11-08 12:24:17 -08:00
typing_status.js node tests: Use zrequire in typing_status.js. 2017-11-08 12:24:17 -08:00
unread.js refactor: Stop using flags array for unread counts. 2017-12-26 09:01:21 -05:00
upload.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
user_events.js node tests: Use zrequire in user_events.js. 2017-11-08 12:24:17 -08:00
user_groups.js node tests: Add 100% test coverage for user_groups.js. 2018-01-06 11:50:52 -05:00
util.js node tests: Use zrequire in util.js. 2017-11-08 12:24:17 -08:00
zjquery.js zjquery: Add $.create() method. 2017-07-08 10:32:32 -04:00