mirror of https://github.com/zulip/zulip.git
a34c01780f
When I added this "Deployed code" feature to the error reporting, I apparently hadn't worked out enough of how this code works to realize that `notify_server_error` may be in a different process, at a different time and potentially even on a different machine from the actual error being reported. Given that architecture, all the data about the error must be computed in `AdminNotifyHandler`, before sending the report through the queue, or else it risks being wrong. The job of `notify_server_error` and friends is only to format the data and send it off. So, move the implementation of this feature in order to do that. (@showell added some "nocoverage" directives here for code that is hard to test (exceptions being thrown, deployment files not existing) and that was originally part of a file that didn't require 100% coverage) |
||
|---|---|---|
| .. | ||
| fixtures | ||
| lib | ||
| management | ||
| migrations | ||
| templatetags | ||
| tests | ||
| tornado | ||
| views | ||
| webhooks | ||
| worker | ||
| __init__.py | ||
| apps.py | ||
| context_processors.py | ||
| decorator.py | ||
| filters.py | ||
| forms.py | ||
| logging_handlers.py | ||
| middleware.py | ||
| models.py | ||
| signals.py | ||
| static_header.txt | ||
| storage.py | ||