mirror of https://github.com/zulip/zulip.git
fdd63546b2
I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs. |
||
|---|---|---|
| .. | ||
| test_template_data | ||
| __init__.py | ||
| test_capitalization_checker.py | ||
| test_check_rabbitmq_queue.py | ||
| test_hash_reqs.py | ||
| test_html_branches.py | ||
| test_pretty_print.py | ||
| test_template_parser.py | ||
| test_zulint_custom_rules.py | ||