zulip

History

Anders Kaseorg 9f7c0b7e65 postgres_master.pp: Fix wacky su command line. The construction `su postgres -c -- bash -c 'psql …'` didn’t behave the way it reads, and only worked by accident: 1. `-c --` sets the command to `--`. 2. `bash` sets the first argument to `bash`. 3. `-c 'psql …'` replaces the command with `psql …`. Thus, `su` ended up executing `<shell> -c 'psql …' bash`, where `<shell>` is the `postgres` user’s login shell, usually also `bash`, which then executed 'psql …' and ignored the extra `bash`. Unconfuse this construction. Note from tabbott: The old code didn't even work by accident, it was just broken. The right fix is to move the quoting around properly. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>	2019-04-12 17:27:23 -07:00
..
zulip	puppet: Make uwsgi buffer size configurable.	2019-03-18 22:43:59 -07:00
zulip_ops	postgres_master.pp: Fix wacky su command line.	2019-04-12 17:27:23 -07:00

Anders Kaseorg 9f7c0b7e65 postgres_master.pp: Fix wacky su command line.

The construction `su postgres -c -- bash -c 'psql …'` didn’t behave the
way it reads, and only worked by accident:

1. `-c --` sets the command to `--`.
2. `bash` sets the first argument to `bash`.
3. `-c 'psql …'` replaces the command with `psql …`.

Thus, `su` ended up executing `<shell> -c 'psql …' bash`, where
`<shell>` is the `postgres` user’s login shell, usually also `bash`,
which then executed 'psql …' and ignored the extra `bash`.

Unconfuse this construction.

Note from tabbott: The old code didn't even work by accident, it was
just broken.  The right fix is to move the quoting around properly.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>

2019-04-12 17:27:23 -07:00

zulip

puppet: Make uwsgi buffer size configurable.

2019-03-18 22:43:59 -07:00

zulip_ops

postgres_master.pp: Fix wacky su command line.

2019-04-12 17:27:23 -07:00