mirror of https://github.com/zulip/zulip.git
96c61a1a41
I noticed this because the test_events.py tests had the extremely weird pattern of calling the actual change function, and then testing the `notify` function's state changes (which should always be noops), rather than actually testing the state change function. Fixing the test made it clear that the actual logic in events.py simply did not handle deleting custom_profile_field_value elements from user objects when a custom_profile_field object was deleted. So we fix that bit of logic as well. It appears this bug was unique -- at least we don't have any other notify_* functions being used directly in test_events.py, and the handful of state_change_expected=False entries are all events for data not present in page_params. |
||
|---|---|---|
| .. | ||
| data_import | ||
| lib | ||
| management | ||
| migrations | ||
| openapi | ||
| templatetags | ||
| tests | ||
| tornado | ||
| views | ||
| webhooks | ||
| worker | ||
| __init__.py | ||
| apps.py | ||
| context_processors.py | ||
| decorator.py | ||
| filters.py | ||
| forms.py | ||
| logging_handlers.py | ||
| middleware.py | ||
| models.py | ||
| signals.py | ||