Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js
History
Alexander Pushin 888f53de13 Fix collapsing messages in narrowed views. 
First user-fasing problem is that when user click to "Collapse" button
of message from narrowed list, buttons "Uncollapse" and "[More...]" does
not work. Second, is that when user collapse/uncollapse some message
from narrowed list, the collapsing/uncollapsing of the same message in
home list does not work in appropriate way.

In "popovers.js" there is the function that is called on click to the
buttons "Collapse" or "Un-collapse". It should show and hide body of a
message. If a message list is narrowed, it should show/hide message in
home list too. So, the first problem is that "toggle_row()" in this
function call methods "collapse(row)" or "uncollapse(row)" from
"condense.js" twice (for row and home_row) using condition
"if (message.collapsed)". When it happen the first time, the variable
"message.collapsed" is changed. That is why next call of "toggle_row()"
work incorrectly.

The second problem is that the function in "condense.js" that is
called on click to the button "[More...]" contains no code for
collapsing/uncollapsing message from home list. It just calls
"collapse(row)" or "uncollapse(row)" for row from narrowed list.

Now, functions "collapse(row)" and "uncollapse(row)" get row from
current list and change both messages (from current list and home
list). On-click functions call them just once for making all of needed
message changes. So, when user collapse or uncollapse message from
home or narrowed list it works correctly.

Fixes: #516
 		2016-03-20 16:58:57 -07:00
..
src Add webpack build process. 2015-11-06 09:13:25 -08:00
activity.js Fix performance issues with user presence list in large realms. 2016-02-12 20:04:43 -08:00
admin.js Fix regression when saving organization settings on administration page. 2016-03-17 18:29:04 -07:00
alert_words.js Use global match in alert word regex to match all matches 2014-03-11 13:06:16 -04:00
alert_words_ui.js Unbreak custom alert words on the settings page. 2014-03-04 18:06:48 -05:00
api.js Move zephyr/static to just static. 2013-07-29 12:11:26 -04:00
avatar.js Allow users to upload avatars on the Settings page. 2013-10-29 10:59:41 -04:00
blueslip.js Add a detailed description to event loop errors 2014-02-10 17:08:11 -05:00
bot_data.js Remove unused bot_data.get_all() 2014-03-14 20:48:45 -04:00
channel.js Make reload save options required explicit arguments. 2015-11-30 08:49:39 -08:00
click_handlers.js Move ui.js click handlers to click_handlers.js 2014-03-14 20:48:59 -04:00
colorspace.js Modify crumbbar style to look like an arrowbar 2014-02-18 12:50:29 -07:00
common.js Add curly braces for all javascript if statements lacking them. 2013-08-01 11:47:54 -04:00
compose.js Replace json/send_message endpoint usage with json/message. 2015-12-12 18:14:08 -08:00
compose_fade.js Update the message group fading to be message_container aware 2014-03-18 16:13:04 -04:00
composebox_typeahead.js Fix Javascript whitespace issues with {. 2015-11-10 10:01:34 -08:00
condense.js Fix collapsing messages in narrowed views. 2016-03-20 16:58:57 -07:00
copy_and_paste.js Create copy_and_paste.js (with code from ui.js). 2014-03-14 20:48:59 -04:00
custom_markdown.js Fix subscription button in notification bot announcements. 2016-03-09 20:36:42 -08:00
debug.js Replace $.each with _.each 2013-07-30 12:12:58 -04:00
dict.js Create blueslip error for undefined keys in Dict. 2013-09-11 18:07:37 -04:00
echo.js Show 5 most recent "Private messages" when clicked. 2015-12-15 07:52:54 -08:00
emoji.js Fix existing tab-based whitespace in the codebase. 2015-09-19 23:23:02 -07:00
favicon.js Move favicon-related functions to favicon.js 2014-03-14 20:48:55 -04:00
feature_flags.js Remove now-unused og_zuliper_emails variable. 2015-09-19 23:37:48 -07:00
fenced_code.js Tolerate spaces after language in markdown fences. 2014-03-06 10:15:20 -05:00
filter.js Add has_topic() helper to filter.js 2014-03-12 21:15:22 -04:00
floating_recipient_bar.js Created floating_recipient_bar.js (with code from ui.js). 2014-03-14 20:48:58 -04:00
gear_menu.js Ensure gear_menu.js is initialized before hashchange.js. 2015-09-19 23:23:01 -07:00
hashchange.js Created floating_recipient_bar.js (with code from ui.js). 2014-03-14 20:48:58 -04:00
hotkey.js Move resizing code to resize.js. 2014-03-14 20:48:55 -04:00
initial_invite.js Unbreak sending invites from the first user. 2014-01-13 10:36:48 -05:00
invite.js Unconditionally subscribe new users to the notification stream if it is public. 2014-01-23 17:06:26 -05:00
loading.js Moved loading_indicator functions to loading.js. 2014-03-14 20:48:52 -04:00
localstorage.js Add a localstorage.js module 2014-01-23 16:28:58 -05:00
message_edit.js Fix Javascript whitespace issues with {. 2015-11-10 10:01:34 -08:00
message_flags.js message_flags.js: Add comment 2014-03-11 13:06:21 -04:00
message_list.js Handle removing the selected local message from the message list 2014-03-14 20:48:57 -04:00
message_list_view.js Add a user-visible setting for 24-hour time display. 2015-08-20 17:33:16 -07:00
message_store.js Show 5 most recent "Private messages" when clicked. 2015-12-15 07:52:54 -08:00
muting.js Handle undefined keys in muting.is_topic_muted 2013-09-11 16:47:36 -04:00
muting_ui.js Add an idempotent flag to the channel module. 2014-01-10 21:39:00 -05:00
narrow.js Show current narrow in page title. 2015-12-14 21:21:30 -08:00
navigate.js Only cycle through stream elements when cycling through streams 2014-02-28 16:48:45 -05:00
notifications.js Initialize new_message_count to 0 by default. 2016-01-09 15:43:20 -08:00
people.js Fold case in people.js' dicts 2014-03-20 11:33:39 -04:00
popovers.js Fix collapsing messages in narrowed views. 2016-03-20 16:58:57 -07:00
referral.js Move resizing code to resize.js. 2014-03-14 20:48:55 -04:00
reload.js Make reload save options required explicit arguments. 2015-11-30 08:49:39 -08:00
resize.js Show 5 most recent "Private messages" when clicked. 2015-12-15 07:52:54 -08:00
rows.js Fix topic edits that are initiated from the FRB. 2014-03-14 20:48:55 -04:00
scroll_bar.js Created scroll_bar.js (with code taken from ui.js). 2014-03-14 20:48:56 -04:00
search.js Remove jquery.highlight 2014-01-15 16:07:20 -05:00
search_suggestion.js Handle negated person-related operators in search suggestions. 2014-03-05 10:54:02 -05:00
server_events.js Make reload save options required explicit arguments. 2015-11-30 08:49:39 -08:00
settings.js Add UserProfile flag to control whether we have a left side userlist. 2015-09-19 23:22:59 -07:00
setup.js Remove {show,destroy}_first_run_message. 2014-03-14 20:48:54 -04:00
signup.js Make login form validation errors not wrap 2013-09-16 14:20:43 -04:00
socket.js tests: Defer sockjs object creation when in testing 2014-03-11 13:06:20 -04:00
stream_color.js Fix stream color changes 2014-03-03 14:46:38 -07:00
stream_data.js Keep track of subs by stream_id inside of stream_data.js. 2014-02-06 12:09:52 -05:00
stream_list.js Show 5 most recent "Private messages" when clicked. 2015-12-15 07:52:54 -08:00
subs.js Replace /json/subscriptions/add usage with /json/users/me/subscription. 2015-12-12 18:14:08 -08:00
tab_bar.js update old messages' stream-color text class 2014-02-18 12:50:31 -07:00
templates.js Add a handlebars helper for variadic compound OR conditions. 2014-03-03 16:08:32 -05:00
timerender.js Better date separator rendering 2013-09-11 11:50:17 -07:00
tutorial.js Fix broken link to the cute guinea pig image in tutorial. 2016-01-09 22:52:35 -08:00
typeahead_helper.js Fix Javascript whitespace issues with {. 2015-11-10 10:01:34 -08:00
ui.js Defer permission for notifications until after tutorial. 2015-10-26 09:44:15 -07:00
unread.js Remove "More messages below" indicator 2015-03-30 15:44:36 -07:00
util.js Move favicon-related functions to favicon.js 2014-03-14 20:48:55 -04:00
viewport.js Clarify the left_side_userlist comment. 2015-09-19 23:39:54 -07:00
zulip.js Save compose state when reloading due to 'declare bankruptcy'. 2015-11-30 08:49:37 -08:00