mirror of https://github.com/zulip/zulip.git
a9356508ca
We used to send occupy/vacate events when either the first person entered a stream or the last person exited. It appears that our two main apps have never looked at these events. Instead, it's generally the case that clients handle events related to stream creation/deactivation and subscribe/unsubscribe. Note that we removed the apply_events code related to these events. This doesn't affect the webapp, because the webapp doesn't care about the "streams" field in do_events_register. There is a theoretical situation where a third party client could be the victim of a race where the "streams" data includes a stream where the last subscriber has left. I suspect in most of those situations it will be harmless, or possibly even helpful to the extent that they'll learn about streams that are in a "quasi" state where they're activated but not occupied. We could try to patch apply_event to detect when subscriptions get added or removed. Or we could just make the "streams" piece of do_events_register not care about occupy/vacate semantics. I favor the latter, since it might actually be what users what, and it will also simplify the code and improve performance. |
||
|---|---|---|
| .. | ||
| curl_param_value_generators.py | ||
| javascript_examples.js | ||
| javascript_examples.py | ||
| markdown_extension.py | ||
| openapi.py | ||
| python_examples.py | ||
| test_curl_examples.py | ||
| testing.yaml | ||
| zulip.yaml | ||