zulip/zerver
Greg Price 0213aa0b16 push notif: Don't forget to clear "active" flag on sending to bouncer.
Since da8f4bc0e back in August, this control flow has caused
`flags.active_mobile_push_notification` to be cleared if we don't send
these `remove` messages at all, and if we send them directly to GCM...
but not if we send them via the Zulip notification bouncer.

As a result, on a server configured to send `remove` notification-messages
via the bouncer, we accumulate "active" messages and never clear them.

If the user then does `mark_all_as_read`, we end up sending a `remove`
for each of those messages again, and all in one giant burst.  We've
seen puzzling bursts of hundreds of removals pass through the bouncer
since turning on removals on chat.zulip.org; it's likely many of them
are caused by this bug.

This issue was made more acute with f4478aad5, which unconditionally
enabled removals.

Test added by tabbott.
2019-02-14 14:52:53 -08:00
..
data_import help: Rename help/change-your-avatar to help/set-your-avatar. 2019-02-13 17:50:39 -08:00
lib push notif: Don't forget to clear "active" flag on sending to bouncer. 2019-02-14 14:52:53 -08:00
management management: Add tooling for transfering local uploads to s3. 2019-02-14 14:31:46 -08:00
migrations invites: Add backend for multiuse admin invites. 2019-02-07 15:41:00 -08:00
openapi api: Document support for setting stream description on creation. 2019-01-29 11:28:55 -08:00
templatetags zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
tests push notif: Don't forget to clear "active" flag on sending to bouncer. 2019-02-14 14:52:53 -08:00
tornado tornado: Remove unused imports. 2019-02-02 17:33:13 -08:00
views auth2: Don't use session for passing multiuse invite key. 2019-02-12 15:51:11 -08:00
webhooks zapier_app: Include bot details in response to auth requests. 2019-02-11 21:24:52 -08:00
worker zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
__init__.py
apps.py signals: Document the weird unused import for signal registration. 2019-02-02 23:04:02 -08:00
context_processors.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
decorator.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
filters.py error reports: Ensure we filter API keys from query strings. 2018-10-19 15:03:14 -07:00
forms.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
logging_handlers.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
middleware.py open graph: Remove extraneous spaces from descriptions. 2019-02-11 12:05:19 -08:00
models.py invites: Add backend for multiuse admin invites. 2019-02-07 15:41:00 -08:00
signals.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
static_header.txt