mirror of https://github.com/zulip/zulip.git
a67ecc0f36
Targeted fix for regression introduced in #23719 wherein failure reports were attempted for all CI failures, including those from forked pull requests, which don't have access to Actions Secrets. Since undefined Secrets are empty strings at interpolation time [^1], the underlying `send-message` Action was being called with no API Key, causing a failure in the failure handler. This fix is, per discussion in both a comment on #23719 and later on CZO [^2], prefered to restoring the prior guard against ZULIP_BOT_KEY being an empty string that had been in the shell script as it is more explicit in its intent. [^1]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-secrets [^2]: https://chat.zulip.org/#narrow/stream/43-automated-testing/topic/all.20branches.20failing/near/1475246 |
||
|---|---|---|
| .. | ||
| workflows | ||
| FUNDING.yml | ||
| pull_request_template.md | ||