zulip/frontend_tests
Steve Howell 82e453d9fe ui: Fix scrollbar regressions.
In between releases, the following commit introduced
a bug where we agressively scroll to the top every
place we call `ui.update_scrollbar`:

    092b73d0b7

The main symptoms were that the left and right sidebars
would go to the top for things like selecting a topic,
getting activity updates from the server, and resizing
the window.  It was very jarring.

The recent commit looked innocuous--the root of the problem
was the original API expressed an intent to scroll to the
top, but didn't actually do it, so it was a bug in hiding.

There are **some** occasions where it's actually appropriate
to scroll to the top, mostly around search filtering, and
in those places we now call the new `ui.reset_scrollbar`
function.

This is a bit of an emergency fix, so particularly with
the settings stuff, we may get more reports of glitches here.

The important thing here is that you almost never want to
reset the scrollTop for sidebars.
2019-01-09 09:15:45 -08:00
..
casper_lib eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
casper_tests eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
node_tests ui: Fix scrollbar regressions. 2019-01-09 09:15:45 -08:00
zjsunit lint: Enforce semicolon spacing in eslint. 2019-01-05 15:31:30 -08:00
.eslintrc.json lint: Check eslint indentation for casper tests. 2018-05-06 19:35:18 -07:00
run-casper tools: Remove pointless uses of shell=True. 2018-07-30 22:39:06 -07:00