Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests
History
Steve Howell 82e453d9fe ui: Fix scrollbar regressions. 
In between releases, the following commit introduced
a bug where we agressively scroll to the top every
place we call `ui.update_scrollbar`:

    092b73d0b7

The main symptoms were that the left and right sidebars
would go to the top for things like selecting a topic,
getting activity updates from the server, and resizing
the window.  It was very jarring.

The recent commit looked innocuous--the root of the problem
was the original API expressed an intent to scroll to the
top, but didn't actually do it, so it was a bug in hiding.

There are **some** occasions where it's actually appropriate
to scroll to the top, mostly around search filtering, and
in those places we now call the new `ui.reset_scrollbar`
function.

This is a bit of an emergency fix, so particularly with
the settings stuff, we may get more reports of glitches here.

The important thing here is that you almost never want to
reset the scrollTop for sidebars.
 		2019-01-09 09:15:45 -08:00
..
.eslintrc.json lint: Add JS indentation eslint rules for node_tests. 2018-05-06 19:35:18 -07:00
activity.js frontend: Add event handling for user status. 2019-01-02 09:16:31 -08:00
alert_words.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
alert_words_ui.js tests: Test closing alert word status msg. 2018-07-23 14:53:49 -04:00
billing.js billing: Add node test for billing.js. 2019-01-08 10:47:35 -08:00
billing_helpers.js billing: Use underscore built in contains function. 2019-01-08 10:47:35 -08:00
bot_data.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
buddy_data.js status: Show "(away)" next to yourself if you're away. 2019-01-02 09:27:16 -08:00
buddy_list.js buddy list: Add padding to progressive scrollings. 2018-08-02 16:59:27 -07:00
channel.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
color_data.js stream_color: Make stream color assignment more efficient. 2018-11-29 13:00:25 -08:00
colorspace.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
common.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
components.js eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
compose.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
compose_actions.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
compose_fade.js subject -> topic: Rename compose fields. 2018-12-09 21:28:45 -08:00
compose_pm_pill.js compose pill: Add has_unconverted_data() helper. 2018-10-12 11:20:30 -07:00
compose_ui.js compose_ui: Create the `compose_ui.replace_syntax` function. 2018-08-26 23:33:24 -07:00
composebox_typeahead.js emoji: Merge datasources for emoji picker and typeahead. 2019-01-05 15:09:04 -08:00
copy_and_paste.js jsdom: Upgrade jsdom to v11.10.0. 2018-05-20 11:11:03 -07:00
dict.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
dispatch.js emoji: Merge datasources for emoji picker and typeahead. 2019-01-05 15:09:04 -08:00
drafts.js drafts: Use lists instead of dicts. 2018-12-16 15:46:41 -08:00
emoji.js emoji: Change fallback emojiset for text emojiset. 2018-09-21 18:34:12 -07:00
emoji_picker.js emoji: Move `emoji_collection` from emoji picker to emoji.js. 2018-07-23 12:35:08 -07:00
fetch_status.js message_fetch: Deduplicate logic for finish_newer_batch. 2018-12-13 08:43:56 -08:00
filter.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
general.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
hash_util.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
hashchange.js settings: Streamline how we launch settings. 2018-12-07 11:40:56 -08:00
hotkey.js hotkeys: Map `CTRL + .` to narrow to compose box target. 2018-12-04 13:58:00 -08:00
i18n.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
input_pill.js input pills: Fix modal gets closed when user click on remove-pill-btn. 2018-11-28 16:33:08 -08:00
keydown_util.js keydown_util: Ignore alt-arrow and similar things. 2018-12-04 12:24:39 -08:00
lightbox.js thumbnails: Rename data-original to data-src-fullsize. 2018-07-30 13:00:23 -07:00
list_cursor.js node tests: Bring list_cursor to 100% coverage. 2018-08-24 10:00:04 -07:00
list_render.js list_render: Remove rows sort click handler from the body. 2018-06-22 09:21:47 -04:00
markdown.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_edit.js message_edit: Allow editing topics indefinitely. 2018-12-04 17:41:21 -08:00
message_events.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_fetch.js Refactor: Split up add_messages api. 2019-01-07 17:17:55 -08:00
message_flags.js frontend: Create data structure for starred messages. 2018-08-21 13:42:23 -07:00
message_list.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_list_data.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_list_view.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_store.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
muting.js page load: Fix two bugs related to muting/unreads. 2018-12-15 13:44:30 -08:00
narrow.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow_activate.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow_local.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow_state.js filter: Eliminate a few "subject" references. 2018-12-29 11:38:39 -08:00
narrow_unread.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
notifications.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
password.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
people.js custom profile fields: Markdown rendering for custom profile field values. 2019-01-01 21:06:21 -08:00
people_errors.js minor: Change error to warning for missing user ids. 2018-10-29 12:57:15 -07:00
pm_conversations.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
pm_list.js refactor: Move pm_with_uri to hash_util. 2018-08-04 09:32:27 -07:00
popovers.js status: Add user menu options to set/revoke away status. 2019-01-02 09:23:20 -08:00
presence.js presence: Use people.is_my_user_id() for check. 2019-01-03 13:49:44 -08:00
reactions.js emoji: Move `emoji_collection` from emoji picker to emoji.js. 2018-07-23 12:35:08 -07:00
recent_senders.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
rtl.js rtl.js: Fix support for supplementary planes of unicode characters (>= U+10000). 2018-08-14 11:39:29 -07:00
schema.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
scroll_util.js scroll_util: Account for element padding in height calculations. 2018-07-27 09:09:52 -07:00
search.js Revert "search: Open typeahead on empty string only if lookup triggered by Tab." 2018-12-04 13:58:00 -08:00
search_legacy.js Simplify narrow/search interactions. 2018-10-24 16:54:35 -07:00
search_pill.js search: Add a basic implementation of search pills. 2018-07-23 11:29:10 -07:00
search_suggestion.js search: Do not display `All messages` suggestion if bar not empty. 2018-07-23 11:29:10 -07:00
search_suggestion_legacy.js search: Duplicate search_suggestions.get_suggestions. 2018-07-23 11:29:10 -07:00
server_events.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
settings_bots.js eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
settings_muting.js muting: Use stream_id in muting.get_muted_topics(). 2018-12-14 16:05:37 -08:00
settings_org.js settings: Add support for customizing the top-left logo. 2018-12-18 12:44:52 -08:00
settings_profile_fields.js custom profile field: Minor tweaks in field-table in admin settings. 2018-08-21 11:42:59 -07:00
settings_user_groups.js settings: Confirm before deleting user groups. 2018-10-12 10:38:56 -07:00
stream_data.js refactor: Call stream_data.initialize() more directly. 2018-12-15 13:44:30 -08:00
stream_events.js Extract color_data.js. 2018-11-28 14:51:51 -08:00
stream_list.js Use stream_id for by_stream__uri(). 2018-12-14 16:05:40 -08:00
stream_search.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
stream_sort.js eslint: Enable `no-extra-parens` rule. 2018-06-11 07:51:24 -04:00
submessage.js submessages: Add update_message() function. 2018-05-30 14:47:36 -07:00
subs.js ui: Fix scrollbar regressions. 2019-01-09 09:15:45 -08:00
templates.js custom profile fields: Markdown rendering for custom profile field values. 2019-01-01 21:06:21 -08:00
timerender.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
top_left_corner.js filter: Eliminate a few "subject" references. 2018-12-29 11:38:39 -08:00
topic_data.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
topic_generator.js zblueslip: Convert node_tests/topic_generator.js to zblueslip. 2018-07-10 16:22:52 -04:00
topic_list.js subject -> topic: Fix hash_util.js. 2018-12-29 14:34:06 -08:00
transmit.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
typeahead_helper.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
typing_data.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
typing_status.js Add run_test helper for individual tests. 2018-05-15 08:24:44 -07:00
ui.js hotkey: Update test for hotkey deprecation. 2018-09-21 10:59:55 -07:00
ui_init.js node: Fix ui_init test failing due to night_mode initialization. 2019-01-04 11:44:56 -08:00
unread.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
upload.js upload: Use a placeholder when uploading. 2018-08-26 23:33:24 -07:00
user_events.js custom profile fields: Markdown rendering for custom profile field values. 2019-01-01 21:06:21 -08:00
user_groups.js zblueslip: Convert node_tests/user_groups.js to zblueslip. 2018-07-10 16:22:52 -04:00
user_pill.js pills: Enable user avatar images for user pills. 2018-07-10 15:07:56 +05:30
user_status.js frontend: Add basic user_status module. 2019-01-02 09:16:31 -08:00
util.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
voting_widget.js widgets: Rename voting_widget to poll_widget. 2018-12-16 19:46:48 -08:00
widgetize.js widgets: Rename voting_widget to poll_widget. 2018-12-16 19:46:48 -08:00
zblueslip.js zblueslip: Add exception_msg and wrap_function functions. 2018-07-10 16:22:52 -04:00
zjquery.js zjquery: Show multiple handlers in demo code. 2018-07-18 08:25:15 -04:00