Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests
History
Tim Abbott 1d5204c82b narrow: Fix incorrect values for use_first_unread_anchor. 
Apparently, we were incorrectly passing through something related to
opts.use_initial_narrow_pointer as the value for `use_first_anchor`.

If you read the logic in narrow.js carefully,
use_initial_narrow_pointer was unconditionally false.

The correct value for this attribute is when we're trying to narrow to
the first unread message in a given context.  There are two things to
check:

* then_select_id is -1; i.e. we don't have a specific message ID we're
  trying to narrow around.
* select_first_unread is True, i.e. we're trying to narrow to the
  first unread message.

A bit more work should allow us to get rid of the second condition,
but I'm not quite confident enough to do that yet.
 		2018-04-22 21:33:14 -07:00
..
activity.js node tests: Localize focus logic for activity.js. 2018-04-22 20:08:08 -07:00
alert_words.js node_tests: Update alert_words.js to use es6. 2018-04-20 15:46:28 -04:00
bot_data.js quick fix: Revert ES6 idiom that istanbul warns about. 2018-04-20 16:33:33 -07:00
buddy_data.js buddy list: Shrink overly large lists. 2018-04-22 20:08:08 -07:00
channel.js node_tests: Update channel.js to use es6. 2018-04-20 15:46:28 -04:00
colorspace.js node tests: Use zrequire in colorspace.js. 2017-11-08 12:24:17 -08:00
common.js node tests: Use zrequire in common.js. 2017-11-08 12:24:17 -08:00
components.js refactor: Remove factory code for toggle component. 2018-04-20 13:45:58 -07:00
compose.js zblueslip: Convert node_tests/compose.js to zblueslip. 2018-04-19 15:02:00 -04:00
compose_actions.js node tests: Remove extra $ declaration. 2018-04-17 17:52:19 -07:00
compose_fade.js node tests: Remove unneeded $ stub in compose_fade.js. 2018-04-17 17:52:19 -07:00
compose_pm_pill.js pm_pill: Achieve 100% node-test coverage for compose_pm_pill.js. 2018-04-13 11:59:57 -07:00
compose_ui.js compose: Append space when text added at the end of textarea. 2018-03-04 13:16:17 -08:00
composebox_typeahead.js emoji: Prefix sort for emojis. 2018-04-21 22:28:45 -07:00
copy_and_paste.js copy_and_paste: Re-disable copy-paste handler in production. 2018-04-09 22:10:28 -07:00
dict.js node_tests: Remove unneeded var statements. 2017-11-08 12:24:17 -08:00
dispatch.js server_events_dispatch: Add node coverage for user groups. 2018-04-19 14:59:08 -04:00
drafts.js drafts: Add tests for draft formatting and sorting. 2018-03-14 10:57:11 -07:00
emoji.js zblueslip: Convert node_tests/emoji.js to zblueslip. 2018-04-19 15:02:00 -04:00
emoji_picker.js node tests: Use zrequire in emoji_picker.js. 2017-11-08 12:24:17 -08:00
fetch_status.js Revert "Ignore new messages when lists are behind." 2018-03-30 11:52:14 -07:00
filter.js CVE-2018-9990: Fix XSS issue with stream names in topic typeahead. 2018-04-12 09:46:54 -07:00
general.js node tests: Add general.js. 2018-04-17 17:52:19 -07:00
hash_util.js hash_util: Add 100% node-coverage for hash_util.js. 2018-04-19 14:59:08 -04:00
hashchange.js node tests: Add coverage to hashchange.js. 2018-04-17 17:52:19 -07:00
hotkey.js node tests: Use zjquery in hotkey.js. 2018-04-17 17:52:19 -07:00
i18n.js message view: Hide "view source" and "quote" for deleted messages. 2018-03-27 16:43:24 -07:00
input_pill.js pills: Use a template to render the pills. 2018-03-31 09:32:52 -07:00
list_render.js node tests: Add some coverage to list_render.js. 2018-04-17 17:52:19 -07:00
markdown.js zjsunit: Extract read_fixture_data(). 2018-04-17 17:52:19 -07:00
message_edit.js node tests: Use zrequire in message_edit.js. 2017-11-08 12:24:17 -08:00
message_fetch.js Test maybe_load_newer_messages. 2018-03-28 09:13:46 -07:00
message_list.js node: Fix test failures due to missing import. 2018-03-09 14:24:08 -08:00
message_list_view.js node tests: Add test_render_windows(). 2018-03-25 10:18:00 -07:00
message_store.js refactor: Extract pm_conversations.recent. 2018-02-12 09:34:59 -08:00
muting.js node tests: Use zrequire in muting.js. 2017-11-08 12:24:17 -08:00
narrow.js node tests: Fix some leaks with $(...). 2018-04-12 11:37:00 -07:00
narrow_activate.js narrow: Fix incorrect values for use_first_unread_anchor. 2018-04-22 21:33:14 -07:00
narrow_state.js Add narrow_state.pm_string(). 2018-02-12 09:34:59 -08:00
notifications.js node-tests: Add basic tests for notifications API. 2018-04-13 09:13:50 -07:00
password.js node tests: Use zrequire in password.js. 2017-11-08 12:24:17 -08:00
people.js people: Extract small_avatar_url_for_person. 2018-04-09 12:12:44 -07:00
people_errors.js zblueslip: Convert node_tests/people_errors.js to zblueslip. 2018-04-19 15:02:00 -04:00
pm_conversations.js Add pm_conversations.recent.get_strings(). 2018-02-12 09:34:59 -08:00
pm_list.js refactor: Extract pm_conversations.recent. 2018-02-12 09:34:59 -08:00
popovers.js node tests: Add coverage for popovers.js. 2018-04-17 17:52:19 -07:00
presence.js node tests: Use zrequire in presence.js. 2017-11-08 12:24:17 -08:00
reactions.js Fix recently broken reactions tests with s/html/text/. 2018-04-12 11:29:08 -07:00
recent_senders.js recent senders: Use message ids instead of timestamps for sorting. 2018-02-08 18:39:10 -08:00
rtl.js node tests: Use zrequire in rtl.js. 2017-11-08 12:24:17 -08:00
search_suggestion.js CVE-2018-9990: Fix XSS issue with stream names in topic typeahead. 2018-04-12 09:46:54 -07:00
server_events.js local echo: Bypass message.flags array. 2017-12-26 09:01:21 -05:00
settings_bots.js settings: Focus "Add a new bot" tab when there is no active bot. 2018-03-30 16:07:01 +05:30
settings_muting.js muting: Achieve 100% node-test coverage for settings_muting.js. 2018-04-13 11:59:57 -07:00
settings_org.js node tests: Increase coverage for settings_org. 2018-04-19 14:58:12 -04:00
settings_user_groups.js settings: Avoid duplicate form handlers. 2018-03-25 08:28:04 -07:00
stream_color.js node tests: Use zrequire in topic_data.js. 2017-11-08 12:24:17 -08:00
stream_data.js subscription: Add real time sync for user-just-deactivated case. 2018-04-08 16:54:12 -07:00
stream_events.js tests: Fix mock setup for update_calculated_fields. 2018-03-09 18:23:18 -08:00
stream_list.js Refactor perfect-scrollbar: Call ui methods in stream_list.js. 2018-03-16 12:47:47 -07:00
stream_sort.js node tests: Use zrequire in stream_sort.js. 2017-11-08 12:24:17 -08:00
subs.js subscriptions: Use tooltips for stream info hover content. 2018-03-18 19:44:53 -07:00
templates.js profile: Add hint field in the settings UI. 2018-04-19 11:32:45 -07:00
timerender.js install-node: Upgrade node, yarn, and nvm. 2018-04-09 13:56:48 -07:00
top_left_corner.js tests: Fully cover top_left_corner.js. 2018-04-19 14:56:55 -04:00
topic_data.js node tests: Use zrequire in topic_data.js. 2017-11-08 12:24:17 -08:00
topic_generator.js lint: Replace 'return undefined;' with 'return;'. 2018-03-13 08:22:42 -04:00
topic_list.js Add stream ids to urls for stream-related narrows. 2018-02-19 09:03:11 -08:00
transmit.js websockets: Fix race condition in CSRF token initialization. 2018-03-31 09:29:56 -07:00
typeahead_helper.js emoji: Prefix sort for emojis. 2018-04-21 22:28:45 -07:00
typing_data.js node tests: Use zrequire in typing_data.js. 2017-11-08 12:24:17 -08:00
typing_status.js node tests: Use zrequire in typing_status.js. 2017-11-08 12:24:17 -08:00
unread.js refactor: Stop using flags array for unread counts. 2017-12-26 09:01:21 -05:00
upload.js compose: Change styling of upload progress bar. 2018-04-16 09:46:35 -07:00
user_events.js custom profile data: Send event to active user on update. 2018-03-21 16:08:12 -07:00
user_groups.js user-groups: Achieve 100% node-test coverage of user_groups.js. 2018-03-15 10:09:28 -07:00
user_pill.js node tests: Add tests for user_pill.js. 2018-03-07 15:53:11 -08:00
util.js markdown: Add @stream as an alias for @all. 2018-04-09 16:35:14 -07:00
zblueslip.js zblueslip: Create zblueslip.js for improved error handling. 2018-04-19 15:02:00 -04:00
zjquery.js zjquery: Support $.fn.foo mechanism. 2018-04-12 11:37:00 -07:00