zulip

History

Alex Vandiver 351bdfaf78 preview: Use cache only as a non-durable cache, not an IPC. The `get_link_embed_data` / `link_embed_data_from_cache` pair as introduced in `c93f1d4eda` uses the cache as a temporary store inside of the `embed_links` worker; this means that it must be durable storage, or the worker will stall and re-fetch the same links to preview them. Switch to plumbing through the fetched URL embed data as an parameter to the Markdown evaluation which uses them, rather than using the cache as an intermediary. This frees up the cache to be merely a non-durable cache. As a side-effect, this removes get_cache_with_key, and link_embed_data_from_cache which was its only callsite.	2022-04-15 14:48:12 -07:00
..
__init__.py	…
queue_processors.py	preview: Use cache only as a non-durable cache, not an IPC.	2022-04-15 14:48:12 -07:00

Alex Vandiver 351bdfaf78 preview: Use cache only as a non-durable cache, not an IPC.

The `get_link_embed_data` / `link_embed_data_from_cache` pair as
introduced in c93f1d4eda uses the cache
as a temporary store inside of the `embed_links` worker; this means
that it must be durable storage, or the worker will stall and re-fetch
the same links to preview them.

Switch to plumbing through the fetched URL embed data as an parameter
to the Markdown evaluation which uses them, rather than using the
cache as an intermediary.  This frees up the cache to be merely a
non-durable cache.

As a side-effect, this removes get_cache_with_key, and
link_embed_data_from_cache which was its only callsite.

2022-04-15 14:48:12 -07:00

__init__.py

…

queue_processors.py preview: Use cache only as a non-durable cache, not an IPC. 2022-04-15 14:48:12 -07:00