zulip/analytics
Anders Kaseorg 6988622fe8 ruff: Enable B023 Function definition does not bind loop variable.
Python’s loop scoping is misdesigned, resulting in a very common
gotcha for functions that close over loop variables [1].  The general
problem is so bad that even the Go developers plan to break
compatibility in order to fix the same design mistake in their
language [2].

Enable the Ruff rule function-uses-loop-variable (B023) [3], which
conservatively prohibits functions from binding loop variables at all.

[1] https://docs.python-guide.org/writing/gotchas/#late-binding-closures
[2] https://go.dev/s/loopvar-design
[3] https://beta.ruff.rs/docs/rules/function-uses-loop-variable/

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-09-11 18:03:45 -07:00
..
lib models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
management mypy: Upgrade mypy from 1.4.1 to 1.5.1. 2023-09-07 17:51:42 -07:00
migrations models: Convert deprecated index_together option to indexes. 2023-07-12 07:12:43 -07:00
tests mypy: Upgrade mypy from 1.4.1 to 1.5.1. 2023-09-07 17:51:42 -07:00
views ruff: Enable B023 Function definition does not bind loop variable. 2023-09-11 18:03:45 -07:00
__init__.py
models.py models: Convert deprecated index_together option to indexes. 2023-07-12 07:12:43 -07:00
urls.py analytics: Use user IDs to get user activity summaries. 2021-10-13 15:30:27 -07:00