zulip/zerver/lib/markdown
m-e-l-u-h-a-n 830c4acedc markdown: Fix invalid mention bug for stream and stream topic mention.
Modifies `StreamPattern` and `StreamTopicPattern` to inherit
from InlineProcessor instead of Pattern. This change is done
because Pattern stopped checking for matching patterns as soon
as it found a match which was not a valid stream. Due to this
all the subsequent mention failed, even if they were valid.
This bug was only present in backend renderring due to
markdown.inlinepatterns.Pattern.

Due to above changes verbose_compile is no longer used for
precompiling STREAM_LINK_REGEX, STREAM_TOPIC_LINK_REGEX as
adds ^(.*?) and (.*?)$ which cause extra overhead of matching
pattern which is not required. With new InlineProcessor these
extra patterns at beggining and end are not required.
So, StreamPattern and StreamTopicPattern now define their own
__init__ method for precompiling the regex.

Fixes #17535.

These changes were tested locally in dev server and by adding
some new markdown tests to test these.
2021-03-23 01:28:30 -07:00
..
__init__.py markdown: Fix invalid mention bug for stream and stream topic mention. 2021-03-23 01:28:30 -07:00
api_arguments_table_generator.py api docs: Expand checking for deprecated fields. 2021-02-16 15:34:52 -08:00
api_return_values_table_generator.py api docs: Sort response keys in /get-events. 2021-02-26 15:01:37 -08:00
fenced_code.py python: Normalize quotes with Black. 2021-02-12 13:11:19 -08:00
help_emoticon_translations_table.py mypy: Correct typing.re imports to typing. 2021-03-17 18:41:46 -07:00
help_relative_links.py mypy: Correct typing.re imports to typing. 2021-03-17 18:41:46 -07:00
help_settings_links.py mypy: Correct typing.re imports to typing. 2021-03-17 18:41:46 -07:00
include.py python: Normalize quotes with Black. 2021-02-12 13:11:19 -08:00
nested_code_blocks.py python: Normalize quotes with Black. 2021-02-12 13:11:19 -08:00
tabbed_sections.py python: Normalize quotes with Black. 2021-02-12 13:11:19 -08:00
testing_mocks.py python: Reformat with Black, except quotes. 2021-02-12 13:11:19 -08:00