mirror of https://github.com/zulip/zulip.git
fd0b013bcd
This commit checks for null values for keys within "attachment" in
the Slack integration's incoming payloads. These keys were expected
to exist optionally previously, and the existence of null values for
these wasn't anticipated. Due to an issue report for such null
values in the payload, their handling is updated appropriately.
The checks for these values are truthiness checks since the strategy
for these values being null or falsy ("", 0) is the same; we don't
process that key-value pair. This is consistent with how Slack handles
this scenario.
For the case where all the attachment fields have null values, Slack
displays this as an empty block with no content, and therefore our
strategy for this is a no-op.
Tests updated.
|
||
|---|---|---|
| .. | ||
| actions.json | ||
| attachment.json | ||
| attachment_blocks.json | ||
| attachment_fields.json | ||
| attachment_pieces.json | ||
| attachment_pieces_all_null.json | ||
| attachment_pieces_footer_null.json | ||
| attachment_pieces_image_url_null.json | ||
| attachment_pieces_pretext_null.json | ||
| attachment_pieces_text_null.json | ||
| attachment_pieces_title_link_null.json | ||
| attachment_pieces_title_null.json | ||
| attachment_pieces_ts_null.json | ||
| blocks.json | ||
| complicated.json | ||
| null_text.json | ||
| text.json | ||
| urlencoded_text.txt | ||