zulip/frontend_tests
Steve Howell 5e8279c2fb refactor: Extract settings_config.
This moves some code from settings_display.js
into the new module settings_config.js.

Extracting this module breaks some dependencies
on settings_display.js (which has some annoying
transitive dependencies, including jQuery).

In particular this isolates stream_data from
from settings_display.js.

Two of the three structures that we moved here
weren't even directly used by settings_display.js,
since we do a lot of rendering in the modules
admin.js and setting.js.

We make get_all_display_settings() a function
to avoid a require-time dependency on page_params.

Breaking the dependencies simplifies a few
node tests.

Most of the node test complexity came from the
following commit in March 2019:

5a130097bf

The commit itself seems harmless enough, but
dependencies can have a somewhat "viral" nature,
where making stream_data depend on settings_display
caused us to modify four different node tests.
2020-02-21 12:06:31 -08:00
..
casper_lib casper: Use data-stream-id to find checkboxes. 2020-01-28 14:49:57 -08:00
casper_tests dict, lazy_set: Replace num_items method with size property. 2020-02-04 12:22:03 -08:00
node_tests refactor: Extract settings_config. 2020-02-21 12:06:31 -08:00
zjsunit tests: Compile Handlebars templates with source maps. 2020-02-18 07:38:46 -05:00
.eslintrc.json lint: Check eslint indentation for casper tests. 2018-05-06 19:35:18 -07:00
run-casper run-casper: Flush stdout before calling subprocess. 2020-02-04 16:17:37 -08:00