mirror of https://github.com/zulip/zulip.git
5de115a964
We had our input elements for stream settings inside li tags and their alignment was managed using CSS. We move away from this HTML structure to have inputs and labels inside divs for two reasons. First is that if we want to later refactor the HTML to have some different design, then having them inside `ul` requires complex changes to CSS and eventually we would have to move away from using `li`s for the part that is changed to have a different design. Second `li`s are generally not used to organize input elements. Above is an explanation of why this change is a preparatory commit for shifting to have a tabbed design in the stream edit page. So following changes are done to have a more consistent HTML structure in stream types modal: * Added modal-body and removed the non-standard usage of the unordered list for settings header and inputs. * Updated relevant CSS rules to have the same design during refactor. Co-authored-by: Pragati Agrawal <pragati22066@gmail.com> |
||
---|---|---|
.. | ||
assets | ||
audio | ||
generated | ||
html | ||
images | ||
js | ||
shared | ||
styles | ||
templates | ||
third | ||
.gitignore |