mirror of https://github.com/zulip/zulip.git
b7fa41601d
Amazon SES has a limit on the size of address fields, and rejects emails with too-long "From" combinations of name and address. This limit is set to 320 bytes and comes from an RFC limitation on the size of addresses. This RFC standard states that an email address should not be composed of a local part (before the '@') longer than 64 bytes and a domain part (after the '@') longer than 255 bytes. It is possible that Amazon SES misinterprets this limitation as it checks the length of the combination of the name and the email address of the sender. To ensure that this problem is not encountered in the send_email module of Zulip the length of this combination is now checked against this limit and the from_name field is removed to only keep the from_address field when it is necessary in order to stay below 320 bytes. If the from_address field alone is longer than 320 bytes the sending process will raise an SMTPDataError exception. Tests for this new check are added to the backend test suite in order to test if build_email correctly outputs an email with filled from_name and from_address fields when the total length is lower than 320 bytes and that it correctly throws the from_name field away when necessary. Fixes: #17558. |
||
|---|---|---|
| .. | ||
| data_import | ||
| lib | ||
| management | ||
| migrations | ||
| openapi | ||
| templatetags | ||
| tests | ||
| tornado | ||
| views | ||
| webhooks | ||
| worker | ||
| __init__.py | ||
| apps.py | ||
| context_processors.py | ||
| decorator.py | ||
| filters.py | ||
| forms.py | ||
| logging_handlers.py | ||
| middleware.py | ||
| models.py | ||
| signals.py | ||