Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates
History
Steve Howell 8530ed0b5e org settings: Make button-clicking code more clear. 
On the "Organization settings" page, we had two Save buttons
for admins that had identical markup.  This was confusing for
people reading the code.  Now the two buttons have different
markup and individual, targeted click handlers (albeit still
calling the same function to do most of the work).

The context of this fix is that I was debugging a
Casper flake where our Casper tests were essentially clicking
on the same button twice.  Depending on the timing,
the second button click could cause a "No changes saved!"
behavior that confused the Casper test.  It is unclear whether
Casper was clicking both buttons here (in which case this fix
is necessary) or the same button twice (in which case this fix
just removes a nasty red herring for debugging).

The code still has the flaw that both buttons basically submit
the same data to the server, despite the appearance on the page
that there are two forms.  The best fix for that is probably
just to move the Language/Notifications stuff to another
panel.  I wanted to avoid touching this code altogether, but
the minor modifications here were necessary to improve the
Capser testing situation.
 		2018-01-16 13:25:19 -05:00
..
settings org settings: Make button-clicking code more clear. 2018-01-16 13:25:19 -05:00
.gitignore
…
actions_popover_content.handlebars local echo: Don't show collapse/uncollapse items. 2017-12-26 09:01:21 -05:00
admin_default_streams_list.handlebars components: Make button component styles sensible. 2017-06-08 17:09:31 -07:00
admin_emoji_list.handlebars settings: Fix missing target=_blank on realm emoji images. 2017-11-25 09:43:01 -08:00
admin_filter_list.handlebars components: Make button component styles sensible. 2017-06-08 17:09:31 -07:00
admin_invites_list.handlebars invites: Differentiate users invited as admin by showing bolt icon. 2017-12-13 15:12:21 -06:00
admin_streams_list.handlebars frontend: Add aria-label attributes to textareas/input fields. 2017-07-14 14:45:10 -07:00
admin_tab.handlebars org settings: Add framework for User groups page. 2018-01-06 11:50:52 -05:00
admin_user_group_list.handlebars org settings: Improve design of User groups page. 2018-01-06 11:50:52 -05:00
admin_user_list.handlebars bots: Add 'Bot type' column to bots list in organization settings. 2017-06-20 23:04:46 -04:00
alert_word_settings_item.handlebars alert_words_ui.js: Move the error message to the top. 2017-06-09 15:23:53 -07:00
announce_stream_docs.handlebars create stream: Show notification stream name for announcement. 2018-01-04 16:37:09 -05:00
bankruptcy_modal.handlebars Clean bankruptcy_modal handlebar to use 4 space indents. 2017-02-17 03:16:46 +05:30
bookend.handlebars message view: Decode HTML in Stream subscription messages. 2017-10-11 09:59:48 -07:00
bot_avatar_row.handlebars Use realistic filepaths in zuliprc docs and hints. 2017-11-21 07:32:24 -08:00
bot_owner_select.handlebars Clean bot_owner_select.handlebars to use 4 space indents. 2017-03-09 01:17:23 -08:00
compose-invite-users.handlebars unicode: Replace "×" with HTML and HEX entities. 2017-08-22 16:31:53 -07:00
compose_all_everyone.handlebars Improve @all warnings user interface significantly. 2016-12-21 11:40:47 -08:00
compose_announce.handlebars compose: Warn users when posting to the #announce stream. 2017-12-20 07:36:50 -05:00
compose_notification.handlebars unicode: Replace "×" with HTML and HEX entities. 2017-08-22 16:31:53 -07:00
compose_private_stream_alert.handlebars composebox: Warn when linked to private streams. 2017-11-27 07:41:59 -08:00
default_language_modal.handlebars unicode: Replace "×" with HTML and HEX entities. 2017-08-22 16:31:53 -07:00
draft.handlebars frontend: Add hotkey information to title/inline text. 2017-08-23 17:12:09 -07:00
draft_table_body.handlebars dark-mode: Change drafts container to be dark. 2017-11-29 16:44:43 -08:00
email_address_hint.handlebars Clean email_address_hint.handlebars to use 4 space indents. 2017-03-10 11:07:49 -08:00
embedded_bot_config_item.handlebars embedded bots: Add config data UI. 2018-01-09 11:50:54 -05:00
emoji_popover.handlebars emoji_picker: Add emoji showcase. 2017-09-29 21:09:00 +00:00
emoji_popover_content.handlebars emoji_picker: Move the category tabs to just below the emoji filter. 2017-09-29 20:22:09 +00:00
emoji_popover_emoji.handlebars emoji_picker: Don't display title text for emojis in emoji picker. 2017-09-29 21:10:07 +00:00
emoji_popover_search_results.handlebars emoji_picker: Change emoji picker to be category based. 2017-08-14 12:52:35 -07:00
emoji_showcase.handlebars emoji_picker: Add emoji showcase. 2017-09-29 21:09:00 +00:00
group_pms.handlebars Clean group_pms handlebar to use 4 space indents. 2017-02-17 03:16:46 +05:30
hotspot_overlay.handlebars hotspots: Add friendly whale illustration to popover. 2017-08-05 18:32:37 -07:00
invite_subscription.handlebars invitations: Make stream labels click targets. 2017-12-07 14:37:23 -08:00
loader.handlebars Remove the old spinner, replace with new one. 2017-01-06 10:37:54 -08:00
message_edit_form.handlebars message_edit_form.handlebars: Upgrade font-awesome icon style. 2017-06-08 14:07:27 -07:00
message_edit_history.handlebars message-editing: Show date lines between edits from different days. 2017-06-06 11:04:30 -07:00
message_group.handlebars date-separator: Make date rows unselectable. 2017-10-19 17:49:57 -07:00
message_reaction.handlebars reactions.js: Migrate webapp to use the new reactions API. 2017-11-20 15:27:20 -08:00
message_reactions.handlebars emoji_picker: Correctly restore the title attribute of base element. 2017-09-16 08:17:41 -07:00
more_topics.handlebars left-sidebar: Remove topics help code. 2017-11-15 11:01:33 -08:00
muted_topic_ui_row.handlebars Clean muted_topic_ui_row.handlebars to use 4 space indents. 2017-03-09 01:17:25 -08:00
new_stream_users.handlebars create stream: Show current user on top of "People to add" list 2017-12-13 14:16:07 -06:00
notification.handlebars notifications: Improve HTML/CSS for desktop notifications. 2017-01-02 16:42:04 -08:00
propagate_notification_change.handlebars settings: Reword notifications settings strings. 2017-12-11 09:17:31 -08:00
recipient_row.handlebars Make recipient bar styling more compact and clean. 2017-09-06 18:49:54 -07:00
settings_tab.handlebars account-settings: Removed 'Updated settings' message from admin. 2017-03-10 10:53:06 -08:00
sidebar_private_message_list.handlebars Clean sidebar_private_message_list handlebar to use 4 space indents. 2017-02-16 14:45:08 -08:00
single_message.handlebars Simplify/unify starring messages from the frontend. 2017-12-26 09:01:21 -05:00
stream_member_list_entry.handlebars streams: Update button styles to new styles. 2017-08-23 12:29:32 -07:00
stream_privacy.handlebars left-sidebar: Restyle to have new look. 2017-04-25 17:47:36 -07:00
stream_sidebar_actions.handlebars stream_sidebar: Clean up use of ambiguously named data-id. 2017-08-16 18:02:29 -07:00
stream_sidebar_row.handlebars stream_sidebar_row: Rename data-name to data-stream-name. 2017-08-16 18:03:44 -07:00
subscription.handlebars stream_data: Linkify URL in stream description. 2017-03-20 22:25:03 -07:00
subscription_creation_form.handlebars create stream: Show notification stream name for announcement. 2018-01-04 16:37:09 -05:00
subscription_invites_warning_modal.handlebars unicode: Replace "×" with HTML and HEX entities. 2017-08-22 16:31:53 -07:00
subscription_setting_icon.handlebars
…
subscription_settings.handlebars stream membership: Display add-subscribers option only if user can add. 2018-01-04 16:52:54 -05:00
subscription_stream_privacy_modal.handlebars unicode: Replace "×" with HTML and HEX entities. 2017-08-22 16:31:53 -07:00
subscription_table_body.handlebars settings: Use `.modal-bg` class to control background color. 2017-11-17 08:44:04 -08:00
subscription_type.handlebars
…
tab_bar.handlebars left sidebar: Change Home to All messages. 2017-11-28 15:42:58 -08:00
topic_edit_form.handlebars Clean topic_edit_form handlebar to use 4 space indents. 2017-03-09 01:17:23 -08:00
topic_list_item.handlebars stream_list: Use data-topic-name for topic names. 2017-08-16 18:03:44 -07:00
topic_sidebar_actions.handlebars topic_sidebar_actions.handlebars: Upgrade font-awesome icon style. 2017-06-08 14:07:28 -07:00
typeahead_list_item.handlebars emoji: Migrate bugdown emoji to use sprite sheets. 2017-09-29 11:14:34 -07:00
typing_notification.handlebars Add typing notifications front end. 2017-03-17 20:45:07 -07:00
typing_notifications.handlebars Add typing notifications front end. 2017-03-17 20:45:07 -07:00
uploaded_files_list.handlebars user settings: fix uploaded files UI 2017-12-18 10:12:33 -05:00
user-groups-admin.handlebars org settings: Add User groups content and design. 2018-01-06 11:50:52 -05:00
user_info_popover.handlebars Remove arrow from message info popover by providing template. 2017-03-22 16:04:38 -07:00
user_info_popover_content.handlebars user profiles: add tooltip for too long email. 2017-12-13 14:20:18 -06:00
user_info_popover_title.handlebars Make user_popover use user_info_popover template. 2017-03-22 16:04:38 -07:00
user_presence_row.handlebars Clean user_presence_row.handlebars to use 4 space indents. 2017-03-10 11:07:49 -08:00
user_presence_rows.handlebars
…