Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zilencer
History
Mateusz Mandera 90636d5e81 events: Fix bug in get_recent_conversations_recipient_id. 
user_profile.id was confused for user_profile.recipient_id. These bugs
are particularly sneaky as they can go undetected by tests due to ids of
objects accidentally coinciding. We add a mitigation for this class of
mistakes by shifting the Recipient.id sequence in test db.

This was introduced in dda3ff41e1.
On the rare occasion where user_profile.id would coincide with
recipient_id passed to the function, we would return the wrong value.
That is, instead of correctly returning recipient_id, we would return
sender.recipient_id - recipient id of the sender of the message, thus
possibly returning user_profile.recipient_id (if user_profile is the
sender) - exactly the situation the function wanted to avoid
with the `if recipient_id == my_recipient_id:` if. Ultimately resulting
in incorrect/malformed data in
state['raw_recent_private_conversations'].
 		2021-02-09 17:45:34 -08:00
..
lib billing: Move zilencer/lib/stripe to corporate. 2018-10-01 15:43:44 -07:00
management events: Fix bug in get_recent_conversations_recipient_id. 2021-02-09 17:45:34 -08:00
migrations python: Modernize legacy Python 2 syntax with pyupgrade. 2020-04-09 16:43:22 -07:00
README.md docs: Fix more capitalization issues. 2020-10-23 11:46:55 -07:00
__init__.py
…
forms.py python: Sort imports with isort. 2020-06-11 16:45:32 -07:00
models.py python: Sort imports with isort. 2020-06-11 16:45:32 -07:00
urls.py rest: Add rest_path shortcut for path with rest_dispatch. 2020-09-22 10:51:00 -07:00
views.py push_notifications: Simplify `if device exists` checks. 2020-08-31 17:31:41 -07:00

README.md

ZILENCER -- The Zulip license manager

This app is the place for storing state about various deployments of Zulip that exist in the world.