mirror of https://github.com/zulip/zulip.git
026ff48020
This was a user-reported bug and a very subtle and painful one to track down. Previously, if payload['push']['changes'][i]['closed'] was True, we assumed that a branch was removed. Looking at whether `closed` was set to True or not was our way to tell whether a push removed a branch or not. However, this is wrong! `closed` being set to True can also mean that the pull request associated with the branch was approved but the branch itself was not deleted. According to the BitBucket docs, the correct way to see if a branch is deleted is to check if `new` is null. This bug was leading to KeyErrors about not being able to find the `commits` key, which shouldn't happen anymore! |
||
|---|---|---|
| .. | ||
| fixtures | ||
| __init__.py | ||
| doc.md | ||
| tests.py | ||
| view.py | ||