mirror of https://github.com/zulip/zulip.git
4e2a282a1b
As discussed in the new comments, we had a bug where the system-initiated animated scroll that happens when the compose box opens as a result of narrowing would race with the internal rerendering that occurs when the message_fetch request asking the server for additional data returns. The correct fix for this is just to open the compose box, if we're going to do so, before setting the user's scroll position in the narrowing/rendering process. This ends up being a UI improvement (in that the compose box is available for typing a bit earlier) as well as avoiding both the risk of this race as well as the bad UX of adjusting the user's scroll position multiple times as part of entering the view. This does not address an as-yet-unknown bug wherein the animated scroll that occurs when opening the compose box, when racing with a background rerender, results in a bogus ending scroll position, though it's easy to see how that might occur given that rerendering does clear the DOM briefly. |
||
|---|---|---|
| .. | ||
| e2e-tests | ||
| generated | ||
| html | ||
| images | ||
| shared | ||
| src | ||
| styles | ||
| templates | ||
| tests | ||
| third | ||
| .browserslistrc | ||
| .gitignore | ||
| babel.config.js | ||
| debug-require-webpack-plugin.ts | ||
| debug-require.js | ||
| postcss.config.js | ||
| webpack.assets.json | ||
| webpack.config.ts | ||
| webpack.dev-assets.json | ||