mirror of https://github.com/zulip/zulip.git
4df971c3c2
Along with this, we refactored settings_org.populate_auth_methods to use HTML function after rendering all auth methods rows rather than appending each row individually, which actually is a good practice. Also in this commit, to compare `current_val` and `changed_val` in `check_property_changed` function of the property `realm_authentication_methods`, which are objects, and we found here https://stackoverflow.com/a/1144249 that there is no easy way to do so. So I followed this approach, ```js JSON.stringify(obj1) === JSON.stringify(obj2) ``` but before converting them to string we want the same order of keys, so we used `sort_object_by_key` to sort `current_val` by keys and `get_auth_method_table_data` always return `changed_val` having keys sorted. Since these refactor were closely related we kept them as a single commit here. Fixes: #11954. |
||
|---|---|---|
| .. | ||
| 00-realm-creation.js | ||
| 01-login.js | ||
| 02-site.js | ||
| 03-narrow.js | ||
| 04-compose.js | ||
| 05-subscriptions.js | ||
| 06-settings.js | ||
| 07-stars.js | ||
| 08-edit.js | ||
| 09-navigation.js | ||
| 10-admin.js | ||
| 11-mention.js | ||
| 12-toggle-message-editing.js | ||
| 13-user-deactivation.js | ||
| 14-drafts.js | ||
| 15-delete-message.js | ||
| 16-copy-and-paste.js | ||