mirror of https://github.com/zulip/zulip.git
48f80fcb0a
The name used to be included in the id_token, but this seems to have been changed by Apple and now it's sent in the `user` request param. https://github.com/python-social-auth/social-core/pull/483 is the upstream PR for this - but upstream is currently unmaintained, so we have to monkey patch. We also alter the tests to reflect this situation. Tests no longer put the name in the id_token, but rather in the `user` request param in the browser flow, just like it happens in reality. An adaptation has to be made in the native flow - since the name won't be included by Apple in the id_token anymore, the app, when POSTing to the /complete/apple/ endpoint, can (and should for better user experience) add the `user` param formatted as json of {"email": "hamlet@zulip.com", "name": {"firstName": "Full", "lastName": "Name"}} dict. This is also reflected by the change in the native flow tests. |
||
---|---|---|
.. | ||
jinja2 | ||
__init__.py | ||
backends.py | ||
computed_settings.py | ||
config.py | ||
configured_settings.py | ||
default_settings.py | ||
dev_settings.py | ||
dev_urls.py | ||
email_backends.py | ||
legacy_urls.py | ||
prod_settings_template.py | ||
sentry.py | ||
settings.py | ||
terms.md.template | ||
test_extra_settings.py | ||
test_settings.py | ||
urls.py | ||
wsgi.py |