zulip/web
Sayam Samal 3034ad2931 compose: Fix topics required banner closing on enter to send.
We were updating the compose banners on every `keyup` event on the
topic input. Since, `keyup` also gets triggered for the modifier and
non-printing keys such as "Enter", this lead to banner for topic
required being closed via the `check_posting_policy_for_compose_box`
when pressing "Enter" to send a message with no topic.

This bug was probably introduced in 5c993f0, which moved additional
logic into `update_on_recipient_change`.

To solve this issue, we use the `input` event instead of the `keyup`
event to update the compose banners only when the value inside the
input element changes.

This change also prevents the the compose banner from being closed
when we only press modifier keys - such as Shift.

(cherry picked from commit 44f313633f)
2024-03-19 13:47:16 -04:00
..
e2e-tests puppeteer: Disable flaky administrative UI test. 2024-02-16 15:24:39 -08:00
generated
html
images compose: Update icons for formatting buttons. 2023-12-01 13:51:39 -08:00
shared gear_menu_popover: Update the rocket icon used for plan and pricing. 2023-12-13 07:59:13 -08:00
src compose: Fix topics required banner closing on enter to send. 2024-03-19 13:47:16 -04:00
styles css: Apply fa-chevron-down CSS to zulip-icon-chevron-down. 2024-03-07 15:01:15 -08:00
templates personal_menu: Fix clicking on `Set status` not working. 2024-03-01 09:26:25 -08:00
tests message_fetch: Add small backfill delay. 2024-02-16 12:28:16 -08:00
third typeahead: Remove insecure default highlighter implementation. 2024-01-24 16:46:02 -08:00
.browserslistrc
.gitignore
babel.config.js dependencies: Upgrade JavaScript dependencies. 2023-12-07 14:29:32 -08:00
debug-require-webpack-plugin.ts eslint: Forbid unchecked casts in TypeScript. 2023-10-26 09:54:30 -07:00
debug-require.js
postcss.config.js
webpack.assets.json portico: Add self-hosted plans comparison table. 2023-12-15 11:03:42 -08:00
webpack.config.ts webpack_public_path: Replace with webpack 5 publicPath: "auto" setting. 2023-10-16 10:36:27 -07:00
webpack.dev-assets.json development: Update modal in emails page to use micromodal. 2023-10-05 09:28:27 -07:00