zulip

History

Tim Abbott e603237010 email: Convert accounts code to use delivery_email. A key part of this is the new helper, get_user_by_delivery_email. Its verbose name is important for clarity; it should help avoid blind copy-pasting of get_user (which we'll also want to rename). Unfortunately, it requires detailed understanding of the context to figure out which one to use; each is used in about half of call sites. Another important note is that this PR doesn't migrate get_user calls in the tests except where not doing so would cause the tests to fail. This probably deserves a follow-up refactor to avoid bugs here.	2018-12-06 16:21:38 -08:00
..
commands	email: Convert accounts code to use delivery_email.	2018-12-06 16:21:38 -08:00
__init__.py	…

Tim Abbott e603237010 email: Convert accounts code to use delivery_email.

A key part of this is the new helper, get_user_by_delivery_email.  Its
verbose name is important for clarity; it should help avoid blind
copy-pasting of get_user (which we'll also want to rename).
Unfortunately, it requires detailed understanding of the context to
figure out which one to use; each is used in about half of call sites.

Another important note is that this PR doesn't migrate get_user calls
in the tests except where not doing so would cause the tests to fail.
This probably deserves a follow-up refactor to avoid bugs here.

2018-12-06 16:21:38 -08:00

commands

email: Convert accounts code to use delivery_email.

2018-12-06 16:21:38 -08:00

__init__.py

…