mirror of https://github.com/zulip/zulip.git
268f858f39
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
|
||
|---|---|---|
| .. | ||
| ci | ||
| documentation_crawler | ||
| droplets | ||
| i18n | ||
| lib | ||
| linter_lib | ||
| node_lib | ||
| oneclickapps | ||
| setup | ||
| test-install | ||
| tests | ||
| wsl | ||
| zulip-export | ||
| README.md | ||
| __init__.py | ||
| build-docs | ||
| build-release-tarball | ||
| cache-zulip-git-version | ||
| check-capitalization | ||
| check-frontend-i18n | ||
| check-issue-labels | ||
| check-openapi | ||
| check-provision | ||
| check-schemas | ||
| check-templates | ||
| check-thirdparty | ||
| clean-branches | ||
| commit-message-lint | ||
| commit-msg | ||
| conf.ini-template | ||
| coveragerc | ||
| deploy-branch | ||
| diagnose | ||
| documentation.vnufilter | ||
| duplicate_commits.json | ||
| fetch-contributor-data | ||
| fetch-pull-request | ||
| fetch-rebase-pull-request | ||
| find-unused-css | ||
| generate-integration-docs-screenshot | ||
| lint | ||
| message-screenshot.js | ||
| pre-commit | ||
| provision | ||
| push-to-pull-request | ||
| rebuild-dev-database | ||
| rebuild-test-database | ||
| release | ||
| release-tarball-exclude.txt | ||
| renumber-migrations | ||
| reset-to-pull-request | ||
| review | ||
| run-codespell | ||
| run-dev | ||
| run-mypy | ||
| run-tsc | ||
| semgrep.yml | ||
| setup-git-repo | ||
| show-profile-results | ||
| stop-run-dev | ||
| tail-ses | ||
| test-all | ||
| test-api | ||
| test-backend | ||
| test-documentation | ||
| test-help-documentation | ||
| test-js-with-node | ||
| test-js-with-puppeteer | ||
| test-locked-requirements | ||
| test-migrations | ||
| test-queue-worker-reload | ||
| test-run-dev | ||
| test-tools | ||
| total-contributions | ||
| update-locked-requirements | ||
| update-prod-static | ||
| update-zuliprc-api-field | ||
| upload-release | ||
| webpack | ||
| zanitizer | ||
| zanitizer_config.pm.sample | ||
README.md
This directory contains scripts that are used in building, managing,
testing, and other forms of work in a Zulip development environment.
Note that tools that are also useful in production belong in
scripts/ or should be Django management commands.
For more details, see https://zulip.readthedocs.io/en/latest/overview/directory-structure.html.