Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates
History
Steve Howell 1e8dff6ca9 edit subscribers: Lift form tag to parent template. 
For our Subscribers tab we want to enclose our
add-subscriber widget in a form for now, and we
continue to do so, but now we have the form tag
getting created in the parent template, not the
child.

Here is why:

    We want to re-use our add-subscriber widget in an
    upcoming commit for when you create streams.

    In our create-stream UI, there is already an outer
    <form>...</form> section of the HTML for the entire
    process of creating a stream.

    HTML does not yet you nest forms, and even though
    browsers just silently ignore an inner form, we won't
    want to create semantically incorrect HTML.

    Therefore, we want the child template not to have
    the form tags around them.

It's possible that we don't really even want to
enclose the input-pill widget and Add button inside
a form for the Subscribers tab, but tweaking that
for now is too risky. (We don't really take advantage
of the form tag in any meaningful way, since we
don't directly submit form data to the server, and
we can't use a single submit handler for the Enter
key and Add button due to some magic in our input
pills.)
 		2022-02-15 17:15:02 -08:00
..
confirm_dialog settings: Rephrase text in user deactivation modal. 2022-01-04 14:42:19 -08:00
navbar_alerts navbar_alerts: Add alerts for demo org deadlines. 2021-09-10 16:31:54 -07:00
settings js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
stream_settings edit subscribers: Lift form tag to parent template. 2022-02-15 17:15:02 -08:00
widgets todo_widget: Tag "Task list" heading for translation. 2022-01-18 14:15:34 -08:00
about_zulip.hbs about_zulip: Mark strings for translation. 2021-06-18 18:13:00 -07:00
actions_popover_content.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
all_messages_sidebar_actions.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
announce_stream_docs.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
blueslip_stacktrace.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
bookend.hbs message_list_view: Mark trailing bookend using a new variable. 2022-01-31 16:42:46 -08:00
buddy_list_tooltip_content.hbs templates: Mark all void tags as self-closing. 2021-04-21 09:49:34 -07:00
change_email_modal.hbs change_email: Migrate modal to dialog_widget. 2022-01-21 16:12:34 -08:00
compose.hbs compose: Remove keyboard focus from stream color block. 2022-02-07 22:23:13 -08:00
compose_all_everyone.hbs templates: Fix <br> → <br /> to be parseable by FormatJS. 2021-04-20 14:39:53 -07:00
compose_announce.hbs templates: Fix <br> → <br /> to be parseable by FormatJS. 2021-04-20 14:39:53 -07:00
compose_control_buttons.hbs compose_control_buttons: Move GIF button out of the popover. 2022-02-13 19:13:29 -08:00
compose_control_buttons_in_popover.hbs compose_control_buttons: Move GIF button out of the popover. 2022-02-13 19:13:29 -08:00
compose_control_buttons_popover.hbs compose: Move overflowing buttons to a popover. 2021-12-02 15:11:15 -08:00
compose_invite_users.hbs compose: Clarify subscribe-other-user button label. 2021-09-16 11:09:53 -07:00
compose_not_subscribed.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
compose_notification.hbs notification: Fix "narrow to..." link present above composebox. 2021-08-07 09:51:04 -07:00
compose_private_stream_alert.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
compose_resolved_topic.hbs compose: Show warning while composing to a resolved topic. 2022-02-01 17:50:17 -08:00
compose_select_enter_behaviour_popover.hbs compose: Fix Enter to send switch internationalization. 2022-01-07 14:38:10 -08:00
copy_code_button.hbs copy_code_button: Attach tooltip to body to avoid overlap with parent. 2021-10-01 10:04:17 -07:00
copy_invite_link.hbs lint: Fix badly quoted strings tagged for translation. 2021-05-09 20:16:28 -07:00
copy_message_button.hbs lint: Fix badly quoted strings tagged for translation. 2021-05-09 20:16:28 -07:00
copy_to_clipboard_svg.hbs
…
default_language_modal.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
dialog_change_password.hbs change_password: Migrate modal to dialog_widget. 2021-11-23 15:41:54 -08:00
dialog_widget.hbs dialog_widget: Use simplebar for the modals using dialog_widget. 2021-12-01 12:13:06 -08:00
draft.hbs drafts: Add hotkey hint to restore draft. 2021-11-10 12:54:53 -08:00
draft_table_body.hbs Revert "drafts: Use simplebar." 2022-02-09 14:15:27 -08:00
drafts_sidebar_action.hbs popovers: Add sidebar menu to delete all drafts. 2021-11-22 17:01:47 -08:00
edit_content_button.hbs tooltips: Use TippyJS for all message_control_button tooltips. 2021-05-13 12:56:38 -07:00
edited_notice.hbs message_feed: Remove the parenthesis around edited notices. 2022-02-10 13:52:24 -08:00
embedded_bot_config_item.hbs
…
emoji_popover.hbs
…
emoji_popover_content.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
emoji_popover_emoji.hbs emoji_picker: Update architecture to support status emoji. 2021-07-23 13:03:13 -07:00
emoji_popover_search_results.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
emoji_showcase.hbs
…
empty_feed_notice.hbs narrow_banner: Move empty narrow messages to handlebar templates. 2021-12-07 13:38:48 -08:00
favicon.svg.hbs dependencies: Upgrade Source Sans Pro font to Source Sans 3. 2021-02-23 14:55:33 -08:00
feedback_container.hbs
…
filter_topics.hbs left-sidebar: Add topic filter input in zoomed topic view. 2021-06-08 15:09:26 -07:00
gear_menu.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
giphy_picker.hbs templates: Mark all void tags as self-closing. 2021-04-21 09:49:34 -07:00
giphy_picker_mobile.hbs giphy: Use GIPHY web SDK to allow inserting GIFs in compose box. 2021-04-05 15:04:49 -07:00
help_link_widget.hbs
…
hotspot_icon.hbs hotspots: Generate properly escaped HTML. 2021-02-05 09:26:47 -08:00
hotspot_overlay.hbs hotspots: Remove useless and malformed alt text. 2021-04-27 11:12:24 -07:00
input_pill.hbs templates: Fix indentation formatting of input_pull.hbs. 2022-02-11 13:58:02 -08:00
invitation_failed_error.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
invite_subscription.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
invite_user.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
keyboard_shortcuts.hbs user_settings: Add option to disable escape key navigation to default view. 2021-10-29 18:15:30 -07:00
left_sidebar.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
left_sidebar_stream_setting_popover.hbs left sidebar: Redirect users with no stream create permissions. 2022-02-11 11:02:09 -08:00
lightbox_overlay.hbs lightbox: Prevent undesired closing of lightbox during pan. 2022-02-04 14:58:36 -08:00
loader.hbs
…
login_to_access.hbs docs: Consistently hyphenate “web-public”. 2022-01-28 17:45:45 -08:00
markdown_help.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
markdown_time_tooltip.hbs markdown: Change timezone to time zone in <time> tooltip. 2021-07-08 10:10:11 -04:00
markdown_timestamp.hbs markdown: Add fa-clock icon before markdown timestamps. 2021-03-14 22:57:01 -07:00
me_message.hbs zulip-icon: Add `zulip-icon` as classPrefix for icon. 2021-04-29 09:02:25 -07:00
message_avatar.hbs message_body: Fix -3px alignment kludge using whitespace control. 2021-06-23 09:10:50 -07:00
message_body.hbs status_emoji: Show status emoji in message_body. 2022-02-11 13:02:56 -08:00
message_controls.hbs message view: Show failed message icon tooltips similar to other icons. 2021-07-18 11:33:32 -07:00
message_edit_form.hbs message_editing: Fix topic edit propagate option cut-off. 2022-02-09 14:06:49 -08:00
message_edit_history.hbs message_edit: Fix internationalization of edited notices. 2022-02-01 14:09:19 -08:00
message_feed_errors.hbs message_feed_errors: Don't show search public stream to spectators. 2022-01-31 17:12:03 -08:00
message_group.hbs message_list_view: Cleanup unused bookend code. 2022-01-31 16:50:54 -08:00
message_hidden_dialog.hbs message view: Allow revealing hidden message from muted sender. 2021-05-05 09:15:45 -07:00
message_history_modal.hbs message_edit_history: Migrate modal to dialog_widget. 2021-11-08 17:24:31 -08:00
message_reaction.hbs
…
message_reactions.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
message_view_header.hbs message_view_header: Hide subscriber count for spectators. 2021-11-03 16:02:53 -07:00
mobile_message_buttons_popover_content.hbs
…
more_topics.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
more_topics_spinner.hbs
…
move_topic_to_stream.hbs move_topic_modal: Use `dialog_error` to display error. 2021-12-02 14:02:27 -08:00
muted_topic_ui_row.hbs
…
muted_user_ui_row.hbs settings: Add UI page for managing muted users. 2021-04-21 10:17:44 -07:00
navbar.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
navbar_icon_and_title.hbs
…
new_stream_user.hbs streams: Hide fake emails in stream creation form. 2021-11-18 12:49:10 -08:00
no_arrow_popover.hbs
…
non_editable_user_group.hbs
…
playground_links_popover_content.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
pm_list_item.hbs status_emoji: Show status emoji in single PMs in the PM list. 2022-02-12 01:06:52 +05:30
recent_topic_row.hbs recent_topics: Hide mute and read buttons for spectators. 2022-02-10 11:37:38 -08:00
recent_topics_filters.hbs recent_topic: Add role and area properties according to MDN docs. 2021-03-16 14:54:22 -07:00
recent_topics_table.hbs templates: Mark all void tags as self-closing. 2021-04-21 09:49:34 -07:00
recipient_row.hbs docs: Consistently hyphenate “web-public”. 2022-01-28 17:45:45 -08:00
remind_me_popover_content.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
right_sidebar.hbs right_sidebar: Add realm description for spectators. 2022-02-04 16:00:59 -08:00
search_operators.hbs search_operators: Add info about `is:resolved` keyword. 2021-07-13 23:48:45 -07:00
set_status_overlay.hbs user_status: Migrate modal to dialog_widget. 2022-01-21 16:17:25 -08:00
settings_overlay.hbs edit_bot: Migrate modal to dialog_widget. 2021-11-08 17:34:42 -08:00
settings_tab.hbs settings: Create user_notification_settings.hbs template. 2021-08-20 07:50:51 -07:00
single_message.hbs
…
starred_messages_sidebar_actions.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
status_emoji.hbs status_emoji: Extract status emoji template. 2022-02-08 16:52:49 -08:00
status_emoji_selector.hbs status_emoji: Modify centering technique for .selected_emoji. 2022-02-08 16:52:49 -08:00
stream_privacy.hbs
…
stream_sidebar_actions.hbs popovers: Hide most irrelevant options for spectators. 2021-09-21 10:10:54 -07:00
stream_sidebar_row.hbs left_sidebar: Hide vdots for All messages and stream buttons. 2021-11-02 11:26:19 -07:00
stream_topic_widget.hbs templates: Escape some unescaped > and & characters. 2021-05-20 12:09:47 -07:00
topic_edit_form.hbs topic_edit_form: Restyle topic edit save button with logo colours. 2021-07-08 17:45:42 -07:00
topic_list_item.hbs left-sidebar: Add support for showing resolve-topic-prefix. 2021-07-05 18:02:40 -07:00
topic_muted.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
topic_sidebar_actions.hbs js: Add tabindex attribute for anchor tag to allow focus. 2022-02-14 15:23:46 -08:00
typeahead_list_item.hbs status_emoji: Show status emoji in compose_pm and mentions typeaheads. 2022-02-11 13:30:08 -08:00
typing_notification.hbs templates: Remove context argument from {{#tr}} block helper. 2021-04-13 18:59:46 -07:00
typing_notifications.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
user_group_info_popover.hbs
…
user_group_info_popover_content.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
user_group_list_item.hbs popovers: Add tabs for profile, groups and streams in user_info modal. 2021-06-11 07:56:32 -07:00
user_info_popover_content.hbs popovers: Add "Manage this user" option to user info popover. 2021-12-01 12:13:06 -08:00
user_info_popover_title.hbs
…
user_presence_row.hbs status_emoji: Extract status emoji template. 2022-02-08 16:52:49 -08:00
user_presence_rows.hbs templates: Always indent "each" blocks. 2021-12-06 14:58:29 -08:00
user_profile_modal.hbs user_profile: Fix unsubscribing other users from streams. 2022-01-21 15:45:11 -08:00
user_stream_list_item.hbs profile: Add tooltip to hint unsubscription flow for private stream. 2021-06-30 15:17:27 -07:00
view_code_in_playground.hbs view_code_in_playground: Use tippy for tooltip. 2021-04-07 17:38:40 -07:00