zulip/static/js
Sahil Batra 1da7086c35 settings: Fix save button being disabled even for valid values.
On changing either one of message edit or delete limit setting
from "Any time" to "Custom", the "Save changes" button is not
enabled even after entering valid input.

We can see this bug if both the edit or delete limit setting is
set to "Anytime" initially and one of the setting is changed to
"Custom".

This is because the custom input for "Any time" case is empty even
though it is hidden and the check for disabling the button was
not checking whether the input is hidden or not.

This commit changes the code to consider the value in custom input
box only if the input is visible, i.e. the dropdown value is set to
"Custom".

This bug was introduced in #21837 where we added the functionality
to disable the save button.
2022-08-23 16:17:25 -07:00
..
analytics
billing js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
bundles common: Remove unnecessary polyfills for IE. 2022-07-23 15:36:40 -07:00
portico integrations_dev_panel: Remove unused idempotent flag. 2022-08-19 16:45:09 -07:00
stats channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
types/stacktrace-gps
about_zulip.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
activity.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
add_subscribers_pill.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
admin.js settings: Add checkbox for whether message editing is allowed or not. 2022-08-12 18:09:53 -07:00
alert_popup.ts
alert_words.js alert_words: Fix alert words with HTML special characters. 2022-03-04 12:26:49 -08:00
alert_words_ui.js alert word: Convert inline form to modal. 2022-08-15 19:07:38 -07:00
all_messages_data.js
attachments_ui.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
avatar.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
blueslip.ts
blueslip_stacktrace.ts js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
bot_data.js confirm_deactivate_user: Provide additional information about user. 2022-07-26 17:03:02 -07:00
browser_history.js docs: Consistently hyphenate “web-public”. 2022-01-28 17:45:45 -08:00
buddy_data.js hash_util: Rename _uri functions to _url. 2022-03-01 18:14:31 -08:00
buddy_list.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
channel.js channel: Remove pending_requests list. 2022-08-19 12:17:40 -07:00
click_handlers.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
color_class.ts
color_data.ts
colorspace.ts
common.ts keyboard-shortcuts: Add class to arrow keys for Mac shortcuts. 2022-07-20 11:05:15 -07:00
components.ts js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
compose.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
compose_actions.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
compose_closed_ui.js narrow: Replace pm_string() with _id and _email variants. 2022-06-02 16:41:06 -07:00
compose_error.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
compose_fade.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
compose_fade_helper.js
compose_fade_users.js
compose_pm_pill.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
compose_state.js compose: Ensure we don't warn unresolved topic if not composing for a topic. 2022-08-06 19:31:41 -07:00
compose_ui.js message_scroll: Use CSS transition for scroll to bottom button. 2022-07-13 13:50:55 -07:00
compose_validate.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
composebox_typeahead.js typeahead: Fix thin blue line bug when there is space after `>`. 2022-08-12 16:47:06 -07:00
condense.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
confirm_dialog.js dialog_widget: Migrate modal to Micromodal. 2021-10-26 18:20:17 -07:00
copy_and_paste.js copy-paste: Fix edge cases on message selection for copying. 2022-08-18 15:20:21 -07:00
csrf.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
css_variables.js
dark_theme.js gear_menu: Allow user to configure preferred theme. 2022-02-18 11:29:48 -08:00
debug.js
deprecated_feature_notice.js deprecated_feature_notice: Migrate modal to dialog_widget. 2021-10-29 16:09:39 -07:00
desktop_integration.js
dialog_widget.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
drafts.js drafts: Update drafts when topics are moved. 2022-08-09 16:06:21 -07:00
dropdown_list_widget.js js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
echo.js message_lists: Remove cases for table_name being undefined. 2022-08-18 12:30:30 -07:00
emoji.js emojis: Swap the loops to build the emojis map. 2022-04-04 13:28:49 -07:00
emoji_picker.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
emojisets.js emojisets: Use Google modern for emoji picker with text theme. 2022-06-06 15:53:32 -07:00
favicon.js lint: Fix JS style in last commit. 2021-11-01 11:07:01 -07:00
feature_flags.ts
feedback_widget.js docs: Fix many spelling mistakes. 2022-02-07 18:51:06 -08:00
fetch_status.js docs: Fix many spelling mistakes. 2022-02-07 18:51:06 -08:00
filter.js resolved_topic: Add and use predicate is_resolved. 2022-03-07 21:35:00 -08:00
flatpickr.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
floating_recipient_bar.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
fold_dict.ts
gear_menu.js gear_menu: Link to /devlogin/ in development environment. 2022-05-31 22:54:11 -07:00
giphy.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
global.d.ts
hash_util.js web_public_view: Redirect to current narrow after login. 2022-04-28 10:47:49 -07:00
hashchange.js hash_util: Move enc/decodeHashComponent to shared. 2022-03-01 18:14:31 -08:00
hbs.d.ts
hotkey.js compose: Allow ctrl + enter to send in preview mode as well. 2022-08-16 14:35:47 -07:00
hotspots.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
huddle_data.js
i18n.ts i18n: Simpify default_language conditional. 2022-07-12 17:25:43 -07:00
info_overlay.js documentation (user): Document `/poll` in `?` help widget. 2022-08-16 13:55:56 -07:00
input_pill.js input_pill: Remove random IDs. 2022-07-11 11:44:47 -07:00
invite.js invites: Remove stale use of `control-group` class. 2022-08-09 10:36:27 -07:00
keydown_util.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
lazy_set.ts ts: Convert lazy_set module to typescript. 2022-01-18 13:24:02 -08:00
lightbox.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
linkifiers.js markdown: Use options, not rules, for linkifier regexes. 2022-04-04 14:07:18 -07:00
list_cursor.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
list_util.ts
list_widget.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
loading.ts js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
local_message.js
localstorage.js
markdown.js user_groups: Swap parameter order in is_direct_member_of function. 2022-05-05 13:48:01 -07:00
markdown_config.js user_groups: Rename is_member_of function to is_direct_member_of. 2022-05-05 13:48:01 -07:00
message_edit.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
message_edit_history.js spectators: Fix double modal bug with message edit history. 2022-04-29 16:35:49 -07:00
message_events.js message_lists: Add a function to return rendered message_lists. 2022-08-18 12:30:30 -07:00
message_fetch.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
message_flags.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
message_helper.js narrow: Fix messages being cached without flags set. 2022-03-24 08:10:14 -07:00
message_list.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
message_list_data.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
message_list_view.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
message_lists.js message_lists: Add a function to return rendered message_lists. 2022-08-18 12:30:30 -07:00
message_live_update.js message_lists: Remove cases for table_name being undefined. 2022-08-18 12:30:30 -07:00
message_parser.ts
message_scroll.js message_scroll: Hide scroll to bottom button when using keypress. 2022-07-13 13:56:10 -07:00
message_store.js markdown: Simulate message flags in frontend markdown processor. 2022-03-24 08:10:14 -07:00
message_user_ids.ts
message_util.js message_events: Ask server if cannot filter locally. 2022-02-17 12:56:33 -08:00
message_view_header.js message_view_header: Color web public stream globe icon. 2022-08-17 12:09:12 -07:00
message_viewport.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
muted_topics_ui.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
muted_users.js
muted_users_ui.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
narrow.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
narrow_banner.js narrow_banner: Simplify empty narrow messages for spectators. 2022-04-29 16:35:49 -07:00
narrow_error.js narrow_banner: Move empty narrow messages to handlebar templates. 2021-12-07 13:38:48 -08:00
narrow_state.js narrow: Replace pm_string() with _id and _email variants. 2022-06-02 16:41:06 -07:00
navbar_alerts.js navbar_alerts: Adjust height of recent topics when alert is visible. 2022-03-31 11:25:09 -07:00
navigate.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
notifications.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
overlays.js overlays: Allow calling open_modal with a modal already open. 2022-08-12 13:16:35 -07:00
padded_widget.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
page_params.ts settings: Add user_can_create_web_public_streams function. 2021-11-23 10:48:20 -08:00
password_quality.ts password_quality: Switch zxcvbn to zxcvbn-ts. 2022-03-17 15:24:46 -07:00
peer_data.js
people.js read_receipts: Add support for displaying read receipts. 2022-08-12 13:16:35 -07:00
pill_typeahead.js typeahead: Don't match descriptions for streams and user groups. 2022-07-08 14:28:29 -07:00
pm_conversations.js
pm_list.js pm_list: Handle narrow functions separately for pm_section. 2022-08-12 15:26:00 -07:00
pm_list_data.js Move function declaration out of for loop. 2022-07-14 15:16:53 -07:00
pm_list_dom.js left sidebar: Rename convos => conversations variable names. 2022-04-06 16:51:15 -07:00
poll_widget.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
popover_menus.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
popovers.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
presence.js js: Remove unused buddy_data.huddle_fraction_present function. 2022-02-03 10:59:33 -08:00
reactions.js emojis: Un-share the emoji.js module. 2022-04-04 13:28:49 -07:00
read_receipts.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
realm_icon.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
realm_logo.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
realm_playground.js
realm_user_settings_defaults.ts user_settings: Add a setting to display names of users who reacted. 2022-04-19 17:30:16 -07:00
recent_senders.js
recent_topics_data.js
recent_topics_ui.js recent-topics: Check topic exists when trying to revive focus. 2022-08-23 15:59:06 -07:00
recent_topics_util.js overlays: Add `is_modal_open` check along with `is_active` check. 2022-04-06 14:27:20 -07:00
reload.js js: Only trigger reload-on-focus once. 2022-07-19 17:29:42 -07:00
reload_state.ts
reminder.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
rendered_markdown.js user_groups: Swap parameter order in is_direct_member_of function. 2022-05-05 13:48:01 -07:00
resize.js resize: Don't use `visible` selector to find element states. 2022-05-03 09:19:01 -07:00
rows.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
rtl.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
schema.js
scroll_bar.js docs: Fix many spelling mistakes. 2022-02-07 18:51:06 -08:00
scroll_util.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
search.js search_suggestion: Show profile pictures in autocomplete suggestions. 2022-08-16 14:17:42 -07:00
search_pill.js refactor: Change description to description_html in search suggestions. 2022-08-16 13:56:33 -07:00
search_pill_widget.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
search_suggestion.js search_suggestions: Fix bug where space in stream names did not show. 2022-08-18 11:22:08 -07:00
search_util.ts
sent_messages.js
server_events.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
server_events_dispatch.js message_lists: Add a function to return rendered message_lists. 2022-08-18 12:30:30 -07:00
settings.js settings: Change label of send_read_receipts setting. 2022-08-12 11:25:16 -07:00
settings_account.js user profile modal: Don't close settings when opening modal. 2022-08-22 15:32:18 -07:00
settings_bots.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
settings_config.ts settings: Update label for realm-level default of send_read_receipts. 2022-08-20 15:38:34 -07:00
settings_data.ts settings_data: Remove redundant check from user_can_edit_topic_of_any_message. 2021-11-24 10:37:51 -08:00
settings_display.js admin: Use language_selection_widget to set notification language. 2022-06-01 17:08:00 -07:00
settings_emoji.js emojis: Un-share the emoji.js module. 2022-04-04 13:28:49 -07:00
settings_exports.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_invites.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
settings_linkifiers.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_muted_topics.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
settings_muted_users.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_notifications.js js: Skip redundant jQuery object reconstruction. 2022-08-18 16:11:13 -07:00
settings_org.js settings: Fix save button being disabled even for valid values. 2022-08-23 16:17:25 -07:00
settings_panel_menu.js js: Fix no-jquery/no-sizzle. 2022-03-17 13:10:23 -07:00
settings_playgrounds.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_profile_fields.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
settings_realm_domains.js realm_domains_modal: Migrate modal to dialog_widget. 2022-07-07 14:56:45 -07:00
settings_realm_user_settings_defaults.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_sections.js settings: Add sorting feature for list of alert words. 2022-02-25 17:33:11 -08:00
settings_streams.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_toggle.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_ui.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
settings_user_groups.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
settings_users.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
setup.js
spectators.js overlays: Remove unused support for Bootstrap modals. 2022-07-26 17:48:31 -07:00
spoilers.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
starred_messages.js
starred_messages_ui.js dialog_widget: Append dialog_widget to the body element. 2021-10-26 18:20:17 -07:00
stream_bar.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
stream_color.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
stream_create.js stream_create: Fix crash on stream creation error. 2022-05-31 22:54:57 -07:00
stream_create_subscribers.js js: Fix no-jquery/no-event-shorthand. 2022-03-17 13:10:23 -07:00
stream_create_subscribers_data.js stream create: Overhaul create-stream add-subscribers UI. 2022-03-07 16:58:58 -08:00
stream_data.js stream_list: Sort muted to end of sections and add labels. 2022-08-06 21:59:23 -07:00
stream_edit.js archive stream: Update modal text. 2022-08-05 15:55:13 -07:00
stream_edit_subscribers.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
stream_events.js stream_events: Use `is_muted` event instead of `in_home_view` event. 2022-08-16 16:52:15 -07:00
stream_list.js left-sidebar: Make Subscribe to more streams more informative. 2022-08-15 12:32:43 -07:00
stream_muting.js overlays: Add `is_modal_open` check along with `is_active` check. 2022-04-06 14:27:20 -07:00
stream_pill.js node tests: Directly test simple stream_pill helpers. 2022-02-22 16:29:36 -08:00
stream_popover.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
stream_settings_containers.js stream settings: Extract stream_settings_containers.js. 2021-12-16 15:28:11 -08:00
stream_settings_data.js hash_util: Rename _uri functions to _url. 2022-03-01 18:14:31 -08:00
stream_settings_ui.js stream settings: Live update the stream privacy icon. 2022-08-03 17:46:06 -07:00
stream_sort.js stream_list: Sort muted to end of sections and add labels. 2022-08-06 21:59:23 -07:00
stream_topic_history.js
stream_topic_history_util.js
stream_ui_updates.js js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
sub_store.ts sub_store: Remove role field and SubscriptionRole type. 2022-07-13 17:07:44 -07:00
submessage.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
subscriber_api.js subscribers: Extract subscriber_api. 2022-02-22 16:29:36 -08:00
templates.js docs: Capitalize Handlebars consistently. 2022-06-27 13:35:10 -07:00
timerender.ts js: Fix no-jquery/no-parse-html-literal. 2022-03-17 13:16:34 -07:00
tippyjs.js tippy: Hide tooltip for inline images if the reference is removed. 2022-08-03 16:20:11 -07:00
todo_widget.js js: Fix no-jquery/no-event-shorthand. 2022-03-17 13:10:23 -07:00
top_left_corner.js pm_list: Handle narrow functions separately for pm_section. 2022-08-12 15:26:00 -07:00
topic_generator.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
topic_list.js left sidebar: Rename convos => conversations variable names. 2022-04-06 16:51:15 -07:00
topic_list_data.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
topic_zoom.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
transmit.js reminder: Don't ack server for reminder / scheduled messages. 2021-11-10 09:12:23 -08:00
tutorial.js
typeahead_helper.js compose: Fix sorting of wildcard mentions in case of PMs. 2022-04-28 12:53:46 -07:00
types.ts
typing.js
typing_data.js js: Convert _.uniq(a) to Array.from(new Set(a)). 2022-01-24 15:54:21 -08:00
typing_events.js
ui.js message_lists: Add a function to return rendered message_lists. 2022-08-18 12:30:30 -07:00
ui_init.js js: Use .empty() instead of .html(""). 2022-08-17 16:04:55 -07:00
ui_report.ts js: Enable no-jquery/no-constructor-attributes. 2022-08-16 13:42:28 -07:00
ui_util.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
unread.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
unread_ops.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
unread_ui.js mark as read: Fix banner not closing when x is clicked. 2022-07-12 16:34:26 -07:00
upload.js upload: Locally verify file size before uploading the file. 2022-07-28 14:15:04 -07:00
upload_widget.ts js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
user_events.js js: Shorten Object.prototype.hasOwnProperty.call to Object.hasOwn. 2022-01-24 09:57:09 -08:00
user_group_pill.js node tests: Directly test user_group_pill helpers. 2022-02-22 16:29:36 -08:00
user_groups.ts user_groups: Pass user group object instead of id to get_recursive_subgroups. 2022-05-17 14:51:55 -07:00
user_pill.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
user_profile.js overlays: Remove unused support for Bootstrap modals. 2022-07-26 17:48:31 -07:00
user_search.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
user_settings.ts user_settings: Add a setting to display names of users who reacted. 2022-04-19 17:30:16 -07:00
user_status.js channel: Remove idempotent retry loop. 2022-08-19 12:14:41 -07:00
user_status_ui.js emojis: Un-share the emoji.js module. 2022-04-04 13:28:49 -07:00
user_topics.js user_topics: Rename muted_topics.js to user_topics.js. 2022-08-16 14:39:24 -07:00
util.js left-sidebar: Use -, _ and / additionally as stream word separators. 2022-08-02 15:55:07 -07:00
vdom.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
watchdog.ts
webpack_public_path.js
widgetize.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
zcommand.js markdown: Extract parse_non_message(). 2022-04-04 14:07:18 -07:00
zform.js js: Prefix jQuery object variable names with $. 2022-03-16 12:52:07 -07:00
zulip_test.js stream create: Overhaul create-stream add-subscribers UI. 2022-03-07 16:58:58 -08:00