zulip/zerver
Steve Howell 36844418e9 bug fix: Respect include_history for certain queries.
For certain queries where both include_history and
use_first_unread_anchor are set to True, we were excluding
historical rows.  Now we only use the use_first_unread_anchor
flag to filter rows that we use to find the anchor, without
having it filter the actual search results.

The bug went unreported for a long time, because it only
affected mobile users who had newly subscribed to streams.

Note that we make a small change to the test called
test_use_first_unread_anchor_with_muted_topics, which has
a very scary comment about being "arcane" and "be
absolutely sure you know what you're doing."  I think it's
fine.

Also, the new test code would fail before this fix, so it
should help prevent future regressions.

Fixes #8958
2018-04-05 17:16:41 -04:00
..
fixtures markdown: Update bugdown emoticon translation logic to match frontend. 2018-03-29 15:56:24 -07:00
lib users: Improve testing for user_ids_to_users. 2018-04-04 16:31:30 -07:00
management mypy: Add explicit Optional for default=None parameters in various files. 2018-03-28 12:31:51 -07:00
migrations bots: Clean up editing bots impacting non-bot users. 2018-04-02 18:58:26 -07:00
templatetags mypy: Migrate templatetags/minified_js.py to python3.5 annotations. 2018-03-12 11:23:30 -07:00
tests bug fix: Respect include_history for certain queries. 2018-04-05 17:16:41 -04:00
tornado websockets: Fix race condition in CSRF token initialization. 2018-03-31 09:29:56 -07:00
views bug fix: Respect include_history for certain queries. 2018-04-05 17:16:41 -04:00
webhooks webhooks/bitbucket2: Detect pushes that remove branches correctly. 2018-04-02 19:30:09 -02:30
worker mypy: Remove need for cast by using ConcreteQueueWorker TypeVar. 2018-03-11 15:34:11 -07:00
__init__.py
apps.py zerver: Use Python 3 syntax for typing. 2017-11-28 16:49:36 -08:00
context_processors.py settings: Add option to control Jitsi video chat integration. 2018-04-02 16:55:16 -07:00
decorator.py decorators: Log custom HTTP headers in webhook requests. 2018-03-30 13:37:35 -07:00
filters.py zerver: Use Python 3 syntax for typing. 2017-11-28 16:49:36 -08:00
forms.py forms: Fix missing translation tag for disposable emails. 2018-03-15 14:43:40 -07:00
logging_handlers.py test_logging_handlers: Mock out `git describe` because can be slow. 2018-03-23 18:24:51 -07:00
middleware.py mypy: Rewrite some middleware annotations to use ViewFuncT. 2018-03-17 23:25:05 +00:00
models.py actions.py: Obtain bot profiles by using users.user_ids_to_users(). 2018-04-04 16:24:55 -07:00
signals.py emails: Fix notify_new_login emails have unserializable context. 2017-12-22 16:34:18 -05:00
static_header.txt
storage.py mypy: Improve typing for ManifestStaticFilesStorage monkeypatch. 2017-12-08 19:00:18 -08:00