Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/tests
History
Alex Vandiver 039b869ca5 email_notifications: Fix inline-ing of image-URL-only messages. 
fe25517295 adjusted the email_notifications codepath to use
`lxml.html.fragment_fromstring` method when parsing
`rendered_content`, but left the tests using a helper which called
`fromstring`.

Switching the tests to match the code as run reveals a bug -- using
`drop_tree` on all `message_inline_image` classes now _does_ remove
all of a top-level image-URL-only message.  Previously, such messages
were "safe" from the block that calls `drop_tree` only by dint of
`drop_tree` being a silent no-op for the root element.  When parsed
using `fragment_fromstring`, they are no longer the root, and as such
an empty message results.

Reorder relative_to_full_url to check for only one `message_inline_image`
within the top `<div>`, and only run the `drop_tree` path in the
alternate case.  Tests must be adjusted for their output now including
one more layer of `<div>`.
 		2021-09-15 09:45:38 -07:00
..
fixtures data_import: Fix channel mentions in Rocket.Chat import. 2021-08-09 06:38:26 -07:00
images upload: Replace exif_rotate with Pillow exif_transpose. 2021-08-09 20:32:19 -07:00
__init__.py
…
test_alert_words.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_attachments.py
…
test_audit_log.py settings: Remove do_change_notification_settings function. 2021-09-08 11:04:44 -07:00
test_auth_backends.py auth: Add logging of successful attempts to social codepath. 2021-09-14 15:39:41 -07:00
test_bots.py typing: Avoid redefining variable with different types. 2021-08-20 06:02:56 -07:00
test_cache.py bots: Pass realm to get_system_bot calls in test_cache.py. 2021-07-26 15:33:13 -07:00
test_compatibility.py compatibility: Shift functions to new module. 2021-06-05 07:33:25 -07:00
test_create_video_call.py video_calls: Remove call to deprecated Zoom Data Compliance API. 2021-07-30 09:19:22 -07:00
test_custom_profile_data.py markdown: Refactor out additional properties added to Message. 2021-06-24 18:14:53 -07:00
test_data_types.py
…
test_decorators.py auth: Make the deactivated user error message clearer. 2021-09-10 10:47:15 -07:00
test_digest.py python: Remove unnecessary intermediate lists. 2021-08-02 15:53:52 -07:00
test_docs.py downloads: Serve desktop downloads from desktop-download.zulip.com. 2021-08-28 23:08:45 -07:00
test_drafts.py populate_db: Create some drafts in the initial database. 2021-07-30 10:41:52 -07:00
test_email_change.py api: Remove "full_name" and "account_email" from response of '/settings'. 2021-07-16 16:10:15 -07:00
test_email_log.py
…
test_email_mirror.py email_mirror: Downgrade ZulipEmailForwardUserError to info. 2021-08-31 16:37:54 -07:00
test_email_notifications.py email_notifications: Fix inline-ing of image-URL-only messages. 2021-09-15 09:45:38 -07:00
test_embedded_bot_system.py
…
test_event_queue.py notifications: Fix unnecessary wildcard mention notifications. 2021-08-13 09:48:18 -07:00
test_event_system.py actions: Add do_set_realm_user_default_setting. 2021-09-09 10:38:38 -07:00
test_events.py do_invite_users: Turn some args into kwargs-only. 2021-09-10 16:53:03 -07:00
test_example.py Rename default branch to ‘main’. 2021-09-06 12:56:35 -07:00
test_external.py test_external: Extract rate_limit_rule() decorator. 2021-08-06 12:17:44 +02:00
test_github.py downloads: Serve desktop downloads from desktop-download.zulip.com. 2021-08-28 23:08:45 -07:00
test_gitter_importer.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_home.py actions: Add do_set_realm_user_default_setting. 2021-09-09 10:38:38 -07:00
test_hotspots.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_i18n.py invite: Extend invite api for handling expiration duration. 2021-09-10 16:53:03 -07:00
test_import_export.py models: Ensure every realm has a RealmUserDefault object. 2021-09-09 10:28:44 -07:00
test_integrations.py tests: Add a test for fixtures for non-webhook integrations. 2021-04-28 08:16:51 -07:00
test_integrations_dev_panel.py exceptions: Add ResourceNotFoundError. 2021-07-05 11:02:12 -07:00
test_internet.py
…
test_legacy_subject.py
…
test_link_embed.py outgoing_http: Use OutgoingSession subclasses in more places. 2021-09-01 05:34:13 -07:00
test_logging_handlers.py typing: Fix function signatures with django-stubs. 2021-08-20 06:02:55 -07:00
test_management_commands.py tests: Use assertion to enforce None-checks in tests. 2021-07-24 09:54:21 -07:00
test_markdown.py messages: Do not allow mentioning system user groups. 2021-09-09 11:25:33 -07:00
test_mattermost_importer.py data_import: Rename mattermost_user to user_handler. 2021-07-15 14:28:36 -07:00
test_message_dict.py bots: Pass realm to self.notification_bot test helper. 2021-07-26 15:33:13 -07:00
test_message_edit.py bots: Pass realm to self.notification_bot test helper. 2021-07-26 15:33:13 -07:00
test_message_edit_notifications.py notifications: Fix unnecessary wildcard mention notifications. 2021-08-13 09:48:18 -07:00
test_message_fetch.py spectators: Rename is_web_public_compatible functions. 2021-09-06 09:00:16 -07:00
test_message_flags.py page load: Remove sender_ids in unread messages for streams. 2021-08-04 11:44:00 -04:00
test_message_send.py bots: Pass realm to remaining get_system_bot calls in tests. 2021-07-26 15:33:13 -07:00
test_message_topics.py python: Fix mypy no_implicit_reexport errors. 2021-07-16 14:02:31 -07:00
test_messages.py notifications: Calculate PMs/mentions settings like other settings. 2021-07-28 13:55:25 -07:00
test_middleware.py test_middleware: Replace logging mocks with assertLogs. 2021-07-26 14:46:01 -07:00
test_migrations.py
…
test_mirror_users.py tests: Migrate mocked Request to HostMockRequest. 2021-07-14 12:01:07 -07:00
test_muting_topics.py models: Remove MutedTopic alias for UserTopic. 2021-07-28 10:25:54 -07:00
test_muting_users.py python: Convert "".format to Python 3.6 f-strings. 2021-08-02 15:53:52 -07:00
test_new_users.py settings: Remove do_change_notification_settings function. 2021-09-08 11:04:44 -07:00
test_notification_data.py notifications: Fix unnecessary wildcard mention notifications. 2021-08-13 09:48:18 -07:00
test_onboarding.py
…
test_openapi.py typing: Avoid redefining variable with different types. 2021-08-20 06:02:56 -07:00
test_outgoing_http.py outgoing_http: Give an easy way to configure retries. 2021-09-01 05:34:13 -07:00
test_outgoing_webhook_interfaces.py outgoing_webhook: Improve invalid json handling when parsing response. 2021-04-26 09:32:35 -07:00
test_outgoing_webhook_system.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_populate_db.py
…
test_presence.py statistics: Remove unused seconds_usage_between function. 2021-08-19 01:51:37 -07:00
test_push_notifications.py push_notifications: Remove redundant APNs retry loop. 2021-09-03 11:49:33 -07:00
test_queue.py mypy: Add pika-stubs. 2021-08-02 22:31:46 -07:00
test_queue_worker.py invite: Extend invite api for handling expiration duration. 2021-09-10 16:53:03 -07:00
test_rate_limiter.py rate_limit: Implement IP-based rate limiting. 2021-07-08 15:46:52 -07:00
test_reactions.py python: Fix mypy no_implicit_reexport errors. 2021-07-16 14:02:31 -07:00
test_realm.py models: Add is_web_public property to Realm model. 2021-09-14 10:33:53 -07:00
test_realm_domains.py tests: Clean up tests for realm_domain and update_streams endpoint. 2021-05-12 12:38:16 -07:00
test_realm_emoji.py realm: Extend add_custom_emoji_policy to use COMMON_POLICY_TYPES. 2021-07-27 16:41:23 -07:00
test_realm_export.py tests: Pass HostRequestMock to export_realm. 2021-07-26 15:09:07 -07:00
test_realm_linkifiers.py linkifiers: Add joint validation for linkifier urls and patterns. 2021-06-16 17:51:33 -07:00
test_realm_playgrounds.py models: Fix bug in unique_together condition on RealmPlayground. 2021-05-24 23:11:41 -07:00
test_redis_utils.py
…
test_report.py docs: Fix capitalization mistakes. 2021-05-10 09:57:26 -07:00
test_retention.py bots: Pass realm to remaining get_system_bot calls in tests. 2021-07-26 15:33:13 -07:00
test_rocketchat_importer.py data_import: Fix channel mentions in Rocket.Chat import. 2021-08-09 06:38:26 -07:00
test_send_email.py python: Convert "".format to Python 3.6 f-strings. 2021-08-02 15:53:52 -07:00
test_service_bot_system.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_sessions.py test_sessions: Fix unnecessarily hard-coded user id. 2021-07-13 08:31:11 -07:00
test_settings.py email notifs: Update scheduled timestamps after batching period change. 2021-09-10 13:25:47 -07:00
test_signup.py create_confirmation_link: Turn some args into kwargs-only. 2021-09-10 16:53:03 -07:00
test_slack_importer.py slack_import: Remove obsolete SlackImportAttachment placeholder. 2021-08-02 13:13:28 -07:00
test_slack_message_conversion.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_soft_deactivation.py tests: Consistently use assert_length helper. 2021-05-19 11:55:56 -07:00
test_subdomains.py subdomains: Extend "static" to include resources hosted on S3. 2021-06-08 15:28:10 -07:00
test_submessage.py submessages: Add verify_submessage_sender. 2021-06-14 17:46:16 -07:00
test_subs.py actions: Remove acting_client parameter from bulk_remove_subscriptions. 2021-08-19 01:51:37 -07:00
test_templates.py
…
test_thumbnail.py requirements: Remove Thumbor. 2021-05-06 20:07:32 -07:00
test_timestamp.py
…
test_timezone.py docs: Fix spelling errors caught by codespell. 2021-04-26 09:31:08 -07:00
test_tornado.py tornado: Explicitly mark requests as varying by cookie. 2021-04-02 14:55:22 -07:00
test_transfer.py emoji: Add backend changes to support still image for animated emojis. 2021-09-12 07:13:04 +00:00
test_tutorial.py bots: Pass realm to remaining get_system_bot calls in tests. 2021-07-26 15:33:13 -07:00
test_type_debug.py
…
test_typing.py tornado_redirected_to_list: Make expected_num_events required argument. 2021-05-28 09:42:14 -07:00
test_upload.py emoji: Add backend changes to support still image for animated emojis. 2021-09-12 07:13:04 +00:00
test_urls.py auth: Implement a generic OpenID Connect backend. 2021-05-28 09:43:06 -07:00
test_user_groups.py tests: Rename system user group used in user group tests. 2021-09-01 13:05:33 -07:00
test_user_status.py user_status: Add backend changes to support status emoji. 2021-07-27 17:57:15 -07:00
test_users.py invite: Extend invite api for handling expiration duration. 2021-09-10 16:53:03 -07:00
test_webhooks_common.py typing: Fix function signatures. 2021-08-20 05:54:19 -07:00
test_widgets.py widgets: Add range checks on backend for indexes. 2021-06-29 13:40:33 -07:00
test_zcommand.py
…
test_zephyr.py docs: Add missing space to compound verbs “log in”, “set up”, etc. 2021-04-26 09:31:08 -07:00