mirror of https://github.com/zulip/zulip.git
e39e04c3ce
Note that we use the DjangoJSONEncoder so that we have builtin support for parsing Decimal and datetime. During this intermediate state, the migration that creates extra_data_json field has been run. We prepare for running the backfilling migration that populates extra_data_json from extra_data. This change implements double-write, which is important to keep the state of extra data consistent. For most extra_data usage, this is handled by the overriden `save` method on `AbstractRealmAuditLog`, where we either generates extra_data_json using orjson.loads or ast.literal_eval. While backfilling ensures that old realm audit log entries have extra_data_json populated, double-write ensures that any new entries generated will also have extra_data_json set. So that we can then safely rename extra_data_json to extra_data while ensuring the non-nullable invariant. For completeness, we additionally set RealmAuditLog.NEW_VALUE for the USER_FULL_NAME_CHANGED event. This cannot be handled with the overridden `save`. This addresses: https://github.com/zulip/zulip/pull/23116#discussion_r1040277795 Note that extra_data_json at this point is not used yet. So the test cases do not need to switch to testing extra_data_json. This is later done after we rename extra_data_json to extra_data. Double-write for the remote server audit logs is special, because we only get the dumped bytes from an external source. Luckily, none of the payload carries extra_data that is not generated using orjson.dumps for audit logs of event types in SYNC_BILLING_EVENTS. This can be verified by looking at: `git grep -A 6 -E "event_type=.*(USER_CREATED|USER_ACTIVATED|USER_DEACTIVATED|USER_REACTIVATED|USER_ROLE_CHANGED|REALM_DEACTIVATED|REALM_REACTIVATED)"` Therefore, we just need to populate extra_data_json doing an orjson.loads call after a None-check. Co-authored-by: Zixuan James Li <p359101898@gmail.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| alert_words.py | ||
| bots.py | ||
| create_realm.py | ||
| create_user.py | ||
| custom_profile_fields.py | ||
| default_streams.py | ||
| hotspots.py | ||
| invites.py | ||
| message_delete.py | ||
| message_edit.py | ||
| message_flags.py | ||
| message_send.py | ||
| muted_users.py | ||
| presence.py | ||
| reactions.py | ||
| realm_domains.py | ||
| realm_emoji.py | ||
| realm_export.py | ||
| realm_icon.py | ||
| realm_linkifiers.py | ||
| realm_logo.py | ||
| realm_playgrounds.py | ||
| realm_settings.py | ||
| scheduled_messages.py | ||
| streams.py | ||
| submessage.py | ||
| typing.py | ||
| uploads.py | ||
| user_activity.py | ||
| user_groups.py | ||
| user_settings.py | ||
| user_status.py | ||
| user_topics.py | ||
| users.py | ||
| video_calls.py | ||