mirror of https://github.com/zulip/zulip.git
80c057d91d
Update the REQ check for profile_data in
update_user_backend by tweaking `check_profile_data`
to use `check_dict_only`.
Here is the relevant URL:
path('users/<int:user_id>', rest_dispatch,
{'GET': 'zerver.views.users.get_members_backend',
It would be nice to unify the validator
for these two views, but they are different:
update_user_backend
update_user_custom_profile_data
It's not completely clear to me why update_user_backend
seems to support a superset of the functionality
of `update_user_custom_profile_data`, but it has
this code to allow you to remove custom profile fields:
clean_profile_data = []
for entry in profile_data:
assert isinstance(entry["id"], int)
if entry["value"] is None or not entry["value"]:
field_id = entry["id"]
check_remove_custom_profile_field_value(target, field_id)
else:
clean_profile_data.append({
"id": entry["id"],
"value": entry["value"],
})
Whereas the other view is much simpler:
def update_user_custom_profile_data(
<snip>
) -> HttpResponse:
validate_user_custom_profile_data(user_profile.realm.id, data)
do_update_user_custom_profile_data_if_changed(user_profile, data)
# We need to call this explicitly otherwise constraints are not check
return json_success()
|
||
|---|---|---|
| .. | ||
| development | ||
| __init__.py | ||
| alert_words.py | ||
| archive.py | ||
| attachments.py | ||
| auth.py | ||
| camo.py | ||
| compatibility.py | ||
| custom_profile_fields.py | ||
| digest.py | ||
| documentation.py | ||
| email_mirror.py | ||
| events_register.py | ||
| home.py | ||
| hotspots.py | ||
| invite.py | ||
| message_edit.py | ||
| message_fetch.py | ||
| message_flags.py | ||
| message_send.py | ||
| muting.py | ||
| pointer.py | ||
| portico.py | ||
| presence.py | ||
| push_notifications.py | ||
| reactions.py | ||
| realm.py | ||
| realm_domains.py | ||
| realm_emoji.py | ||
| realm_export.py | ||
| realm_filters.py | ||
| realm_icon.py | ||
| realm_logo.py | ||
| registration.py | ||
| report.py | ||
| storage.py | ||
| streams.py | ||
| submessage.py | ||
| thumbnail.py | ||
| tutorial.py | ||
| typing.py | ||
| unsubscribe.py | ||
| upload.py | ||
| user_groups.py | ||
| user_settings.py | ||
| users.py | ||
| video_calls.py | ||
| zephyr.py | ||