Anders Kaseorg
eb09c137cf
click_handlers: Use WinChan as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Anders Kaseorg
114cc1ec25
settings_profile_fields: Use SortableJS as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Anders Kaseorg
1d59fc272c
js: Use Marked.js as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Anders Kaseorg
bcab7efb37
js: Use XDate as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Anders Kaseorg
c66931d4cd
js: Use clipboard.js as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Anders Kaseorg
f0021df3d4
people: Use blueimp-md5 as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
Steve Howell
fb06aa9419
node tests: Swap actual/expected in various assert calls.
2020-07-28 11:48:55 -04:00
Clara Dantas
831298d387
test_classes: Modify functions to deal with web-public streams.
...
Modify common_subscribe_to_streams to perform subscription in
web-public streams as well, and make_stream function to create
web-public streams.
2020-07-27 18:30:06 -07:00
Tim Abbott
dbde901684
events: Document unintentionally exposed API fields.
...
It's a bug that these are sent in event payloads; I'll open an issue
for resolving that issue. For now we document them mainly to make our
tests pass.
2020-07-27 18:08:41 -07:00
orientor
227c90a4ae
openapi: Document `message` event.
2020-07-27 18:08:41 -07:00
orientor
ec40a5dda4
openapi_py: Add validation for `/events`.
...
Edit the function `validate_against_openapi_schema` and add some
helper functions to allow for validation of documented events.
Also add OpenAPI response validation in `verify_action` as it is
called in a large number of `/events` tests.
2020-07-27 18:08:41 -07:00
orientor
ed8d1925fb
openapi: Edit `/events` OpenAPI specification for validation.
...
Some events in `/events` were incorrectly or incompletely documented.
Rectify them.
2020-07-27 18:08:41 -07:00
orientor
86f7b8f7d9
openapi_markdown: Add parser for events documentation.
...
Add parser so that documentation of the various events returned by
`/events` are rendered to the docs directly from their OpenAPI
specification.
2020-07-27 18:08:41 -07:00
orientor
cdacd3223b
openapi: Document various events.
2020-07-27 18:08:41 -07:00
Hashir Sarwar
946836455c
typeahead: Fix binding of event handler to `blur` event.
...
This was a bug in 0f76e98
that prevented typeahead from
closing unless we select an option from it.
Fixes #15905 and #15907 .
2020-07-27 17:52:19 -07:00
Tim Abbott
3252dfaa72
api: Document API change for Stream.date_created.
2020-07-27 17:10:59 -07:00
Tim Abbott
49926bc07b
node tests: Fix schema for stream events.
2020-07-27 16:52:29 -07:00
Alex Vandiver
9266315a1f
middleware: Stop shadowing top-level logger definition on line 33.
2020-07-27 16:46:13 -07:00
Tim Abbott
282927003f
features: Remove inaccurate accessibility claim.
...
I'm not sure how this got added; it seems to have happened in a visual
redesign of the /features page. Certainly the claim should only have
been added after the work it described was done, and it has not.
2020-07-27 16:41:42 -07:00
Tim Abbott
3d1a1e0d20
test_logging_handlers: Avoid printing to console.
...
This lets us test the recursion bug behavior of this logging handler
without resulting in `logging.error` output being printed to the
console in the event that the test passes.
2020-07-27 16:33:36 -07:00
Sumanth V Rao
3e80cbdeb8
docs/update-message: Add missing editing permission condition.
...
The comments within update_message_backend function of views/message_edit.py
indicates 4 types of permissions which all edit a message. The 4th of these
indicates that a message is editable if the realm allows topic edits. This
was previously missing from the docs and is now added.
2020-07-27 16:33:36 -07:00
Sumanth V Rao
9b6de63afe
stream/docs: Add date_created to Stream.API_FIELDS.
...
The parameter Stream.date_created is now sent down to the clients
for both:
- client.get_streams()
- client.list_subscriptions()
API docs updated for stream and subscriptions.
Fixes #15410
2020-07-27 16:33:36 -07:00
Alex Vandiver
1c8f4b936b
sentry: Capture realm name in user information.
2020-07-27 11:07:55 -07:00
Alex Vandiver
af046df3be
sentry: Allow setting DSN via environment.
2020-07-27 11:07:55 -07:00
Alex Vandiver
1b2d0271af
sentry: Prevent double-logging of JSON-formatted errors.
...
Capture and report the initial exception, not the formatted text-only
message traceback.
2020-07-27 11:07:55 -07:00
Alex Vandiver
bfa809181a
sentry: Allow reporting errors to sentry.io.
...
Use the default configuration, which catches Error logging and
exceptions. This is placed in `computed_settings.py` to match the
suggested configuration from Sentry[1], which places it in `settings.py`
to ensure it is consistently loaded early enough.
It is placed behind a check for SENTRY_DSN soas to not incur the
additional overhead of importing the `sentry_sdk` modules if Sentry is
not configured.
[1] https://docs.sentry.io/platforms/python/django/
2020-07-27 11:07:55 -07:00
Vinit Singh
1f54918c8a
message_controls: Use a template instead of passing html as a string.
...
This commit adds a handlebar template for the View source/Edit message
button in message controls in the message view.
This change also fixes the broken html titles that were added in
commit fdbab54614
, and adds proper
internationalization for the title text.
2020-07-27 11:05:44 -07:00
Mohit Gupta
e9203d92bb
test_upload: Use assertLogs in upload tests to verify logs.
...
This will avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
c9136586d9
test_signup: Use assertLogs in signup tests to verify logging.
...
This will avoid logs to spam test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
1668c7395e
test_settings: Verify logs of domain mismatch in password change test.
...
Use assertLogs for verifying debug log produced due to LDAP domain
mismatch while changing password. This will avoid spam in test-backend
output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
dbbacdd3d9
test_sessions: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
4192c6f959
test_report: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
8b9deb9c71
test_realm: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
82646e27c2
test_realm_export: Use assertLogs in endpoint tests to verify info log.
...
This is to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
3eda7586f3
test_queue_worker: Use assertlogs to verify logs while testing workers.
...
This will avoid spam in output of test-backend.
2020-07-27 11:02:17 -07:00
Mohit Gupta
732f1fa44d
test_queue: Use assertLogs to verify warning in test_queue_error_json.
...
This will avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
Mohit Gupta
68b9f0b3cf
tests: User assertLogs to verify info logs while soft deactivation.
...
This will avoid spamming of test-backend output.
2020-07-27 11:02:17 -07:00
Ryan Rehman
15c5dadb73
message view: Move live update logic of stream name to `message_store`.
2020-07-27 11:00:31 -07:00
Ryan Rehman
131a1dd54f
message view: Move live update logic of avatar url to `message_store`.
2020-07-27 11:00:31 -07:00
Ryan Rehman
06d0dc1ffa
message view: Move live update logic of full name to `message_store`.
...
This is done to decouple our message view related update events
from MessageListData as there are plans to create multiple
MessageListData objects. Instead we update the `stored_messages`
which tracks the complete data for all messages.
2020-07-27 11:00:31 -07:00
Ryan Rehman
e85bc853d6
message list: Refactor and update API to include `rerender_view`.
...
This is a necessary prep commit as our message live update
functions will call this function, outside the MessageList class.
2020-07-27 11:00:31 -07:00
Steve Howell
64894fe8e4
node tests: Avoid "orig_foo = bar" idiom.
...
We use either override or with_field, as
appropriate.
2020-07-27 11:07:41 -04:00
Steve Howell
329f38975e
zjsunit: Add with_field helper.
...
This just lets us temporarily assign a value
to a field.
Differences with the "override" scheme:
* override only works on globals
* override (when passed in via run_test) will
just automatically clean up at the end of
the function
2020-07-27 11:07:41 -04:00
Dinesh
2e864d487e
puppeteer: Add subscriptions test and required functions.
...
Tests stream subscriptions and stream creation.
2020-07-26 17:10:56 -07:00
Dinesh
2835092010
puppeteer: Make fill_form function empty text fields before filling.
2020-07-26 17:10:56 -07:00
Dinesh
56c5e0318f
puppeteer: Remove set_pm_recipient.
...
Previous commit introduced same function in pm_recipient object.
So, this comit removes the duplicate `set_pm_recipient`.
2020-07-26 17:10:56 -07:00
Dinesh
4998e32b10
puppeteer: Add compose tests and required functions in common.js.
...
Thanks to Priyank Patel for helping debug flakes.
2020-07-26 17:10:56 -07:00
Anders Kaseorg
0b4483c8d2
settings_panel_menu: Convert make_menu to an ES6 class SettingsPanelMenu.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
Anders Kaseorg
025f49dbc4
poll_widget: Convert poll_data_holder to an ES6 class PollData.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
Anders Kaseorg
2e94914be4
list_cursor: Convert list_cursor to an ES6 class ListCursor.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00