ed3ab27908
compose.js: Add coverage to compose_invite_close_clicked event.
2017-07-09 08:49:45 -04:00
f9cbd015cb
compose.js: Add coverage for compose_invite_users_clicked event.
2017-07-09 08:49:45 -04:00
359c9aaec8
zjquery: Remove jquery_array().
...
This commit simplifies how our zjquery objects are constructed.
We used to have a strange array proxy (my fault) that turns out
to be unnecessary.
2017-07-09 08:31:22 -04:00
203a0bf119
minor: Set object length for stream_list test.
2017-07-09 08:31:22 -04:00
ff80ba4f99
autofocus: Remove unneeded `$(...)[0]` idiom.
...
Using the first element of a jQuery collection is either
unnecessary or extremely brittle.
2017-07-09 08:31:22 -04:00
1cf18cfbeb
compose: Avoid render for duplicate mentions.
...
There is no reason to render the template for compose mention
warnings if the user is already in the widget.
This commit also restructures the unit test significantly to more
carefully exercise each case, particularly in regard to when
templates get rendered.
2017-07-09 08:30:46 -04:00
05a21b3729
compose.js: Fix Jquery selector to use more prominent syntax.
2017-07-09 07:26:09 -04:00
0f2c208a5b
tools: Add new tool to pretty-print-html.
2017-07-09 07:01:29 -04:00
8dd2268c3b
set_message_flags: Replace get_user_profile_by_email with get_user.
2017-07-08 14:40:55 -07:00
0e76d95b9f
export_single_user: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
afc41dfb6b
rate_limit: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
1ce6b8db8c
remove_users_from_stream: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
038f2d669a
turn_off_digests: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
fdf3df4154
bulk_change_user_name: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
3b6d5fd80e
bankrupt_users: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
a5d2576801
deactivate_users: Replace get_user_profile_by_email with get_user.
2017-07-08 14:38:45 -07:00
b01e6d750f
management: Remove obsolete update_permissions management command.
...
This was part of the old Django/guardian-based permissions system.
2017-07-08 14:37:25 -07:00
3395f38bf7
management: Remove obsolete gravatar_to_user_avatar management command.
...
This was used for a 1-time migration in 2013, and definitely isn't
needed anymore.
2017-07-08 14:35:53 -07:00
36972f611c
add_users_to_streams: Remove unused imports.
2017-07-08 14:35:42 -07:00
6869e6a1ec
bots UI: Create a new bot switches tab to "Active bots".
...
Creating a new bot (by filling out the bots related fields and clicking
"Create bot" button) changes tab from "Add a new bot" to "Active bots".
This is done to make users know/confirm that the bot has been created and
the user can view it in this tab.
Fixes : #5731
2017-07-08 14:30:45 -07:00
09b8e1f644
bots UI: Make "Active bots" the default tab in "#settings/your-bots".
...
This is to make viewing bots easy from user's perspective. As the
most used tab in "Active bots", "Inactive bots" and "Add a new bot"
would be the first one.
2017-07-08 14:30:45 -07:00
1214505ab7
bots UI: Make "Add a new bot" tab the third tab instead of the first one.
2017-07-08 14:30:45 -07:00
4340b94a2d
create_user: Separate password help into multiple lines.
...
This line is too long and ./tools/lint --pep8 is failing because
of this.
2017-07-08 14:18:49 -07:00
7a9de7766b
Add password argument to `manage.py create_user`.
...
Tweaked by tabbott to provide clear --help output recommending against
setting passwords this way.
2017-07-08 10:59:02 -07:00
e926f72bea
notifications: Fix broken rendering of realm emoji in missed message emails.
...
We were using relative URLs for realm emojis in missed message emails.
Since the email server is not same as the Zulip server and doesn't
have the realm emoji files, they were rendered as broken images. This
commit fixes them to use absolute URL.
Fixes : #5692 .
2017-07-08 10:54:06 -07:00
32269ad142
mypy: Set type of rabbitmq_heartbeat to Optional[int] in queue.py.
2017-07-08 10:49:42 -07:00
07255d49d5
mypy: Add check for parse_user_agent returning None in compatibility.py.
2017-07-08 10:49:42 -07:00
33a6a633eb
mypy: Amend tools/check-css functions from Text to str.
2017-07-08 10:49:42 -07:00
8433d95d99
mypy: Make success_stamp parameter to do_npm_install be required.
2017-07-08 10:49:42 -07:00
bea44fb28a
compose.js: Add coverage to compose_all_everyone_confirm_clicked.
...
(Steve Howell also helped.)
2017-07-08 10:50:48 -04:00
777581a1e4
compose.js: Add coverage for usermention_completed.zulip event.
2017-07-08 10:42:20 -04:00
7376934a77
zjquery: Add $.create() method.
...
This commit add $.create(), which allows you to create a
jQuery object that just has a name to identify it, as opposed
to some selector or HTML fragment. It's useful for things that
are really used as stubs.
This also fixes a bunch of the existing tests to use $.create().
Before this fix, you could actually just do $('some-stub'), but
now we enforce that the input to $() looks like a valid selector
or HTML fragment, and we make some exceptions for things like
window-stub and document-stub.
2017-07-08 10:32:32 -04:00
90777fd1fa
zjquery: Add parents() and set_parents_result().
2017-07-08 08:49:09 -04:00
ccd821e29b
zjquery: Rename add_child() to set_find_results().
...
Hopefully this will make it more explicit that zjquery does
not truly simulate DOM, but it instead allows you to dynamically
set what you want the results of $('foo').find(some_selector)
to be.
2017-07-08 08:31:18 -04:00
70407e080d
zjquery: Require explicit set_parent() calls.
...
Before this commit, we were erroneously setting up parents
as part of add_child() calls, but it's not necessarily the
case that those children are immediate children, and therefore
the first object is not necessarily the immediate parent.
2017-07-08 08:21:27 -04:00
c91eca291c
zjquery: Remove broken code related to remove().
...
The logic to remove ourself from the parent's children wasn't
correct.
2017-07-08 07:57:02 -04:00
9657c4c176
casper: Fix flaky realm creation test.
...
This test was failing nondeterministically, because depending on when
the check was done, the unread message may or may not have been read.
2017-07-07 21:16:01 -07:00
4f8a2d0c57
filter.js: Make from/sender descriptions more concise.
2017-07-07 20:54:54 -07:00
2ce7a20237
search_suggestion: Support autocompleting operator names.
...
Fixes #5399
2017-07-07 20:54:54 -07:00
2e9ec5e958
search_suggestion: Remove unknown operand from 'is'.
...
Fixes #5400
2017-07-07 20:54:54 -07:00
e226073d1d
stream_create: Use stream_name as local variable for stream names.
...
This is a lot clearer than using "stream", which could refer to an
actual object.
2017-07-07 19:31:47 -07:00
cbdffeda82
subscriptions: Edit copy for the new stream creation confirmation flow.
...
The new text is a bit simpler and clearer.
We also decrease the threshhold for this page to 50 subscribers.
2017-07-07 19:22:34 -07:00
60e5071843
subscriptions: Confirm inviting 100+ users to a new stream.
...
Our current workflow for creating a new stream allows the user to
invite as many other users as they like but since there can be
mistakes in doing so, we now open a modal with a warning if the
number of invites are more than 100 just to confirm that user indeed
wanted to do this.
Fixes : #1663 .
2017-07-07 19:08:04 -07:00
054f7db63b
stream_create: Extract create_stream.
2017-07-07 19:07:36 -07:00
989d58fd06
stream_create: Extract get_principals.
2017-07-07 19:04:55 -07:00
0f46fd86dd
urls: Rename arguments to accounts/unsubscribe.
...
type -> email_type to match future work on ScheduledJob.
token -> confirmation_key to match what the other confirmation views urls
call this argument.
2017-07-07 18:56:14 -07:00
11a4cffba0
confirmation: Add explicit host in call to get_link_for_object in auth.py.
2017-07-07 18:56:14 -07:00
a44d8f7b01
confirmation/views: Restructure code for clarity.
2017-07-07 18:56:14 -07:00
cf6aefb37a
confirmation/views: Remove confirmation_key.lower().
...
I'm not sure why this line is here. It's a part of the original third party
confirmation library that we copied into the project.
2017-07-07 18:56:14 -07:00
cd8c38b96e
confirm.html: Add text suggesting that the users link may be expired.
2017-07-07 18:56:14 -07:00
Aditya Bansal
Steve Howell
Vishnu Ks
Tim Abbott
Abhijeet Kaur
rht
Harshit Bansal
neiljp (Neil Pilgrim)
Cory Lynch
Rishi Gupta