c1628e7605
provision: Upgrade support for Fedora to version 33.
...
Note that the `overwrite_symlink` changes fix a bug introduced in
5c20ee998c
2021-03-22 19:34:18 -07:00
91f048c056
gitlint-rules: Remove convoluted binary search for imperative forms.
...
This also fixes the suggestions for the following words: disabled,
disables, disabling, implemented, implementing, implements, kept,
made, took, using.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-22 18:08:01 -07:00
2b23609f9a
ci: Remove unused circleci config file and update codebase.
...
We have disabled CircleCI and are using GitHub Actions for automated
testing.
docs: Changed context from CircleCI to Github Actions and wrote
some documentation specific to GH Actions.
tools: Replaced env checks for CIRCLECI with GITHUB_ACTION.
README: Use GitHub Actions build status badge.
2021-03-16 15:11:21 -07:00
59c8f3ed92
ci: Use general terms for CircleCI.
...
GitHub Actions supports doing more than just CI,
and so in some contexts it's less obvious that we're
talking about just the CI if we refer to it instead of CircleCI.
2021-03-16 14:56:43 -07:00
d6307cc907
puppeteer_test: Add support to run tests with Firefox.
...
This commit introduces the `--firefox` argument,
which will allow us to run puppeteer tests
with Firefox also.
2021-03-12 12:14:37 -08:00
ccad00b7e9
provision: Suppress exception chaining for CalledProcessError retries.
...
When exception is raised inside an exception handler, Python 3
helpfully prints both tracebacks separated by “During handling of the
above exception, another exception occurred:”. But when we’re using
an exception handler to retry the same operation, multiple tracebacks
are just noise. Suppress the earlier one using PEP 409 syntax.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-03 16:25:03 -08:00
63c12d2e59
tools: Change help message for skip-provision-check argument.
...
This commit changes help message for skip-provision-check argument
used with various test commands. The message is changed with an
intention to be more clear about what this option actually does.
This commit is in series of various changes done to provide clarity
over the use of --force option which is renamed to
--skip-provision-check.
Fixes : #17455
2021-03-03 09:17:49 -08:00
911c5f19f1
tools: Rename force argument to skip-provision-check
...
This commit renames --force argument used with various tests to
--skip-provision-check. As a consequence of this name change all other
files that set --force option for the test commands have been updated.
This change is done in order to provide more clarity for using this
option for runnning tests.
This commit addresses issue #17455 .
2021-03-03 09:17:49 -08:00
ca515e5583
tools: Move registration of --force to test-scripts.py.
...
This commit moves --force option used with various tests to
test-scripts.py to have it alongside the logic that does provisioning
status assertion.
This is a step towards providing more clarity over use of this
argument with tests as asked in issue #17455 .
2021-03-03 09:17:49 -08:00
289b5bc100
lint: Re-enable imperative-mood checking.
...
This was mistakenly disabled in e1f943913a
2021-02-23 14:54:07 -08:00
12ade4c49d
lint: Rely on core gitlint skipping of revert commits.
...
gitlint 0.13.0 and above skip revert commits[1]. This obviates the
need for a custom rule.
[1] https://jorisroovers.com/gitlint/configuration/#ignore-revert-commits
2021-02-23 14:28:09 -08:00
279c4b0e24
puppeteer_tests: Port to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
4173070b3d
notifications: Fix composebox notification escaping
...
The "Narrow to PM with" notification above the composebox was
double-escaped, mangling names with single quotes in them. This removes
the escaping in i18next, causing the name to be escaped only in
handlebars.
2021-02-17 14:04:30 -08:00
6e4c3e41dc
python: Normalize quotes with Black.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
11741543da
python: Reformat with Black, except quotes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
5028c081cb
python: Merge concatenated string literals that Black would uglify.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
f92f99d92d
dependencies: Replace moment.js with date-fns.
...
Replaced methods/functions of moment.js with date-fns library.
The motive was to replace it with a smaller frontend timezone library.
Date-fns ~ 11.51 kb
moment.js ~ 217.87 kb
Some of the format strings change because date-fns encodes them
differently from how moment did.
Fixes #16373 .
2021-02-05 11:04:32 -08:00
7eeca9da46
provision: Add provision support for Ubuntu 20.10(Groovy).
...
PostgreSQL 13 is used when os_version is 20.10.
2021-02-05 09:30:34 -08:00
b8f57fa6bb
provision: Add provision support for KDE Neon 20.04.
...
PostgreSQL 12 is used for Neon 20.04, which is a fork of Ubuntu 20.04.
2021-02-03 11:51:05 -08:00
0d3f9fc855
install: Use PGroonga packages built for PostgreSQL packages by PGDG
...
Because we always use PostgreSQL packages by PGDG since Zulip 3.0.
Fixes #16058 .
2020-12-18 15:38:21 -08:00
9359dee75b
test_settings: Use TEST_EXTERNAL_HOST to override ‘testserver’ default.
...
This allows test-backend to work even if the user has EXTERNAL_HOST
set to something else.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-17 13:07:59 -08:00
d0d8c358b3
lint: Migrate typing.Text check to semgrep.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-16 18:17:41 -08:00
c1201bd69c
provision: Rename variables to postgresql.
2020-10-28 11:57:03 -07:00
2b0bbbb882
tools: Rename postgres to postgresql in tool names.
2020-10-28 11:57:02 -07:00
1f7132f50d
docs: Standardize on PostgreSQL, not Postgres.
2020-10-28 11:55:16 -07:00
31d0141a30
python: Close opened files.
...
Fixes various instances of ‘ResourceWarning: unclosed file’ with
python -Wd.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-26 12:31:30 -07:00
72d6ff3c3b
docs: Fix more capitalization issues.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 11:46:55 -07:00
5c6202ca97
notifications: Use a dynamic SVG favicon for unread counts.
...
Closes #2304 .
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-21 07:43:00 -07:00
6099612a15
lint: Add shfmt as a linter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-15 15:16:00 -07:00
dd48dbd912
docs: Add spaces to “check out”, “log in”, “set up”, “sign up” as verbs.
...
“Checkout”, “login”, “setup”, and “signup” are nouns, not verbs.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-13 15:47:13 -07:00
7f69c1d3d5
python: Catch specific exceptions from requests.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-11 16:11:41 -07:00
1c7db528bd
test_server: Wait for run-dev after terminating it.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:15:19 -07:00
ece0aaa6cc
tests: Remove use_db flag from test_server_running.
...
It was only ever true, since 2563f93d46
2020-09-18 15:13:40 -07:00
922940e223
tornado: Be more explicit about tornado configuration in testing.
...
Passing this through the environment needlessly complicates the logic.
2020-09-18 15:13:40 -07:00
3b301f522b
python: Tweak some magic trailing commas to avoid Black bugs.
...
https://github.com/psf/black/issues/1658
https://github.com/psf/black/issues/1671
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-03 17:51:09 -07:00
f91d287447
python: Pre-fix a few spots for better Black formatting.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-03 17:51:09 -07:00
75c59a820d
python: Convert subprocess.Popen.communicate to run or check_output.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-03 17:42:35 -07:00
b4597a8ca8
python: Elide default for store_{true,false} argparse arguments.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-03 16:17:14 -07:00
d751e0cece
puppet: Don’t install netcat.
...
It’s been unused since commit 0af22dad18#13239 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-03 10:33:47 -07:00
0682d5c0f3
provision: Convert "".format to Python 3.6 f-strings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 17:27:14 -07:00
424b441bb1
provision: Check for old Ubuntu or Python before starting Python.
...
This unblocks us from being able to use Python 3.6 syntax in
provision.py and its dependencies.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 17:27:14 -07:00
1ded51aa9d
python: Replace list literal concatenation with * unpacking.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 11:15:41 -07:00
a5dbab8fb0
python: Remove redundant dest for argparse arguments.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 11:04:10 -07:00
c1ba648b4f
dependencies: Add xvfb dependency.
...
The node package allow use to control xvfb apt package in puppeteer
tests. This help us create a fake display so we can run puppeteer in
headful (headless: false) mode, which is required to use the chrome
extension desktop capture API.
2020-08-30 23:38:52 -07:00
2f5f5d7749
dependencies: Remove PhantomJS from development environment.
2020-08-30 17:16:02 -07:00
42aa916967
sanity_check: Test for the virtualenv by its path.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 12:30:26 -07:00
61d0417e75
python: Replace ujson with orjson.
...
Fixes #6507 .
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:55:12 -07:00
768f9f93cd
docs: Capitalize Markdown consistently.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:23:06 -07:00
18dcb86de5
Revert "provision: Fix missing <sasl/sasl.h> headers during provision."
...
This reverts commit cc9dc07b07#16086 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-10 12:09:37 -07:00
cc9dc07b07
provision: Fix missing <sasl/sasl.h> headers during provision.
...
This fixes the error of missing sasl.h when compiling python-ldap
from source during provision.
2020-08-09 23:21:13 -07:00
Ganesh Pawar
Anders Kaseorg
Aman Agrawal
Riken Shah
m-e-l-u-h-a-n
Alex Vandiver
Wesley Aptekar-Cassels
aryanshridhar
aditya-mitra
Sutou Kouhei
Priyank Patel
Tim Abbott