d40c2bb166
emoji: Make uploading new realm emoji inaccessible for guest users.
2018-06-16 06:33:14 -07:00
64372690f9
emoji: Fix the filtering condition in `check_emoji_admin()`.
...
This commit fixes an unreported bug which if hadn't been fixed would
have caused errors while deactivating realm emojis in some corner
cases.
2018-03-20 22:24:44 -07:00
a49655e0d4
emoji: Migrate realm emoji to be addressed by `id` rather than `name`.
...
This commit migrates realm emoji to be addressed by their `id` rather
than their name. This fixes a long standing issue which was causing
an error on uploading an emoji with same name as a deactivated realm
emoji.
Fixes : #6977 .
2018-03-20 22:24:44 -07:00
52e5b78613
models: Change text representation for realm emoji.
...
This commit changes the textual representation for realm emoji to
give more info.
2018-03-11 16:17:47 -07:00
e2a6541133
i18n: Fix use of 'realm administrator' in translated strings.
...
These are user-facing and thus should refer to being an "organization
administrator".
2018-03-07 17:15:29 -08:00
04f4f7166c
zerver/tests: Use python 3 syntax for typing.
...
This patch was extracted by tabbott for just the files with no open
PRs modifying them.
2017-11-08 12:50:27 -08:00
1e87a4b68c
zerver/tests: Remove absolute_import.
2017-09-27 10:00:39 -07:00
ef722c5688
tests: Remove unused ujson imports.
2017-08-17 09:05:52 -07:00
d44c1e7070
result.json: Upgrade test_realm_emoji.
2017-08-17 09:03:35 -07:00
bab6893dbb
test_realm_emoji: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
543cb11d17
test_realm_emoji: Migrate tests to use default test realm emoji.
2017-07-27 18:59:02 +00:00
8fa861a020
test_realm_emoji: Add test.
...
Add a test for checking that non-admins can upload a custom emoji when
`add_emoji_by_admins_only` is set to False.
2017-07-27 18:59:02 +00:00
b683af2cbb
test_realm_emoji: Fix some typos.
2017-07-27 18:59:02 +00:00
eeb25b6b4b
populate_db: Add a test realm emoji while populating databases.
...
Add `green_tick` realm emoji which can be used while performing tests.
2017-07-27 18:57:06 +00:00
ed0423784d
test_realm_emoji: Replace get_user_profile_by_email.
...
Replace with get_user.
2017-07-13 00:45:24 +05:30
df5df76961
urls: Use POST for zerver.views.realm_emoji.upload_emoji.
...
The upload_emoji endpoint is changed from PUT to POST because
this endpoint is not idempotent.
2017-07-07 10:31:43 -07:00
3c9705ce98
actions.py: Instead of deleting a realm emoji just deactivate it.
...
Instead of removing an emoji from the database, just mark them as
deactivated so that they can't be used further but can be rendered
properly in reactions and messages.
Fixes : #4750 .
2017-07-05 13:00:15 -07:00
298e23b447
realm_emoji.py: Allow an user to delete an emoji uploaded by them.
...
If a realm is configured to allow any user to upload an emoji,
then, an emoji author must be allowed to delete an emoji uploaded
by them.
2017-05-29 20:21:25 -07:00
6b49e667ef
tests: Replaced @zulip.com references with self.example_ functions.
...
This cleans up the excessive use of @zulip.com emails in the tests.
2017-05-23 20:59:50 -07:00
68e5898a07
emoji.py: Add restriction that realm emoji must be lowercase.
...
Raises error if emoji name has an uppercase letter in it.
2017-05-11 19:10:21 -07:00
f13d6a18eb
realm-emoji: Add realm emoji uploading instead url providing.
...
- Add file_name field to `RealmEmoji` model and migration.
- Add emoji upload supporting to Upload backends.
- Add uploaded file processing to emoji views.
- Use emoji source url as based for display url.
- Change emoji form for image uploading.
- Fix back-end tests.
- Fix front-end tests.
- Add tests for emoji uploading.
Fixes #1134
2017-05-01 14:50:20 -07:00
cc25193faa
models: Use Realm.string_id instead of domain in RealmEmoji.__unicode__.
2017-03-13 09:26:26 -07:00
121b926962
emoji: Fix 500 trying to remove nonexisting realm emoji.
2017-01-16 23:48:07 -08:00
f3b9abee14
Convert realm emoji upload to use PUT properly.
2017-01-16 23:45:12 -08:00
2b0a7fd0ba
Rename models.get_realm_by_string_id to get_realm.
...
Finishes the refactoring started in c1bbd8d
2017-01-04 17:12:23 -08:00
8e7fa6b2de
emoji: Add add_emoji_by_admins_only realm setting.
...
This setting controls whether normal users can add realm emoji.
Fixes #978 .
2016-12-27 15:46:14 -08:00
1238d08f72
emoji: Add emoji author data in API.
2016-12-27 15:42:21 -08:00
ffa724f8fc
emoji: Add author field to RealmEmoji table and track.
2016-12-27 15:42:04 -08:00
9f8630fed8
tests: Access realms by string_id.
...
Replaces get_realm() function by get_realm_by_string_id() function
in zerver/tests.
Fixes #2226 .
2016-11-15 13:32:20 -08:00
4582a98c09
tests: Split out ZulipTestCase and WebhookTestCase to a separate file.
...
Fixes #1671 .
2016-11-10 19:29:43 -08:00
5daa2b10d5
tests: Add coverage for RealmEmoji.__unicode__().
2016-09-19 14:57:53 -07:00
fd6ee7117f
tests: Renamed AuthedTestCase to ZulipTestCase.
2016-08-22 19:07:44 -07:00
6937f63fd5
Add client_get() test helper.
2016-07-27 20:49:33 -07:00
966375d74c
Annotate test_events, test_realm_emoji, test_uploads.
2016-06-04 11:53:20 -07:00
d77e8df3fa
Add tests for zerver/views/realm_emoji.py.
2016-06-03 23:12:53 -07:00
Shubham Dhama
Harshit Bansal
Tim Abbott
rht
Umair Khan
Vishnu Ks
Lech Kaiel
Cory Lynch
K.Kanakhin
Rishi Gupta
paxapy
Igor Tokarev
reyha
sinwar
Steve Howell
Tim Abbott
gregmccoy