4eb9d67b70
models: Extract get_human_admin_users function.
...
This function is an alternative to get_admin_users that we use in all
places where we explicitly want only human administrative users (not
administrative bots). The following commits will rename
get_admin_users for better clarity.
2019-06-20 14:32:30 -07:00
aa217efdbe
lint: Add rule to ban rgb(a) in css/scss files, use hsl(a) instead.
2019-06-20 11:34:59 -07:00
904422d8bc
css: Convert colors from rgba to hsla format.
2019-06-20 11:34:59 -07:00
3e589cf65e
css: Convert colors from rgb to hsl format.
...
Note that we are not converting the stream colors.
2019-06-20 11:34:34 -07:00
549338dc50
refactor: Use variables for repeated colors in alerts.scss.
2019-06-20 11:20:29 -07:00
1fa82b9dea
refactor: Extract display and animation properties from alert styling.
2019-06-20 11:20:29 -07:00
25dbda1e53
stream settings: Fix bug in deactivate stream modal appearance.
...
Stream deactivation modal should be append to main
unique id, stream overlay element.
This commit also add `new-style` class to modal.
Fixes #12394
2019-06-20 11:09:52 -07:00
b530c87d26
create_user: Try to read password file only when param specified.
...
The argument parser has default empty values set for the options
`--password` and `--password-file`, and this causes the script to try and
read a password file even when the argument was not provided.
2019-06-20 11:04:17 -07:00
9576ce589d
check_user: Get rid of incorrect encode call for initial password.
2019-06-20 11:04:17 -07:00
51793f70cf
docs: Provide link to available message flags from get-messages.
2019-06-19 11:44:48 -07:00
db3d81613b
decorator: Refactor @require_non_guest_human_user decorator.
...
Rename @require_non_guest_human_user to @require_member_or_admin.
This is a refactor commit prior to introduction of Administrator
Bots.
2019-06-18 17:11:58 -07:00
4818011199
zulint: Add a basic README.
2019-06-18 12:25:46 -07:00
6d040d330c
lint: Add --list arg which lists all the registered linters.
2019-06-18 11:32:04 -07:00
6457c1f7c6
lint: Generalize --skip arg and move logic to zulint/command.
2019-06-18 11:32:04 -07:00
995b357cde
lint: Add --only agr to run only the specified linters.
2019-06-18 11:32:04 -07:00
cf8653945f
lint: Rename commit_messages to gitlint.
...
Use `gitlint` name to register gitlint linter since it is the commonly
used name for it.
2019-06-18 11:32:04 -07:00
6b73926e93
lint: Add --skip arg to replace --no-gitlint/mypy.
...
Use --skip=gitlint,mypy instead of --no-gitlint/mypy.
2019-06-18 11:32:04 -07:00
426a222b7e
lint: Rename --verbose to --verbose-timing.
2019-06-18 11:32:04 -07:00
dcd46f1c11
lint: Move shebang_rules out of `RuleList` class to generalize it.
...
shebang_rules was moved to custom_check.py. Also add shebang_rules only
to those rules which need it.
2019-06-18 11:27:59 -07:00
db25c0c2ca
lint: Combine functions in custom_rules into RuleList class.
...
This makes linting rules in zulint more general. Make necessary
changes in tools/lint and tools/custom_check.py to run with the new
RuleList class.
Modify tests for `RuleList` class. Tests only include minor changes to
test with the new class.
2019-06-18 11:27:50 -07:00
fd25ced43c
import: Fix check for whether data-user-id is present.
...
Apparently, the `in` keyword in Beautiful Soup does something different.
2019-06-18 11:13:32 -07:00
649e363ee3
import: Fix handling of legacy and wildcard mentions.
...
Our recently-added code for rewriting user IDs on data import didn't
correctly handle wildcard mentions and mentions generated by very old
versions of Zulip (pre data-user-id).
2019-06-18 10:35:01 -07:00
2538f84447
import: Fix bad database query for first_message_id.
...
The previous query ended up doing an awkward join that did not
guarantee use of the Recipient index on zerver_message, turning a very
fast query into something that could take much longer for a single
stream than the rest of the import combined.
2019-06-18 10:25:00 -07:00
5af8b980fe
css: Remove redundant `#settings` from `zulip.scss`.
...
Since `settings` element no longer exists, hence removing it from
zulip.scss.
2019-06-18 10:09:23 -07:00
6105b05f50
css: Remove redundant `#organization` from `zulip.scss`.
...
This has been dead code since 1143ed7219
2019-06-18 10:03:35 -07:00
a716b09a3f
upgrade-zulip-from-git: Fix handling of errors in git clone.
...
Apparently, the `chown -R` would never run if the original clone
attempt had networking errors, leading to inability to use
upgrade-zulip-from-git without manual intervention.
2019-06-18 10:00:50 -07:00
d7b4de2348
messages: Add support for passing user IDs for pm-with clause.
...
We also document support for user IDs in the pm-with narrow operator.
Edited by tabbott to document on /api rather than in the /help page.
Fixes part of #9474 .
2019-06-17 17:38:51 -07:00
33e798168a
docs: Declare the markdown code block to be json.
...
This just adds json syntax highlighting to api documentation page
at /api/construct-narrow.
2019-06-17 17:38:18 -07:00
e3431976ce
validator: Add validator for checking string or integer list.
...
This validator will be used to check if string or user IDs list is
passed in.
2019-06-17 17:33:58 -07:00
b8268c66d5
webhooks/bitbucket3: Add the `diagnostics:ping` event.
...
Note: Unlike with the other events supported by this webhook so far,
to determine this event's event type, we need to use the X-Event-Key
HTTP Header.
2019-06-17 17:33:32 -07:00
09e57389ca
Revert "settings_profile_fields: Refactor `read_field_data_from_form`."
...
This seems to have made our Casper tests fail.
This reverts commit e3237cdee2
2019-06-17 16:35:57 -07:00
9760c8cfc9
tools: Fix postgres-init-*-db cache handling.
...
Previously, it didn't properly update the stamp files that determine
our caching behavior, so if one ran test-backend afterwards, nothing
would happen.
A secondary issue that this commit does not fix is that provision will
end up rerunning the whole thing.
2019-06-17 16:24:13 -07:00
544f9c74ce
export: Use outbox emoji for managing who is exported.
...
This is a little more unambiguous.
2019-06-17 16:10:28 -07:00
e3237cdee2
settings_profile_fields: Refactor `read_field_data_from_form`.
...
This is important setup for supporting external account type fields.
2019-06-17 15:02:36 -07:00
0b4384f4cd
custom profile fields: Extract function `validate_custom_field_data`.
2019-06-17 14:56:02 -07:00
e7b9b93f84
test-backend: Move `bot_avatar` to `var/<uuid>/test-backend`.
2019-06-17 13:56:34 -07:00
fbcb05dae6
test-backend: Move `test-log-dir` to `var/<uuid>/test-backend`.
2019-06-17 13:56:34 -07:00
dd339a57af
test-backend: Move import/export ouput into `var/<uuid>/test-backend`.
2019-06-17 13:51:40 -07:00
8e626d3db3
zulip_tools: Add a function to get or create the var uuid path.
2019-06-17 13:51:40 -07:00
ff38d125b1
settings: Configure LDAP avatar synchronization in dev environment.
...
This should make it a lot more convenient to do manual testing of
these common LDAP configuration options.
2019-06-17 13:18:36 -07:00
88b77af54f
puppet: Add support for changing the nginx port directly.
...
This provides a clean process for changing Zulip's nginx port.
2019-06-17 12:24:22 -07:00
efe5e53118
docs: Update list of links to not check in tests.
2019-06-17 12:24:22 -07:00
e6cb83b6e9
docs: Add a new heading section on Casper debugging.
...
Also enhance the error output from the casper tool.
2019-06-16 22:20:41 -07:00
4049a19e0e
docs: Update and polish docs on the static asset pipeline.
...
Tweaked by tabbott to make the claims about new modules in TypeScript
more muted.
2019-06-16 19:09:45 -07:00
51ba9ddd89
postfix: Inserted compulsory setting for postfix ≥ 2.10.
...
One of smtpd_relay_restrictions or smtpd_recipient_restrictions is
required by postfix ≥ 2.10 (see
http://www.postfix.org/SMTPD_ACCESS_README.html ).
This is important for using the email mirror on Ubuntu Bionic.
2019-06-16 18:48:39 -07:00
b633092ff1
settings: Fix linkifier settings page example.
...
The Linkifier settings page example crossed wires with GitHub commit
hashes and issue IDs.
Fixes #12591
2019-06-16 16:40:36 -07:00
496671b04a
docs/git: Fix small grammatical error.
2019-06-16 16:28:39 -07:00
b41c2d93d1
puppet: Exclude squashfs filesystems from nagios disk checks.
...
These generally aren't being written to.
2019-06-16 16:22:23 -07:00
0ec1b4e82c
puppet: Move check_send_receive_time to the _once ruleset.
...
We don't actually want to run this bundle of message-sending Nagios
checks to run on every single server.
2019-06-16 15:48:35 -07:00
df83979c76
zulip_ops: Extract a prod_app_frontend_once ruleset.
2019-06-16 15:48:35 -07:00
Tim Abbott
Aman Agrawal
Thomas Ip
Yashashvi Dave
Puneeth Chaganti
Hemanth V. Alluri
Mohit Gupta
Pragati Agrawal
Priyank Patel
Wyatt Hoodes
Fabian Stanke
Benjamin Melançon